From patchwork Wed Jan 11 15:35:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 18850 Received: (qmail 90975 invoked by alias); 11 Jan 2017 15:36:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 88562 invoked by uid 89); 11 Jan 2017 15:36:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=intuitive, sk:837b9ee, remote_state, *rs X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jan 2017 15:36:14 +0000 Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48]) by (Symantec Mail Security) with SMTP id 1A.30.23836.BE056785; Wed, 11 Jan 2017 16:36:12 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.48) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jan 2017 16:36:56 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxcz23q12-y4.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.829.4; Wed, 11 Jan 2017 15:36:10 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] Update comment in remote_can_async_p Date: Wed, 11 Jan 2017 10:35:59 -0500 Message-ID: <20170111153559.8336-1-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR07CA0009.namprd07.prod.outlook.com (10.173.33.147) To AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) X-MS-Office365-Filtering-Correlation-Id: 4f317e19-b719-41e5-9ad7-08d43a37919c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 3:+dGePUQE2FNQipSyOHkaf9w4Fv0d61UwWu/oMiMtXQXQeb0hKINaWIaJDAXyDTXvTGVWEcgKblx1fEVyvs/0xQreZPuuaMRVZ1uXDo6rqy++6ezEw6kY7INbNYB0pC37q7wSkN2N5WY8A5krw9q81Sg44bZVRo+EkJZDP7wIAHYW3ijSeHXY5mFysV8wXfElqVNuelnT6xDAajkxI1yu8IplvzLSeXvYD6L5SJJnChcmxBecXx4Op/vnbb+s7rEg75FZqn/425Z5wXnkNtMPqg== X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 25:J3RKSKifmWU26qSFFJNw78YaZoHHqySv79+X6lo+CSi+y9NnXzHrKn1thjpFnCBVmk1kWp7EMa2FY+2csEaK0J6pumVv0Y0HRvnKiNiZuIN7YgNk3Mch0yBaSzkFil4one5GhRg1k8IlVT84UswXzTfjOZiYWTzPPfBY3f4zSTLi5IUts0/JG4SJgb4J909MRLkLAxRGHAOS9IMJUBqI6e86C9noozxsTf8jnRqV5N2k8X9ti+3l1zEM1b3Boku9ot9QZpGIy8uzaK4mBWLjAHRH8OPk84PeWi11Xx8v78q7s7n1FQ5IceldOUpJYIJlOHXoM3oIvtCElfHrnwWb9b+lrwijAWpMs7DKcSP30VX1zDC8gIgJvRTgWG9Ub5URiM5qTHoFvViT+WYqT3zSJcKN+26iCyLdRAzWqkUaimkUiLkdlND6sR+YwSFja3vRzcc/aWoHS1gcLrHR7lQ32Uagq8t5b/KVKuz6mLZI4ZJifzNVvMdFwVp0CIiyUOkabXy8oJJXcMq2NFTX8snzdpgfxUXojjNMzq98faLWXPZzYza/nVChmOdaVKhnuwd9TmcCIqKkJcTijeDtY6//DwMEP4rjBR7YZ6iAn3IDtB8Jjr8YRA6/NvQV6ihvBMP+1UJICZHmjok3YZTnNFiCWiJwj7t1GyxkunJyObRFawlUp1KBOtxtdO61WkOspdhLK62g3fDBRYYlymKLwQUiv3Z3J12BXULY8GnapYHbaHvFKLWJgfUkvhm4MKHxAph00qZwpjVVVqDUH3WvF6mxgA== X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 31:J+LCbDzXtIwHkRsPD/WyLIx6Nor7M35idXZPTOYaNoJxYJaL1uFje8zK5g0RWIQvUfhT8qeqeHMN556B6X/hIKxp8EowclcuJMDkRrrumknBT2EMxSsvvBZ5CEOtmLYJidOjYkfGfiLRuRpduittkGQZvTpW+RZLYUbu2caeV35Q3Gr49iG46Cm4SAnbaqcFGsJxO1ed8FNH5xcySuh/JitUWs73/tzloBhxwbU77x7BBjbgjuE74hDnkEQxXN7Q5D9+2CMd1iQ+koK2s2RvXw==; 20:EszQUkmjwK0KjT/Mmltq1SOFO9/0N/pKYv/Xe32xkjzIh69gzRapHck8zpnTJHZMEaLpw700prpoMQw6oCVmbZMoLbSEGoqh3K90hX6IURQlnnHbCr65/8+l3CAbdUmPWK+iY9IaWHJjl/9Lh7/3KUvxzAzAsn0HKsZ441eaJNsfydBLzB5MLidosbRqAOrE33sp/cXMIHVD4cZakOvN8zSXUe32oz+SAvfCEyET7qaXexkBAfPHAEE5X6WIDnNbEQ/eROG4DK9rWc7mRnyZuov+1xKJKgnxYPErTNOsZNR+jb1qswsg6sTIKc3KDDDT5myvC9NDf3WMy0O3fK8eVHqHilPbrot5MJuGor7cWbj3O9p8vE+05U7DHvttB2PeIOB2V4LWb+hlUEFN20XcSiwDkPTcsM3ckkRAqmVuWSSh+eYDmuFzq+zn/IyJnUYNu6Jt8NLfbvcDmSbyuL+J2pWCdiduzFDiry0oBOw2XBq+hLmeme1DCfIEetal6LoA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123558021)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:AMSPR07MB389; BCL:0; PCL:0; RULEID:; SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 4:BW+sd2NQNC9ep23jQkmhOdN1l8+SfmpGKayHKj2oAFFU8Qzwn/uFyPkqg153JP5u269RNEkZrF59rruY3+LSg6gcFB1Mw8Wgg0OG1wbMbUc3VzQTYjCEsOeNvkQjhTQh+L9w1qeh2OTpC2FxPyZklB6b40oUi9CrL669vs0hSEZyEZ6WKS5Y+Mccmn0dUDsxZVlr90Ev8pH9MQVLrrS17nPf4DHKuAwg8HkDCagbOICa2QAo7yKFt9jCp2z7nZx8XI4GLE4a2xpK0dTTmOd1aQN5aEmoY4dBi/n6vj+bXnifnSro16To7rGI32JRQ0kVhW5eVBBx7uI881VrnnKi31hrLAB0hFiHa0Arq2bumInqbdkDSYMQkZAzwslE1DX2uHa3FIfK5tdx8GfC++bKNFsBxTtRDqz/5VL7ByXk9+avuUQKOUfbkeC+HOU14vWpF8ovGwQGtYeo861Jm965YKjagQCfL4Nl8MD7jkVqHOb0Ro72sGKXmnB/3fAQyr2VJqtGFavQyiRU7TsVGd4W8XWfePjZlMV/adyeilmTG44eWH9p7gf8lKpuJAA+vnzzS0DH9wWiLR9AXFnVkwXIwUgfTPvxP/TAQrEz8kvhEYE= X-Forefront-PRVS: 01842C458A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(54534003)(5003940100001)(107886002)(5660300001)(7736002)(4001430100002)(305945005)(2906002)(50986999)(38730400001)(97736004)(81156014)(15650500001)(86362001)(106356001)(42186005)(33646002)(101416001)(81166006)(105586002)(2351001)(25786008)(47776003)(8676002)(66066001)(6666003)(110136003)(92566002)(6916009)(6486002)(6506006)(36756003)(6512007)(50226002)(4326007)(6116002)(48376002)(68736007)(1076002)(50466002)(450100001)(189998001)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB389; H:elxcz23q12-y4.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB389; 23:nTrXpIegNV953t5xPPYwu1dnzSOFGunhcYyyuIqQ9f?= =?us-ascii?Q?lN3bzQcMs1z5pG/xNAei2xWgryTzCfI4QYkLFzJeT+ZmZmpGOqp9uPpCeFly?= =?us-ascii?Q?FP/A3CSAaO+b1+9k9uRdWVQtgUh47YW7hG9TFXY3WpVZ9ZzKdk06EHTAMROu?= =?us-ascii?Q?3LkXFO+aCB1N98B0gLD5Ip5F8fGAML33fG/f48HIoCsupwYiPCRvyUKZ4GX5?= =?us-ascii?Q?oDLoIVngDZz8nTdTYpplyaYcLz+pv42mBXezGmhWFUJGzMqqx9Eh/XKnxc9T?= =?us-ascii?Q?UM4N8GnddRAh5qnSBQ9dRp20W1tYW9FBkkBvivpXYQUHOuWJqmC42UBt8cev?= =?us-ascii?Q?vZJ13riq7U2zLAO/aw/QpwP7Ssu8Xt7KzwBPu69ZjgqpXPKQmCWH45AxPHzb?= =?us-ascii?Q?T2CGwsKg32NapNUH7opIVxpxeITyb+JER8Sfy0KLmgutAr2XeOIxBFILoIN4?= =?us-ascii?Q?rYhKBS/a4bQ58ld9YI6Lq7W7QGMoWW4OKfTVIub8l1dnS88SWeoUqcFBjpVB?= =?us-ascii?Q?IIAogBEgX3gGjXOpP9S/eiUjOk+kyRA0YszZpl8SD6rZhEDx88jbc5btxLQf?= =?us-ascii?Q?IdQAe+jQweC9qsGDRdpQVzYL4OSYbldXHBIW7HaMR89ZBu0kY5k3H1XjxtTu?= =?us-ascii?Q?+Bag4efM5e5rvfHd7Qbrlk4cwG4Y7AtZg8enRbxbuIRqtW84B3Xx3PdS76FV?= =?us-ascii?Q?TYOhOxQ3uu7ckx+MdI2CrFIfoxz+1wVNTt6BjFsdvMwQ+iDS78odZ/QG0iDR?= =?us-ascii?Q?YfmqzSS26jlLQadsbWP+Q4IH+eC7J/upcg6YgdKLqO+yFRBZFk4d5TejPUNS?= =?us-ascii?Q?LpDNVshcn8X7dxteI0uA7m4trbBPEH/O1YRbl7KTlCURrfVuDFWTvu1mwGvX?= =?us-ascii?Q?nqVzf9R5JEXqtuCF9iLokT8F+K7jf72jY8iuEastd0jj6cfcgrKP8ifRmlsk?= =?us-ascii?Q?hrsSbLKJj6CSovxz49v7ndgrElIKwbtzdMIEJ00sEr7KnMHXciaNgGDLuWyq?= =?us-ascii?Q?onVJdYiqqdBZ0DM9fXQ8YHZrxIUMtn4iM2Y0nqeVHwcskTh9uLo7FfiwS2yW?= =?us-ascii?Q?2JwJ0qq6CGC2PFz0j+jx7vI9CHXlUsCFeL7CKlVrEDYuNCvZ4SjTAyKOjx3i?= =?us-ascii?Q?GPrL/EWte0Gz6batGonpUA3dT5DmDptIuIkOBzgRrgAdPy14APnvOrooTbcx?= =?us-ascii?Q?hMli+4BD7QBJjQNre9GGKF7sjcszzm5F2W?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 6:1zb/juE1F5IiqxU2FUiL3cd6T9gtjFsDa7EedUT7FP0mAGTPZqddngjWYs6MgHQwvSn7wkGFYWUV4uVfMsO0GVSFeAIKEdK0ed5EA9VQYJSRaG6a/1UScBVeJ7G3Y5BaV/6WaP8vqZFa5ZrHLadjZ7GgM5aGG9mI8EPdoTdDsvodPBLmwHlkGsY/FtfhymYwUrZa6ww4qEStlVEbiTZc9LSh21wdFm5//b2nGQiEMV2fRByKBQo58r0s/6uZz795o7xbjrXqhbbG4q7mvZAunnm1cOu7aLuv2IITlJ6iBGHymJczTc2XQLIIWCxoM9xnGNUD3YbFqcG696OCVjtERDdi7lsy6Mrn1Ecvco6OaUGmsBylI+02qUgA95zBTQoCS9Auy1p8PQbOvpxjO8ZFV/wl0EwuwOoEttpJZNxWpdw=; 5:XiYkQMkDJYOwXfQv6F42U5irYxJ2cYjzGj80lpP3L1qssGSlBfFlwL/+OWWJx0MjRX3aue27GlTaJkeZQJzmarJvcGXL+xBlX9hOtD/QWWzuwj2LOqB2+9ZzfvUUySIUg0PpaVh5wXQR2QUYXQt/xQ==; 24:jd28AFICyWpP0SDnEimIjSyyEk+vfD5DeM/c489SP5U008Rt86Jq56TrQGS9W7bJCQ1hUiXGPdjV/QdTTOe3vQWDwZqRW3oI1IMHEUsqq6U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB389; 7:Ur0a0safZJpw7wqltn46V7Cd3iKBTRfo6iTCDYzKsLjP3CwPiH9NdQojqZny1poP0OXDNIhSV3WxeVbdt5vpbb7tEKBM5Bo3tpBI1/42NMpQ9A3yPKeWq8KTagCF5Z3t5bQoram7m2wiSaGSE+6ZhYGWzF8D/UtFNBi1gHYfm954OIhYU8p513SDVlWwP0b5add4sSiPurmMAclSSYp+qdP+K5gDfN3MIZCwmydTscTIZrknvTkmOm0Km1JPq0ZMAHyuIJt2xJtAYgLVrk7ElYsNkSaoHLzHJ8PpXZoHa9opshLvp9yUYY/6z1+7U6neH8E+gJVr3O1tp/Tb27Mx3tEnuH5qJwNmnmCByn+lxqYi2hf1UONPgiRHkU4LDtaWYl1uDuPCTm3i1PXA8n/QdY435vXbgPW7mWcjxtPpsgWisL19fbi1xcyqO1zkDprITntVBA3PA1LqH77iiX4JdA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2017 15:36:10.2067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB389 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes I find this comment counter intuitive, and it probably predates the always-target-async change. AFAIK, remote will always be async, unless the user explicitly prevents it with "maint set target-async off". gdb/ChangeLog: * remote.c (remote_can_async_p): Update comment. --- gdb/remote.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/remote.c b/gdb/remote.c index 837b9ee512..c73c30aacd 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -13653,8 +13653,9 @@ remote_can_async_p (struct target_ops *ops) { struct remote_state *rs = get_remote_state (); + /* We don't go async if the user has explicitly prevented it with the + "maint set target-async" command. */ if (!target_async_permitted) - /* We only enable async when the user specifically asks for it. */ return 0; /* We're async whenever the serial device is. */