From patchwork Wed Nov 23 20:06:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Baldwin X-Patchwork-Id: 17745 Received: (qmail 40154 invoked by alias); 23 Nov 2016 20:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40026 invoked by uid 89); 23 Nov 2016 20:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=baldwin, Baldwin, (unknown), HX-Greylist:EST X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 20:07:50 +0000 Received: from ralph.com (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 2B07410AA5E for ; Wed, 23 Nov 2016 15:07:48 -0500 (EST) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH 3/3] Do not use std::move when assigning an anonymous object to a unique_ptr. Date: Wed, 23 Nov 2016 12:06:52 -0800 Message-Id: <20161123200652.89209-4-jhb@FreeBSD.org> In-Reply-To: <20161123200652.89209-1-jhb@FreeBSD.org> References: <20161123200652.89209-1-jhb@FreeBSD.org> X-IsSubscribed: yes Using std::move forces an extra copy of the object. These changes fix -Wpessimizing-move warnings from clang. gdb/ChangeLog: * gdb/ada-lang.c (create_excep_cond_exprs): Do not use 'std::move'. * gdb/ax-gdb.c (agent_eval_command_one): Likewise. (agent_eval_command_one): Likewise. * gdb/breakpoint.c (parse_cond_to_aexpr): Likewise. (parse_cmd_to_aexpr): Likewise. * gdb/dtrace-probe.c (dtrace_process_dof_probe): Likewise. * gdb/parse.c (parse_expression_for_completion): Likewise. --- gdb/ChangeLog | 10 ++++++++++ gdb/ada-lang.c | 6 +++--- gdb/ax-gdb.c | 8 ++++---- gdb/breakpoint.c | 8 ++++---- gdb/dtrace-probe.c | 3 +-- gdb/parse.c | 2 +- 6 files changed, 23 insertions(+), 14 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 051d4ce..d331edf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,15 @@ 2016-11-23 John Baldwin + * gdb/ada-lang.c (create_excep_cond_exprs): Do not use 'std::move'. + * gdb/ax-gdb.c (agent_eval_command_one): Likewise. + (agent_eval_command_one): Likewise. + * gdb/breakpoint.c (parse_cond_to_aexpr): Likewise. + (parse_cmd_to_aexpr): Likewise. + * gdb/dtrace-probe.c (dtrace_process_dof_probe): Likewise. + * gdb/parse.c (parse_expression_for_completion): Likewise. + +2016-11-23 John Baldwin + * common/new-op.c (operator new): Mark 'noexcept'. (operator new[]): Likewise. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 0647a9b..78c7d6f 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -12343,9 +12343,9 @@ create_excep_cond_exprs (struct ada_catchpoint *c) s = cond_string; TRY { - exp = std::move (parse_exp_1 (&s, bl->address, - block_for_pc (bl->address), - 0)); + exp = parse_exp_1 (&s, bl->address, + block_for_pc (bl->address), + 0); } CATCH (e, RETURN_MASK_ERROR) { diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c index cd97585..49108de 100644 --- a/gdb/ax-gdb.c +++ b/gdb/ax-gdb.c @@ -2555,8 +2555,8 @@ agent_eval_command_one (const char *exp, int eval, CORE_ADDR pc) arg = exp; if (!eval && strcmp (arg, "$_ret") == 0) { - agent = std::move (gen_trace_for_return_address (pc, get_current_arch (), - trace_string)); + agent = gen_trace_for_return_address (pc, get_current_arch (), + trace_string); } else { @@ -2565,10 +2565,10 @@ agent_eval_command_one (const char *exp, int eval, CORE_ADDR pc) if (eval) { gdb_assert (trace_string == 0); - agent = std::move (gen_eval_for_expr (pc, expr.get ())); + agent = gen_eval_for_expr (pc, expr.get ()); } else - agent = std::move (gen_trace_for_expr (pc, expr.get (), trace_string)); + agent = gen_trace_for_expr (pc, expr.get (), trace_string); } ax_reqs (agent.get ()); diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 67b610c..e2fcc08 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -2268,7 +2268,7 @@ parse_cond_to_aexpr (CORE_ADDR scope, struct expression *cond) that may show up. */ TRY { - aexpr = std::move (gen_eval_for_expr (scope, cond)); + aexpr = gen_eval_for_expr (scope, cond); } CATCH (ex, RETURN_MASK_ERROR) @@ -2452,9 +2452,9 @@ parse_cmd_to_aexpr (CORE_ADDR scope, char *cmd) that may show up. */ TRY { - aexpr = std::move (gen_printf (scope, gdbarch, 0, 0, - format_start, format_end - format_start, - fpieces, nargs, argvec)); + aexpr = gen_printf (scope, gdbarch, 0, 0, + format_start, format_end - format_start, + fpieces, nargs, argvec); } CATCH (ex, RETURN_MASK_ERROR) { diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c index 38654a4..29c2d28 100644 --- a/gdb/dtrace-probe.c +++ b/gdb/dtrace-probe.c @@ -430,8 +430,7 @@ dtrace_process_dof_probe (struct objfile *objfile, TRY { - expr = std::move (parse_expression_with_language (arg.type_str, - language_c)); + expr = parse_expression_with_language (arg.type_str, language_c); } CATCH (ex, RETURN_MASK_ERROR) { diff --git a/gdb/parse.c b/gdb/parse.c index afafc35..323de77 100644 --- a/gdb/parse.c +++ b/gdb/parse.c @@ -1309,7 +1309,7 @@ parse_expression_for_completion (const char *string, char **name, TRY { parse_completion = 1; - exp = std::move (parse_exp_in_context (&string, 0, 0, 0, 0, &subexp)); + exp = parse_exp_in_context (&string, 0, 0, 0, 0, &subexp); } CATCH (except, RETURN_MASK_ERROR) {