[testsuite] Disable ccache

Message ID 20160904150829.GA10655@host1.jankratochvil.net
State New, archived
Headers

Commit Message

Jan Kratochvil Sept. 4, 2016, 3:08 p.m. UTC
  On Sun, 04 Sep 2016 12:07:04 +0200, Ben Elliston wrote:
> On Sun, Sep 04, 2016 at 10:44:27AM +0200, Jan Kratochvil wrote:
> > So I find most safe and easy to just disable ccache for all
> > testsuites.
> 
> Thanks--I agree.  As a principle, it makes no sense to cache in a test
> environment.

So now it just could be also included in GDB lib/future.exp.

OK to check it in?


Jan
gdb/testsuite/ChangeLog
2016-09-04  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* lib/future.exp: Set CCACHE_DISABLE, clear CCACHE_NODISABLE.
  

Comments

Pedro Alves Sept. 15, 2016, 11:59 a.m. UTC | #1
On 09/04/2016 04:08 PM, Jan Kratochvil wrote:
> On Sun, 04 Sep 2016 12:07:04 +0200, Ben Elliston wrote:
>> On Sun, Sep 04, 2016 at 10:44:27AM +0200, Jan Kratochvil wrote:
>>> So I find most safe and easy to just disable ccache for all
>>> testsuites.
>>
>> Thanks--I agree.  As a principle, it makes no sense to cache in a test
>> environment.
> 
> So now it just could be also included in GDB lib/future.exp.
> 
> OK to check it in?

OK.

Thanks,
Pedro Alves
  
Jan Kratochvil Sept. 15, 2016, 12:07 p.m. UTC | #2
On Thu, 15 Sep 2016 13:59:31 +0200, Pedro Alves wrote:
> On 09/04/2016 04:08 PM, Jan Kratochvil wrote:
> > OK to check it in?
> 
> OK.

49b4de64242d4ae035e0e2197837278e33c187fc


Jan
  

Patch

diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
index 2ecff2e..e7c9d9a 100644
--- a/gdb/testsuite/lib/future.exp
+++ b/gdb/testsuite/lib/future.exp
@@ -666,3 +666,8 @@  if {[info procs lreverse] == ""} {
 	return $retval
     }
 }
+
+# Various ccache versions provide incorrect debug info such as ignoring
+# different current directory, breaking GDB testsuite.
+set env(CCACHE_DISABLE) 1
+unset -nocomplain env(CCACHE_NODISABLE)