From patchwork Sun Jul 3 15:43:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 13598 Received: (qmail 38694 invoked by alias); 3 Jul 2016 15:43:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38680 invoked by uid 89); 3 Jul 2016 15:43:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-Greylist:Sun, Hx-languages-length:1586, ldl, 2016-07-03 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 03 Jul 2016 15:43:38 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01DB865426; Sun, 3 Jul 2016 15:43:37 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-204-24.brq.redhat.com [10.40.204.24]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u63FhX80027903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 3 Jul 2016 11:43:36 -0400 Date: Sun, 3 Jul 2016 17:43:33 +0200 From: Jan Kratochvil To: Andreas Arnez Cc: Pedro Alves , gdb-patches@sourceware.org Subject: [patch] babeltrace compilation regression [Re: [PATCH] Avoid non-C++-enabled babeltrace versions] Message-ID: <20160703154333.GA9193@host1.jankratochvil.net> References: <5720AA62.7040505@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes On Wed, 27 Apr 2016 16:24:23 +0200, Andreas Arnez wrote: > Thanks, pushed after adjusting the commit message. Since: commit 2d681be471cf8aff8f296cb7713c39e9aa4fc2bb Author: Andreas Arnez Date: Wed Apr 27 15:52:16 2016 +0200 Avoid non-C++-enabled babeltrace versions tested with: libbabeltrace-devel-1.2.4-4.fc24.x86_64 libbabeltrace-devel-1.4.0-2.fc25.x86_64 it can no longer build due to: configure:16435: gcc -o conftest -m64 -g3 -pipe -Wall -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -fno-diagnostics-show-caret -Werror -static-libstdc++ -static-libgcc conftest.c -ldl -ldl -lncurses -lm -ldl -lbabeltrace -lbabeltrace-ctf >&5 conftest.c: In function 'main': conftest.c:208:7: error: 'pos' is a pointer; did you mean to use '->'? Have you tested that your line pos.type = BT_SEEK_BEGIN; with some libbabeltrace version or was that just a typo? OK for check-in? Thanks, Jan gdb/ChangeLog 2016-07-03 Jan Kratochvil * configure: Regenerate. * configure.ac (HAVE_LIBBABELTRACE): Fix pos variable dereference. diff --git a/gdb/configure.ac b/gdb/configure.ac index 920c228..5e2e938 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -2309,7 +2309,7 @@ else struct bt_ctf_event *event = NULL; const struct bt_definition *scope; - pos.type = BT_SEEK_BEGIN; + pos->type = BT_SEEK_BEGIN; bt_iter_set_pos (bt_ctf_get_iter (NULL), pos); scope = bt_ctf_get_top_level_scope (event, BT_STREAM_EVENT_HEADER);