From patchwork Wed Jun 8 11:40:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 12875 Received: (qmail 57688 invoked by alias); 8 Jun 2016 11:40:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57676 invoked by uid 89); 8 Jun 2016 11:40:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Jun 2016 11:40:22 +0000 Received: by mail-wm0-f50.google.com with SMTP id n184so177445389wmn.1 for ; Wed, 08 Jun 2016 04:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5dcurtSYs4x0qBtL9ZAyCk+PmFfyUV17hnDchnVpC80=; b=gyB46Tk4lKGDPZR0VA5RqscoSx4GlSN7yMWSLRXt97kGqgPAG8MigIJP4J0jaZzKD0 gp11BaGjsMGGt9eKA4KjDUpH0JbhIb3awFx1Kgy3PXDDQD+Z4S3ux+DF6Ki7woZhBV2A fsL2eF366nmXUwvyHuXlJl8uQ5Kb//il6+2HHzcpmhsN6zFj6QAv6eJHeFJv2FgIgl/X McTEihf3kHECfuy2V7HQqtVx+nWV3FqWUgvFWWD4wkVpPOOdsQocxJKLLnwVGM2Cqh1z z61+AbAEV0Imx+M9z6kCSyTMRWde/uBqBf6bnwWFbMoo9fNq7VCNFYcrjHGmsIW6+iWN ZBZw== X-Gm-Message-State: ALyK8tLFLGZrVurlVTqzBxQ3TNtsIRo9YY1y3WFupKcAXmpN8NK8ZMlSW/YP13Ur5FLn+A== X-Received: by 10.28.158.17 with SMTP id h17mr4802625wme.1.1465386019135; Wed, 08 Jun 2016 04:40:19 -0700 (PDT) Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id b207sm24490005wmb.0.2016.06.08.04.40.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jun 2016 04:40:18 -0700 (PDT) Date: Wed, 8 Jun 2016 12:40:17 +0100 From: Andrew Burgess To: Yao Qi Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb: Use UNSUPPORTED not FAIL for unsupported target features Message-ID: <20160608114017.GB26734@embecosm.com> References: <1465377976-21678-1-git-send-email-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes * Yao Qi [2016-06-08 11:25:29 +0100]: > On Wed, Jun 8, 2016 at 10:26 AM, Andrew Burgess > wrote: > > If a target does not support making function calls from GDB then we > > abandon the gdb.base/callfuncs.exp test file early. Currently we report > > a single FAIL before leaving the test file, this commit changes this to > > a single UNSUPPORTED. > > XFAIL is reported, like this, > > XFAIL: gdb.base/callfuncs.exp: This target can not call functions (PRMS 2416) > > I suspect you get FAIL because your target_triplet is foo-bar, so > *-*-* doesn't match. That's a good point. I've updated the patch to say XFAIL to UNSUPPORTED, as I still think that the change is sensible. New version below. Thanks, Andrew --- gdb: Use UNSUPPORTED not XFAIL for unsupported target features If a target does not support making function calls from GDB then we abandon the gdb.base/callfuncs.exp test file early. Currently we report a single XFAIL before leaving the test file, this commit changes this to a single UNSUPPORTED. gdb/testsuite/ChangeLog: * gdb.base/callfuncs.exp: Report unsupported rather than xfail for unsupported target features. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 98a798b..61ec0e7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-06-08 Andrew Burgess + + * gdb.base/callfuncs.exp: Report unsupported rather than xfail for + unsupported target features. + 2016-06-06 Simon Marchi * gdb.mi/mi-record-changed.exp: Adjust =record-started output diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp index fbe896c..1ec33d8 100644 --- a/gdb/testsuite/gdb.base/callfuncs.exp +++ b/gdb/testsuite/gdb.base/callfuncs.exp @@ -26,8 +26,7 @@ if [support_complex_tests] { # Some targets can't do function calls, so don't even bother with this # test. if [target_info exists gdb,cannot_call_functions] { - setup_xfail "*-*-*" 2416 - fail "This target can not call functions" + unsupported "This target can not call functions" continue }