From patchwork Mon Feb 1 22:10:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Seitz X-Patchwork-Id: 10695 Received: (qmail 27257 invoked by alias); 1 Feb 2016 22:10:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 27159 invoked by uid 89); 1 Feb 2016 22:10:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=dprintf X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 01 Feb 2016 22:10:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 2AFE970D72 for ; Mon, 1 Feb 2016 22:10:12 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u11MABI7014169 for ; Mon, 1 Feb 2016 17:10:11 -0500 Subject: [PATCH V2 4/4] Enable/update legacy linespecs in MI. From: Keith Seitz To: gdb-patches@sourceware.org Date: Mon, 01 Feb 2016 14:10:11 -0800 Message-ID: <20160201221011.1415.7460.stgit@valrhona.uglyboxes.com> In-Reply-To: <20160201220928.1415.59039.stgit@valrhona.uglyboxes.com> References: <20160201220928.1415.59039.stgit@valrhona.uglyboxes.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-IsSubscribed: yes MI is currently using string_to_event_location to enable the use of legacy linespecs, but using this function (until this patchset) had the (as yet unnoticed) side effect of allowing both MI and CLI representation for explicit locations. This patch simply changes MI to use the same legacy linespec functions that the python and guile interpreters use. This eliminates the CLI syntax for explicit locations (in MI). gdb/ChangeLog * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Use string_to_event_location_basic instead of string_to_event_location. --- gdb/mi/mi-cmd-break.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/mi/mi-cmd-break.c b/gdb/mi/mi-cmd-break.c index ef3ce29..3d40629 100644 --- a/gdb/mi/mi-cmd-break.c +++ b/gdb/mi/mi-cmd-break.c @@ -341,7 +341,7 @@ mi_cmd_break_insert_1 (int dprintf, char *command, char **argv, int argc) } else { - location = string_to_event_location (&address, current_language); + location = string_to_event_location_basic (&address, current_language); if (*address) { delete_event_location (location);