From patchwork Thu Dec 10 10:07:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 9957 Received: (qmail 33424 invoked by alias); 10 Dec 2015 10:08:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 32493 invoked by uid 89); 10 Dec 2015 10:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 10 Dec 2015 10:08:00 +0000 Received: by mail-wm0-f51.google.com with SMTP id c201so24854024wme.0 for ; Thu, 10 Dec 2015 02:08:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=jTVkiGD0dLKh2KvHonLE56wyxDeQRYoVKQt8hSGtqes=; b=XHoTG3vTSIJkiZp69pkYTqqKaTb8JHaDOVsjgvRndzfujHE/bYQ8lYQRjn/1Qnedjs i9kidrJfwYqFHPf2QunFcscsWz4e/VAm6oCQK7h/dZBTluJyLfEwD21fVK2HRJl80Fma Su9F9FGD1mPmSJ0SJQgRi/afqa6QlNMpwign9+ymtcPQ5l0iYCwbqaEtdW/TmSafZ6dV 0gP56tg6y/PkELj4XJFPojSR8mKbP6oPhfuASbQQ/DRsADZqXLJ0HdVG6o4T9YLX9XMF WIeS08itCr4X4s9YZoJyULuZQAKfyyJ2zeYnHu1BeLeK+jjC4gCR8K0ZZ4XkG7F0zIOD M/OA== X-Gm-Message-State: ALoCoQmBkQWuWeVuW0Urfl0PV0RY4ipq6uFeC3y6D7M5asew65plmtFi2sv/uYT9A+8S55ViXbMgtt2dYaaSWJp6N5Pc8SsdXg== X-Received: by 10.194.20.35 with SMTP id k3mr11731122wje.19.1449742077617; Thu, 10 Dec 2015 02:07:57 -0800 (PST) Received: from localhost (host86-138-95-213.range86-138.btcentralplus.com. [86.138.95.213]) by smtp.gmail.com with ESMTPSA id 200sm12163240wmn.11.2015.12.10.02.07.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2015 02:07:56 -0800 (PST) Date: Thu, 10 Dec 2015 10:07:55 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org, Eli Zaretskii Cc: Pedro Alves Subject: Re: [PATCH 7/7] gdb: Extend help text for 'list' command. Message-ID: <20151210100755.GA11555@embecosm.com> References: <5656FD51.10804@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5656FD51.10804@redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes * Pedro Alves [2015-11-26 12:38:41 +0000]: > On 11/25/2015 12:34 AM, Andrew Burgess wrote: > > Reference the 'listsize' setting in the help text for the 'list' command > > to help users find this setting. > > > > gdb/ChangeLog: > > > > * cli/cli-cmds.c (_initialize_cli_cmds): Extend help text for > > 'list' command. > > LGTM, but probably Eli should take a look. Eli, any feedback? Thanks, Andrew --- Reference the 'listsize' setting in the help text for the 'list' command to help users find this setting. gdb/ChangeLog: * cli/cli-cmds.c (_initialize_cli_cmds): Extend help text for 'list' command. --- gdb/ChangeLog | 5 +++++ gdb/cli/cli-cmds.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 278acb5..d9e91c2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2015-11-24 Andrew Burgess + * cli/cli-cmds.c (_initialize_cli_cmds): Extend help text for + 'list' command. + +2015-11-24 Andrew Burgess + * cli/cli-cmds.c (list_command): Add an error when trying to use '-' to scan read off the start of the source file. diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 5e7ef0a..0b3b091 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1901,7 +1901,11 @@ Lines can be specified in these ways:\n\ FILE:FUNCTION, to distinguish among like-named static functions.\n\ *ADDRESS, to list around the line containing that address.\n\ With two args if one is empty it stands for ten lines away from \ -the other arg.")); +the other arg.\n\ +\n\ +By default when a single location is given list displays ten lines,\n\ +this can be changed using \"set listsize\", and the current value\n\ +shown by using \"show listsize\".")); add_com_alias ("l", "list", class_files, 1);