minsyms.c: Scan backwards over all zero sized symbols
Commit Message
The comment for the code in question says:
/* If the minimal symbol has a zero size, save it
but keep scanning backwards looking for one with
a non-zero size. A zero size may mean that the
symbol isn't an object or function (e.g. a
label), or it may just mean that the size was not
specified. */
As written, the code in question will only scan past the first symbol
of zero size. My change fixes the implementation to match the
comment.
Having this correct is important when the compiler generates several
local labels that are left in place by the linker. (I've been told
that the linker should eliminate these symbols, but I know of one
architecture for which this is not happening.)
I've created a test case called asmlabel.c. It's pretty simple:
main (int argc, char **argv)
{
asm ("L0:");
v = 0;
asm ("L1:");
v = 1; /* set L1 breakpoint here */
asm ("L2:");
v = 2; /* set L2 breakpoint here */
return 0;
}
If breakpoints are placed on the lines indicated by the comments,
this is the behavior of GDB built without my patch:
(gdb) continue
Continuing.
Breakpoint 2, L1 () at asmlabel.c:26
26 v = 1; /* set L1 breakpoint here */
Note that L1 appears as the function instead of main. This is not
what we want to happen. With my patch in place, we see the desired
behavior instead:
(gdb) continue
Continuing.
Breakpoint 2, main (argc=1, argv=0x7fffffffdb88) at asmlabel.c:26
26 v = 1; /* set L1 breakpoint here */
gdb/ChangeLog:
* minsyms.c (lookup_minimal_symbol_by_pc_section_1): Scan backwards
over all zero-sized symbols.
gdb/testsuite/ChangeLog:
* gdb.base/asmlabel.exp: New test.
* gdb.base/asmlabel.c: New test case.
---
gdb/minsyms.c | 6 ++--
gdb/testsuite/gdb.base/asmlabel.c | 30 +++++++++++++++++
gdb/testsuite/gdb.base/asmlabel.exp | 64 +++++++++++++++++++++++++++++++++++++
3 files changed, 97 insertions(+), 3 deletions(-)
Comments
On 11/15/2015 05:02 AM, Kevin Buettner wrote:
> gdb/ChangeLog:
>
> * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Scan backwards
> over all zero-sized symbols.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/asmlabel.exp: New test.
> * gdb.base/asmlabel.c: New test case.
LGTM.
Thanks,
Pedro Alves
On Fri, 20 Nov 2015 16:30:23 +0000
Pedro Alves <palves@redhat.com> wrote:
> On 11/15/2015 05:02 AM, Kevin Buettner wrote:
>
> > gdb/ChangeLog:
> >
> > * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Scan backwards
> > over all zero-sized symbols.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.base/asmlabel.exp: New test.
> > * gdb.base/asmlabel.c: New test case.
>
> LGTM.
Thanks for looking it over. I've pushed it.
Kevin
@@ -697,10 +697,10 @@ lookup_minimal_symbol_by_pc_section_1 (CORE_ADDR pc_in,
symbol isn't an object or function (e.g. a
label), or it may just mean that the size was not
specified. */
- if (MSYMBOL_SIZE (&msymbol[hi]) == 0
- && best_zero_sized == -1)
+ if (MSYMBOL_SIZE (&msymbol[hi]) == 0)
{
- best_zero_sized = hi;
+ if (best_zero_sized == -1)
+ best_zero_sized = hi;
hi--;
continue;
}
new file mode 100644
@@ -0,0 +1,30 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2015 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+static volatile int v = -1;
+
+int
+main (int argc, char **argv)
+{
+ asm ("L0:");
+ v = 0;
+ asm ("L1:");
+ v = 1; /* set L1 breakpoint here */
+ asm ("L2:");
+ v = 2; /* set L2 breakpoint here */
+ return 0;
+}
new file mode 100644
@@ -0,0 +1,64 @@
+# Copyright (C) 2015 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Test to see that GDB reports the correct function name when stopping
+# in a function with several assembly-defined labels; see the test
+# case asmlabel.c.
+#
+# When setting and then continuing to a breakpoint at either location
+# L1 or L2 - again, see the code - we want to make sure that GDB
+# correctly reports that it's in main, like this:
+#
+# Breakpoint 2, main (argc=1, argv=0x7fffffffe408) at asmlabel.c:26
+# 26 v = 1; /* set L1 breakpoint here */
+#
+# This test case was written to test for a bug in which GDB printed
+# the following instead:
+#
+# Breakpoint 2, L1 () at asmlabel.c:26
+# 26 v = 1; /* set L1 breakpoint here */
+#
+
+standard_testfile
+
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
+ return -1
+}
+
+if ![runto_main] {
+ fail "Can't run to main"
+ return 0
+}
+
+set L1_bploc [gdb_get_line_number "set L1 breakpoint here" $srcfile]
+set L2_bploc [gdb_get_line_number "set L2 breakpoint here" $srcfile]
+
+gdb_test "break $srcfile:$L1_bploc" \
+ "Breakpoint.*at.* file .*$srcfile, line $L1_bploc\\." \
+ "breakpoint at L1"
+
+gdb_test "break $L2_bploc" \
+ "Breakpoint.*at.* file .*$srcfile, line $L2_bploc\\." \
+ "breakpoint at L2"
+
+gdb_test "continue" \
+ "Continuing.*Breakpoint \[0-9\]+, main .* at .*$srcfile:$L1_bploc.*" \
+ "continue to L1"
+
+gdb_test "continue" \
+ "Continuing.*Breakpoint \[0-9\]+, main .* at .*$srcfile:$L2_bploc.*" \
+ "continue to L2"
+
+gdb_test "print v" "= 1" "check value of v at L2"