From patchwork Wed Aug 5 23:29:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Seitz X-Patchwork-Id: 8028 Received: (qmail 59752 invoked by alias); 5 Aug 2015 23:29:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 59739 invoked by uid 89); 5 Aug 2015 23:29:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 05 Aug 2015 23:29:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 1B45AF6523 for ; Wed, 5 Aug 2015 23:29:11 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t75NTA5M029133 for ; Wed, 5 Aug 2015 19:29:10 -0400 Subject: [PATCH v6 1/9] Explicit locations: rename "address string"/"addr_string" to "location" From: Keith Seitz To: gdb-patches@sourceware.org Date: Wed, 05 Aug 2015 16:29:10 -0700 Message-ID: <20150805232857.21646.59261.stgit@valrhona.uglyboxes.com> In-Reply-To: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-IsSubscribed: yes *This patch has previously been approved.* This patch renames all occurrances of "addr_string" and "address string" in the breakpoint/linespec APIs. This will emphasize the change from address strings used in setting breakpoints (et al) to the new locations-based API introduced in subsequent patches. gdb/ChangeLog: * breakpoint.h (struct breakpoint_ops) : Renamed to create_sals_from_location. : Renamed to decode_location. Update all callers. * breakpoint.c (create_sals_from_address_default): Renamed to ... (create_sals_from_location_default): ... this. (addr_string_to_sals): Renamed to ... (location_to_sals): ... this. (decode_linespec_default): Renamed to ... (decode_location_default): ... this. (base_breakpoint_create_sals_from_address): Renamed to ... (base_breakpoint_create_sals_from_location): ... this. (bkpt_create_sals_from_address): Renamed to ... (bkpt_create_sals_from_location): ... this. (bkpt_decode_linespec): Renamed to ... (bkpt_decode_location): ... this. (bkpt_probe_create_sals_from_address): Renamed to ... (bkpt_probe_create_sals_from_location): ... this. (tracepoint_create_sals_from_address): Renamed to ... (tracepoint_create_sals_from_location): ... this. (tracepoint_decode_linespec): Renamed to ... (tracepoint_decode_location): ... this. (tracepoint_probe_create_sals_from_address): Renamed to ... (tracepoint_probe_create_sals_from_location): ... this. (tracepoint_probe_decode_linespec): Renamed to ... (tracepoint_probe_decode_location): ... this. (strace_marker_create_sals_from_address): Renamed to ... (strace_marker_create_sals_from_location): ... this. (decode_linespec_default): Renamed to ... (decode_location_default): ... this. --- gdb/break-catch-throw.c | 2 - gdb/breakpoint.c | 116 ++++++++++++++++++++++++----------------------- gdb/breakpoint.h | 14 +++--- 3 files changed, 66 insertions(+), 66 deletions(-) diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c index f5616c8..927176f 100644 --- a/gdb/break-catch-throw.c +++ b/gdb/break-catch-throw.c @@ -228,7 +228,7 @@ re_set_exception_catchpoint (struct breakpoint *self) { char *spec = ASTRDUP (exception_functions[kind].function); - self->ops->decode_linespec (self, &spec, &sals); + self->ops->decode_location (self, &spec, &sals); } CATCH (ex, RETURN_MASK_ERROR) { diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 125b22f..c51ba22 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -108,10 +108,10 @@ static int breakpoint_re_set_one (void *); static void breakpoint_re_set_default (struct breakpoint *); -static void create_sals_from_address_default (char **, - struct linespec_result *, - enum bptype, char *, - char **); +static void create_sals_from_location_default (char **, + struct linespec_result *, + enum bptype, char *, + char **); static void create_breakpoints_sal_default (struct gdbarch *, struct linespec_result *, @@ -121,7 +121,7 @@ static void create_breakpoints_sal_default (struct gdbarch *, const struct breakpoint_ops *, int, int, int, unsigned); -static void decode_linespec_default (struct breakpoint *, char **, +static void decode_location_default (struct breakpoint *, char **, struct symtabs_and_lines *); static void clear_command (char *, int); @@ -9600,8 +9600,8 @@ create_breakpoint (struct gdbarch *gdbarch, TRY { - ops->create_sals_from_address (&arg, &canonical, type_wanted, - addr_start, ©_arg); + ops->create_sals_from_location (&arg, &canonical, type_wanted, + addr_start, ©_arg); } CATCH (e, RETURN_MASK_ERROR) { @@ -12702,11 +12702,11 @@ base_breakpoint_print_recreate (struct breakpoint *b, struct ui_file *fp) } static void -base_breakpoint_create_sals_from_address (char **arg, - struct linespec_result *canonical, - enum bptype type_wanted, - char *addr_start, - char **copy_arg) +base_breakpoint_create_sals_from_location (char **arg, + struct linespec_result *canonical, + enum bptype type_wanted, + char *addr_start, + char **copy_arg) { internal_error_pure_virtual_called (); } @@ -12728,7 +12728,7 @@ base_breakpoint_create_breakpoints_sal (struct gdbarch *gdbarch, } static void -base_breakpoint_decode_linespec (struct breakpoint *b, char **s, +base_breakpoint_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { internal_error_pure_virtual_called (); @@ -12766,9 +12766,9 @@ struct breakpoint_ops base_breakpoint_ops = base_breakpoint_print_one_detail, base_breakpoint_print_mention, base_breakpoint_print_recreate, - base_breakpoint_create_sals_from_address, + base_breakpoint_create_sals_from_location, base_breakpoint_create_breakpoints_sal, - base_breakpoint_decode_linespec, + base_breakpoint_decode_location, base_breakpoint_explains_signal, base_breakpoint_after_condition_true, }; @@ -12938,12 +12938,12 @@ bkpt_print_recreate (struct breakpoint *tp, struct ui_file *fp) } static void -bkpt_create_sals_from_address (char **arg, +bkpt_create_sals_from_location (char **arg, struct linespec_result *canonical, enum bptype type_wanted, char *addr_start, char **copy_arg) { - create_sals_from_address_default (arg, canonical, type_wanted, + create_sals_from_location_default (arg, canonical, type_wanted, addr_start, copy_arg); } @@ -12969,10 +12969,10 @@ bkpt_create_breakpoints_sal (struct gdbarch *gdbarch, } static void -bkpt_decode_linespec (struct breakpoint *b, char **s, +bkpt_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { - decode_linespec_default (b, s, sals); + decode_location_default (b, s, sals); } /* Virtual table for internal breakpoints. */ @@ -13172,10 +13172,10 @@ bkpt_probe_remove_location (struct bp_location *bl) } static void -bkpt_probe_create_sals_from_address (char **arg, - struct linespec_result *canonical, - enum bptype type_wanted, - char *addr_start, char **copy_arg) +bkpt_probe_create_sals_from_location (char **arg, + struct linespec_result *canonical, + enum bptype type_wanted, + char *addr_start, char **copy_arg) { struct linespec_sals lsal; @@ -13188,7 +13188,7 @@ bkpt_probe_create_sals_from_address (char **arg, } static void -bkpt_probe_decode_linespec (struct breakpoint *b, char **s, +bkpt_probe_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { *sals = parse_probes (s, NULL); @@ -13281,12 +13281,12 @@ tracepoint_print_recreate (struct breakpoint *self, struct ui_file *fp) } static void -tracepoint_create_sals_from_address (char **arg, +tracepoint_create_sals_from_location (char **arg, struct linespec_result *canonical, enum bptype type_wanted, char *addr_start, char **copy_arg) { - create_sals_from_address_default (arg, canonical, type_wanted, + create_sals_from_location_default (arg, canonical, type_wanted, addr_start, copy_arg); } @@ -13312,10 +13312,10 @@ tracepoint_create_breakpoints_sal (struct gdbarch *gdbarch, } static void -tracepoint_decode_linespec (struct breakpoint *b, char **s, +tracepoint_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { - decode_linespec_default (b, s, sals); + decode_location_default (b, s, sals); } struct breakpoint_ops tracepoint_breakpoint_ops; @@ -13324,22 +13324,22 @@ struct breakpoint_ops tracepoint_breakpoint_ops; static probe. */ static void -tracepoint_probe_create_sals_from_address (char **arg, - struct linespec_result *canonical, - enum bptype type_wanted, - char *addr_start, char **copy_arg) +tracepoint_probe_create_sals_from_location (char **arg, + struct linespec_result *canonical, + enum bptype type_wanted, + char *addr_start, char **copy_arg) { /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_address (arg, canonical, type_wanted, - addr_start, copy_arg); + bkpt_probe_create_sals_from_location (arg, canonical, type_wanted, + addr_start, copy_arg); } static void -tracepoint_probe_decode_linespec (struct breakpoint *b, char **s, +tracepoint_probe_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { /* We use the same method for breakpoint on probes. */ - bkpt_probe_decode_linespec (b, s, sals); + bkpt_probe_decode_location (b, s, sals); } static struct breakpoint_ops tracepoint_probe_breakpoint_ops; @@ -13425,10 +13425,10 @@ dprintf_after_condition_true (struct bpstats *bs) markers (`-m'). */ static void -strace_marker_create_sals_from_address (char **arg, - struct linespec_result *canonical, - enum bptype type_wanted, - char *addr_start, char **copy_arg) +strace_marker_create_sals_from_location (char **arg, + struct linespec_result *canonical, + enum bptype type_wanted, + char *addr_start, char **copy_arg) { struct linespec_sals lsal; @@ -13501,7 +13501,7 @@ strace_marker_create_breakpoints_sal (struct gdbarch *gdbarch, } static void -strace_marker_decode_linespec (struct breakpoint *b, char **s, +strace_marker_decode_location (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { struct tracepoint *tp = (struct tracepoint *) b; @@ -14046,7 +14046,7 @@ update_breakpoint_locations (struct breakpoint *b, On return, FOUND will be 1 if any SaL was found, zero otherwise. */ static struct symtabs_and_lines -addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found) +location_to_sals (struct breakpoint *b, char *addr_string, int *found) { char *s; struct symtabs_and_lines sals = {0}; @@ -14057,7 +14057,7 @@ addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found) TRY { - b->ops->decode_linespec (b, &s, &sals); + b->ops->decode_location (b, &s, &sals); } CATCH (e, RETURN_MASK_ERROR) { @@ -14139,7 +14139,7 @@ breakpoint_re_set_default (struct breakpoint *b) struct symtabs_and_lines expanded = {0}; struct symtabs_and_lines expanded_end = {0}; - sals = addr_string_to_sals (b, b->addr_string, &found); + sals = location_to_sals (b, b->addr_string, &found); if (found) { make_cleanup (xfree, sals.sals); @@ -14148,7 +14148,7 @@ breakpoint_re_set_default (struct breakpoint *b) if (b->addr_string_range_end) { - sals_end = addr_string_to_sals (b, b->addr_string_range_end, &found); + sals_end = location_to_sals (b, b->addr_string_range_end, &found); if (found) { make_cleanup (xfree, sals_end.sals); @@ -14163,7 +14163,7 @@ breakpoint_re_set_default (struct breakpoint *b) calls parse_breakpoint_sals. Return 1 for success, zero for failure. */ static void -create_sals_from_address_default (char **arg, +create_sals_from_location_default (char **arg, struct linespec_result *canonical, enum bptype type_wanted, char *addr_start, char **copy_arg) @@ -14196,10 +14196,10 @@ create_breakpoints_sal_default (struct gdbarch *gdbarch, } /* Decode the line represented by S by calling decode_line_full. This is the - default function for the `decode_linespec' method of breakpoint_ops. */ + default function for the `decode_location' method of breakpoint_ops. */ static void -decode_linespec_default (struct breakpoint *b, char **s, +decode_location_default (struct breakpoint *b, char **s, struct symtabs_and_lines *sals) { struct linespec_result canonical; @@ -15579,9 +15579,9 @@ initialize_breakpoint_ops (void) ops->insert_location = bkpt_insert_location; ops->remove_location = bkpt_remove_location; ops->breakpoint_hit = bkpt_breakpoint_hit; - ops->create_sals_from_address = bkpt_create_sals_from_address; + ops->create_sals_from_location = bkpt_create_sals_from_location; ops->create_breakpoints_sal = bkpt_create_breakpoints_sal; - ops->decode_linespec = bkpt_decode_linespec; + ops->decode_location = bkpt_decode_location; /* The breakpoint_ops structure to be used in regular breakpoints. */ ops = &bkpt_breakpoint_ops; @@ -15629,8 +15629,8 @@ initialize_breakpoint_ops (void) *ops = bkpt_breakpoint_ops; ops->insert_location = bkpt_probe_insert_location; ops->remove_location = bkpt_probe_remove_location; - ops->create_sals_from_address = bkpt_probe_create_sals_from_address; - ops->decode_linespec = bkpt_probe_decode_linespec; + ops->create_sals_from_location = bkpt_probe_create_sals_from_location; + ops->decode_location = bkpt_probe_decode_location; /* Watchpoints. */ ops = &watchpoint_breakpoint_ops; @@ -15668,22 +15668,22 @@ initialize_breakpoint_ops (void) ops->print_one_detail = tracepoint_print_one_detail; ops->print_mention = tracepoint_print_mention; ops->print_recreate = tracepoint_print_recreate; - ops->create_sals_from_address = tracepoint_create_sals_from_address; + ops->create_sals_from_location = tracepoint_create_sals_from_location; ops->create_breakpoints_sal = tracepoint_create_breakpoints_sal; - ops->decode_linespec = tracepoint_decode_linespec; + ops->decode_location = tracepoint_decode_location; /* Probe tracepoints. */ ops = &tracepoint_probe_breakpoint_ops; *ops = tracepoint_breakpoint_ops; - ops->create_sals_from_address = tracepoint_probe_create_sals_from_address; - ops->decode_linespec = tracepoint_probe_decode_linespec; + ops->create_sals_from_location = tracepoint_probe_create_sals_from_location; + ops->decode_location = tracepoint_probe_decode_location; /* Static tracepoints with marker (`-m'). */ ops = &strace_marker_breakpoint_ops; *ops = tracepoint_breakpoint_ops; - ops->create_sals_from_address = strace_marker_create_sals_from_address; + ops->create_sals_from_location = strace_marker_create_sals_from_location; ops->create_breakpoints_sal = strace_marker_create_breakpoints_sal; - ops->decode_linespec = strace_marker_decode_linespec; + ops->decode_location = strace_marker_decode_location; /* Fork catchpoints. */ ops = &catch_fork_breakpoint_ops; diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index 94d9385..4406260 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -574,14 +574,14 @@ struct breakpoint_ops /* Print to FP the CLI command that recreates this breakpoint. */ void (*print_recreate) (struct breakpoint *, struct ui_file *fp); - /* Create SALs from address string, storing the result in linespec_result. + /* Create SALs from location, storing the result in linespec_result. For an explanation about the arguments, see the function - `create_sals_from_address_default'. + `create_sals_from_location_default'. This function is called inside `create_breakpoint'. */ - void (*create_sals_from_address) (char **, struct linespec_result *, - enum bptype, char *, char **); + void (*create_sals_from_location) (char **, struct linespec_result *, + enum bptype, char *, char **); /* This method will be responsible for creating a breakpoint given its SALs. Usually, it just calls `create_breakpoints_sal' (for ordinary @@ -597,12 +597,12 @@ struct breakpoint_ops int, const struct breakpoint_ops *, int, int, int, unsigned); - /* Given the address string (second parameter), this method decodes it + /* Given the location (second parameter), this method decodes it and provides the SAL locations related to it. For ordinary breakpoints, it calls `decode_line_full'. - This function is called inside `addr_string_to_sals'. */ - void (*decode_linespec) (struct breakpoint *, char **, + This function is called inside `location_to_sals'. */ + void (*decode_location) (struct breakpoint *, char **, struct symtabs_and_lines *); /* Return true if this breakpoint explains a signal. See