From patchwork Thu Jul 23 00:39:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Buettner X-Patchwork-Id: 7800 Received: (qmail 73101 invoked by alias); 23 Jul 2015 01:36:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73090 invoked by uid 89); 23 Jul 2015 01:36:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 01:36:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 70E98428937 for ; Thu, 23 Jul 2015 01:36:38 +0000 (UTC) Received: from pinnacle.lan (ovpn-113-75.phx2.redhat.com [10.3.113.75]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6N0dxX6009100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO) for ; Wed, 22 Jul 2015 20:39:59 -0400 Date: Wed, 22 Jul 2015 17:39:57 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH] Add proper handling for non-local references in nested functions Message-ID: <20150722173957.7ed51f18@pinnacle.lan> In-Reply-To: <55AF5F7E.5000600@adacore.com> References: <54F47563.4050103@adacore.com> <54FF0D05.70907@redhat.com> <550C1170.9070208@adacore.com> <55685B60.3000004@redhat.com> <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> MIME-Version: 1.0 X-IsSubscribed: yes On Wed, 22 Jul 2015 11:16:46 +0200 Pierre-Marie de Rodat wrote: > Here it is! > I just > rebased my work on non-local references on top of this cleanup and > performed the changes you asked me to do. Just a question: [...] > Regtested again on x86_64-linux: no regression. Ok to push? Thank you! Hi Pierre-Marie, I had to make the following change in order to obtain a clean build using your patches: diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index e20aead..d6e3d55 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -11457,7 +11457,7 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) newobj = pop_context (); /* Make a block for the local symbols within. */ - block = finish_block (newobj->name, &newobj->static_link, + block = finish_block (newobj->name, newobj->static_link, &local_symbols, newobj->old_blocks, lowpc, highpc);