From patchwork Sun Jun 7 20:04:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 7059 Received: (qmail 103900 invoked by alias); 7 Jun 2015 20:04:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103833 invoked by uid 89); 7 Jun 2015 20:04:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 07 Jun 2015 20:04:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6DF9919F96E; Sun, 7 Jun 2015 20:04:49 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t57K4mCY014072; Sun, 7 Jun 2015 16:04:48 -0400 Subject: [PATCH v6 03/10] Code cleanup: Rename enum -> enum filterflags From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Aleksandar Ristovski Date: Sun, 07 Jun 2015 22:04:47 +0200 Message-ID: <20150607200447.8918.31723.stgit@host1.jankratochvil.net> In-Reply-To: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-IsSubscribed: yes Hi Sergio, this is an unrelated cleanup, bit mask ints are better to make enums as GDB already has support to automatically decode them: before this patch: (gdb) p filterflags $1 = 51 (gdb) p/x filterflags $2 = 0x33 after this patch: (gdb) p filterflags $1 = (COREFILTER_ANON_PRIVATE | COREFILTER_ANON_SHARED | COREFILTER_ELF_HEADERS | COREFILTER_HUGETLB_PRIVATE) New patch, not yet reviewed before. Jan gdb/ChangeLog 2015-06-07 Jan Kratochvil * linux-tdep.c (enum filterflags): Make it from anonymous enum. (dump_mapping_p): Use it for parameter filterflags. (linux_find_memory_regions_full): Use it for variable filterflags. --- gdb/linux-tdep.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 8ce2f34..b0981f5 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -46,7 +46,7 @@ Documentation/filesystems/proc.txt, inside the Linux kernel tree. */ -enum +enum filterflags { COREFILTER_ANON_PRIVATE = 1 << 0, COREFILTER_ANON_SHARED = 1 << 1, @@ -598,7 +598,7 @@ mapping_is_anonymous_p (const char *filename) This should work OK enough, however. */ static int -dump_mapping_p (unsigned int filterflags, const struct smaps_vmflags *v, +dump_mapping_p (enum filterflags filterflags, const struct smaps_vmflags *v, int maybe_private_p, int mapping_anon_p, int mapping_file_p, const char *filename) { @@ -1119,10 +1119,10 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch, /* Default dump behavior of coredump_filter (0x33), according to Documentation/filesystems/proc.txt from the Linux kernel tree. */ - unsigned int filterflags = (COREFILTER_ANON_PRIVATE - | COREFILTER_ANON_SHARED - | COREFILTER_ELF_HEADERS - | COREFILTER_HUGETLB_PRIVATE); + enum filterflags filterflags = (COREFILTER_ANON_PRIVATE + | COREFILTER_ANON_SHARED + | COREFILTER_ELF_HEADERS + | COREFILTER_HUGETLB_PRIVATE); /* We need to know the real target PID to access /proc. */ if (current_inferior ()->fake_pid_p)