From patchwork Sat May 16 13:09:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 6762 Received: (qmail 69638 invoked by alias); 16 May 2015 13:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69629 invoked by uid 89); 16 May 2015 13:09:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, KAM_STOCKGEN, SPF_HELO_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 16 May 2015 13:09:44 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8EA218EA21 for ; Sat, 16 May 2015 13:09:43 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4GD9ds3027265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 16 May 2015 09:09:41 -0400 Date: Sat, 16 May 2015 15:09:38 +0200 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Phil Muldoon Subject: [patch] compile: gdb_stdout -> gdb_stdlog [compile: Add one debug message] Message-ID: <20150516130938.GA16744@host1.jankratochvil.net> References: <20150513201615.4051.5261.stgit@host1.jankratochvil.net> <20150513201625.4051.2512.stgit@host1.jankratochvil.net> <5556238B.3050808@redhat.com> <20150516121946.GA22586@host1.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150516121946.GA22586@host1.jankratochvil.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Sat, 16 May 2015 14:19:46 +0200, Jan Kratochvil wrote: > OK but gdb/compile/ is using now only gdb_stdout; the error above is due to > a copy-paste. So I will send a follow-up patch to change all the other > gdb/compile/ gdb_stdout strings to gdb_stdlog. OK for check-in? Jan gdb/ChangeLog 2015-05-16 Jan Kratochvil * compile/compile-c-symbols.c (convert_symbol_sym, gcc_convert_symbol) (gcc_symbol_address): Change gdb_stdout to gdb_stdlog. * compile/compile-object-load.c (setup_sections, compile_object_load): Likewise. * compile/compile.c (compile_to_object): Likewise. diff --git a/gdb/compile/compile-c-symbols.c b/gdb/compile/compile-c-symbols.c index 15efeff..455114c 100644 --- a/gdb/compile/compile-c-symbols.c +++ b/gdb/compile/compile-c-symbols.c @@ -338,7 +338,7 @@ convert_symbol_sym (struct compile_c_instance *context, const char *identifier, && block_found != block_static_block (block_found)) { if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_convert_symbol \"%s\": global symbol\n", identifier); convert_one_symbol (context, global_sym, 1, 0); @@ -346,7 +346,7 @@ convert_symbol_sym (struct compile_c_instance *context, const char *identifier, } if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_convert_symbol \"%s\": local symbol\n", identifier); convert_one_symbol (context, sym, 0, is_local_symbol); @@ -473,7 +473,7 @@ gcc_convert_symbol (void *datum, END_CATCH if (compile_debug && !found) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_convert_symbol \"%s\": lookup_symbol failed\n", identifier); return; @@ -500,7 +500,7 @@ gcc_symbol_address (void *datum, struct gcc_c_context *gcc_context, if (sym != NULL && SYMBOL_CLASS (sym) == LOC_BLOCK) { if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_symbol_address \"%s\": full symbol\n", identifier); result = BLOCK_START (SYMBOL_BLOCK_VALUE (sym)); @@ -516,7 +516,7 @@ gcc_symbol_address (void *datum, struct gcc_c_context *gcc_context, if (msym.minsym != NULL) { if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_symbol_address \"%s\": minimal " "symbol\n", identifier); @@ -535,7 +535,7 @@ gcc_symbol_address (void *datum, struct gcc_c_context *gcc_context, END_CATCH if (compile_debug && !found) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "gcc_symbol_address \"%s\": failed\n", identifier); return result; diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index 3273e47..31f4bde 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -132,7 +132,7 @@ setup_sections (bfd *abfd, asection *sect, void *data_voidp) prot |= GDB_MMAP_PROT_EXEC; if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "module \"%s\" section \"%s\" size %s prot %u\n", bfd_get_filename (abfd), bfd_get_section_name (abfd, sect), @@ -155,7 +155,7 @@ setup_sections (bfd *abfd, asection *sect, void *data_voidp) data->last_prot); munmap_list_add (data->munmap_list_headp, addr, data->last_size); if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "allocated %s bytes at %s prot %u\n", paddress (target_gdbarch (), data->last_size), paddress (target_gdbarch (), addr), @@ -728,7 +728,7 @@ compile_object_load (const char *object_file, const char *source_file, if (sym->flags != 0) continue; if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "lookup undefined ELF symbol \"%s\"\n", sym->name); sym->flags = BSF_GLOBAL; @@ -773,7 +773,7 @@ compile_object_load (const char *object_file, const char *source_file, gdb_assert (regs_addr != 0); munmap_list_add (&munmap_list_head, regs_addr, TYPE_LENGTH (regs_type)); if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "allocated %s bytes at %s for registers\n", paddress (target_gdbarch (), TYPE_LENGTH (regs_type)), @@ -799,7 +799,7 @@ compile_object_load (const char *object_file, const char *source_file, munmap_list_add (&munmap_list_head, out_value_addr, TYPE_LENGTH (out_value_type)); if (compile_debug) - fprintf_unfiltered (gdb_stdout, + fprintf_unfiltered (gdb_stdlog, "allocated %s bytes at %s for printed value\n", paddress (target_gdbarch (), TYPE_LENGTH (out_value_type)), diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c index fbecf8c..499c530 100644 --- a/gdb/compile/compile.c +++ b/gdb/compile/compile.c @@ -528,7 +528,7 @@ compile_to_object (struct command_line *cmd, const char *cmd_string, expr_block, expr_pc); make_cleanup (xfree, code); if (compile_debug) - fprintf_unfiltered (gdb_stdout, "debug output:\n\n%s", code); + fprintf_unfiltered (gdb_stdlog, "debug output:\n\n%s", code); os_rx = osabi_triplet_regexp (gdbarch_osabi (gdbarch)); arch_rx = gdbarch_gnu_triplet_regexp (gdbarch); @@ -553,9 +553,9 @@ compile_to_object (struct command_line *cmd, const char *cmd_string, { int argi; - fprintf_unfiltered (gdb_stdout, "Passing %d compiler options:\n", argc); + fprintf_unfiltered (gdb_stdlog, "Passing %d compiler options:\n", argc); for (argi = 0; argi < argc; argi++) - fprintf_unfiltered (gdb_stdout, "Compiler option %d: <%s>\n", + fprintf_unfiltered (gdb_stdlog, "Compiler option %d: <%s>\n", argi, argv[argi]); } @@ -572,7 +572,7 @@ compile_to_object (struct command_line *cmd, const char *cmd_string, fclose (src); if (compile_debug) - fprintf_unfiltered (gdb_stdout, "source file produced: %s\n\n", + fprintf_unfiltered (gdb_stdlog, "source file produced: %s\n\n", source_file); /* Call the compiler and start the compilation process. */ @@ -583,7 +583,7 @@ compile_to_object (struct command_line *cmd, const char *cmd_string, error (_("Compilation failed.")); if (compile_debug) - fprintf_unfiltered (gdb_stdout, "object file produced: %s\n\n", + fprintf_unfiltered (gdb_stdlog, "object file produced: %s\n\n", object_file); discard_cleanups (inner_cleanup);