From patchwork Thu Apr 23 21:34:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 6413 Received: (qmail 36029 invoked by alias); 23 Apr 2015 21:34:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 36015 invoked by uid 89); 23 Apr 2015 21:34:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wg0-f52.google.com Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Apr 2015 21:34:19 +0000 Received: by wgyo15 with SMTP id o15so32021664wgy.2 for ; Thu, 23 Apr 2015 14:34:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=7hZq0Bz207z0ap+AnS0CfUr1BsC0dswc497p/7/XPlw=; b=YQTCXq+T5D3qQEk41U7WJfTbInIl3vhpqQfU2EqpsoYFseezjuteyWt2+7IE1t+Yyr ZWBAMh8TptJGUYLKN37BRKjyQaNa6Tx42LzQS2X/7BylE6oEtBKYxEkxqSqH/7zrpmA6 D4/fvZxc6jaOXRmDPj04Su3dBS/mZtX13xoaWln3nxUXnrlTXo3umPZitx71el7McWdj 3jS2Js2QtBV95NyxL5YphpXKD9Gs+QlOaXgwprf/Ah1TLgd4lPVbdZuGW0YuSoomGnUL WdZWKy9caf+cWJSJNhOHNTT/MWgQW7YZowvDvI4R74XKCTOACTAMcCz39lLnLaov0Gr+ kpYQ== X-Gm-Message-State: ALoCoQlX3jUXsWAIrBIumejuOLWyUlUcfQYYc0hbI4KQMNAltIpe2fWxdGkfROwX2Gu+FA9KwX1z X-Received: by 10.194.129.133 with SMTP id nw5mr4677954wjb.63.1429824856289; Thu, 23 Apr 2015 14:34:16 -0700 (PDT) Received: from localhost (host86-133-100-115.range86-133.btcentralplus.com. [86.133.100.115]) by mx.google.com with ESMTPSA id xy2sm13981778wjc.14.2015.04.23.14.34.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 14:34:15 -0700 (PDT) Date: Thu, 23 Apr 2015 22:34:14 +0100 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format. Message-ID: <20150423213414.GI2422@embecosm.com> References: <553821B2.1080704@redhat.com> <20150422230431.GF2422@embecosm.com> <5538CC57.6030305@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5538CC57.6030305@redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes * Pedro Alves [2015-04-23 11:41:27 +0100]: > Thanks, this looks good to me with the missing _() Eli noticed, and ... The _() I wised was a result of copy 'n' pasting some code that already lacks internationalisation support. This patch fixes those strings in the immediate area of where I was working. This applies on top of the verilog dump patch, and I'll push it as obvious once that patch is merged. Thanks, Andrew --- Spotted a few strings that were missing internationalization support. gdb/ChangeLog: * cli/cli-dump.c (srec_dump_command): Add internationalization mark ups. (ihex_dump_command): Likewise. (tekhex_dump_command): Likewise. (binary_dump_command): Likewise. (binary_append_command): Likewise. --- gdb/ChangeLog | 9 +++++++++ gdb/cli/cli-dump.c | 10 +++++----- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 410f1b7..08912fd 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,12 @@ +2015-04-23 Andrew Burgess + + * cli/cli-dump.c (srec_dump_command): Add internationalization + mark ups. + (ihex_dump_command): Likewise. + (tekhex_dump_command): Likewise. + (binary_dump_command): Likewise. + (binary_append_command): Likewise. + 2015-04-22 Andrew Burgess * cli/cli-dump.c (verilog_cmdlist): New variable. diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c index 08ff941..2449dc5 100644 --- a/gdb/cli/cli-dump.c +++ b/gdb/cli/cli-dump.c @@ -637,14 +637,14 @@ restore_command (char *args_in, int from_tty) static void srec_dump_command (char *cmd, int from_tty) { - printf_unfiltered ("\"dump srec\" must be followed by a subcommand.\n"); + printf_unfiltered (_("\"dump srec\" must be followed by a subcommand.\n")); help_list (srec_cmdlist, "dump srec ", all_commands, gdb_stdout); } static void ihex_dump_command (char *cmd, int from_tty) { - printf_unfiltered ("\"dump ihex\" must be followed by a subcommand.\n"); + printf_unfiltered (_("\"dump ihex\" must be followed by a subcommand.\n")); help_list (ihex_cmdlist, "dump ihex ", all_commands, gdb_stdout); } @@ -658,21 +658,21 @@ verilog_dump_command (char *cmd, int from_tty) static void tekhex_dump_command (char *cmd, int from_tty) { - printf_unfiltered ("\"dump tekhex\" must be followed by a subcommand.\n"); + printf_unfiltered (_("\"dump tekhex\" must be followed by a subcommand.\n")); help_list (tekhex_cmdlist, "dump tekhex ", all_commands, gdb_stdout); } static void binary_dump_command (char *cmd, int from_tty) { - printf_unfiltered ("\"dump binary\" must be followed by a subcommand.\n"); + printf_unfiltered (_("\"dump binary\" must be followed by a subcommand.\n")); help_list (binary_dump_cmdlist, "dump binary ", all_commands, gdb_stdout); } static void binary_append_command (char *cmd, int from_tty) { - printf_unfiltered ("\"append binary\" must be followed by a subcommand.\n"); + printf_unfiltered (_("\"append binary\" must be followed by a subcommand.\n")); help_list (binary_append_cmdlist, "append binary ", all_commands, gdb_stdout); }