From patchwork Wed Apr 15 02:16:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 6221 Received: (qmail 119638 invoked by alias); 15 Apr 2015 02:17:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119623 invoked by uid 89); 15 Apr 2015 02:17:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: bastet.se.axis.com Received: from bastet.se.axis.com (HELO bastet.se.axis.com) (195.60.68.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Apr 2015 02:16:58 +0000 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 9C57E1815D; Wed, 15 Apr 2015 04:16:55 +0200 (CEST) Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id rIrNFH7vOYrD; Wed, 15 Apr 2015 04:16:54 +0200 (CEST) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by bastet.se.axis.com (Postfix) with ESMTP id A445F1813E; Wed, 15 Apr 2015 04:16:54 +0200 (CEST) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 8DA1E12D6; Wed, 15 Apr 2015 04:16:54 +0200 (CEST) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by boulder.se.axis.com (Postfix) with ESMTP id 81A59F11; Wed, 15 Apr 2015 04:16:54 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 7EDB33E049; Wed, 15 Apr 2015 04:16:54 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id t3F2GsBc012810; Wed, 15 Apr 2015 04:16:54 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id t3F2GroJ012806; Wed, 15 Apr 2015 04:16:53 +0200 Date: Wed, 15 Apr 2015 04:16:53 +0200 Message-Id: <201504150216.t3F2GroJ012806@ignucius.se.axis.com> From: Hans-Peter Nilsson To: vapier@gentoo.org CC: gdb-patches@sourceware.org In-reply-to: <20150414211804.GD872@vapier> (message from Mike Frysinger on Tue, 14 Apr 2015 23:18:04 +0200) Subject: Re: breakage with "switch to gdb version script" MIME-Version: 1.0 > From: Mike Frysinger > Date: Tue, 14 Apr 2015 23:18:04 +0200 > On 14 Apr 2015 22:43, Hans-Peter Nilsson wrote: > > From: Mike Frysinger > > > On 13 Apr 2015 16:35, Hans-Peter Nilsson wrote: > > > > While that seems pretty trivial, you also need to adjust > > > > src-release.sh to make sure "./src-release.sh -b sim" works, > > > > in which a tool-specific create-version.sh is searched. > > > > > > this probably does it, but i've never used src-release before ... > > > > You use it to create a release-like tarball (example > > command-line above), check that you can build and install $tool > > (in this case sim) for any target from it; presto, testing > > complete. > > i tried that but it failed with weird gdb info error messags (which looked > unrelated to match patch) so i gave up I saw no such problem at 69cb14a0d7, neither for sim nor gdb, using an x86_64 Debian 7.1. Info-files *are* being generated with src-release.sh, as for a release, so your development tools have to be complete. You probably expected this kind of reponse, but still: unless it was a temporary bug fixed between your test and the commit above, I'd guess your makeinfo tools are out of date or something similar, which would not be something you can allow yourself to "give up" on, and just skip testing. Pretty please investigate. Regarding using the gdb create-version.sh for sim, I'd rather we increase separation between sim and gdb sources than making them more intertwined like that. Anyway, I committed the following after testing, building sim and gdb ("make all"), for each untarring the created tarballs and respectively building a native gdb and a bfin-elf sim. The need for gdb/common/create-version.sh should be obvious, but JFTR, you'll otherwise get: /bin/bash /tmp/fix/s/s2/sim-7.9.50.20150415/sim/bfin/../../move-if-change tmp-tmap.c targ-map.c touch stamp-tvals make[3]: *** No rule to make target `/tmp/fix/s/s2/sim-7.9.50.20150415/sim/bfin/../../gdb/common/create-version.sh', needed by `version.c'. Stop. make[3]: Leaving directory `/tmp/fix/s/s2/o/sim/bfin' toplevel: Adjust src-release.sh for sim using the gdb create-version.sh. * src-release.sh (tar_compress): If there's a fifth parameter, use that in the getver call instead of $tool. (sim_release): Pass gdb as fifth parameter to tar_compress. (SIM_SUPPORT_DIRS): Add gdb/common/create-version.sh. brgds, H-P diff --git a/src-release.sh b/src-release.sh index 9b985f0..40d0126 100755 --- a/src-release.sh +++ b/src-release.sh @@ -244,7 +244,8 @@ tar_compress() tool=$2 support_files=$3 compressors=$4 - ver=$(getver $tool) + verdir=${5:-$tool} + ver=$(getver $verdir) do_proto_toplev $package $ver $tool "$support_files" do_md5sum do_tar $package $ver @@ -295,13 +296,13 @@ gdb_release() } # Corresponding to the CVS "sim" module. -SIM_SUPPORT_DIRS="bfd opcodes libiberty include intl gdb/version.in makefile.vms zlib" +SIM_SUPPORT_DIRS="bfd opcodes libiberty include intl gdb/version.in gdb/common/create-version.sh makefile.vms zlib" sim_release() { compressors=$1 package=sim tool=sim - tar_compress $package $tool "$SIM_SUPPORT_DIRS" "$compressors" + tar_compress $package $tool "$SIM_SUPPORT_DIRS" "$compressors" gdb } usage()