From patchwork Sat Sep 27 18:28:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 3011 Received: (qmail 21659 invoked by alias); 27 Sep 2014 18:29:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21648 invoked by uid 89); 27 Sep 2014 18:29:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 27 Sep 2014 18:29:05 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8RIT4vK030263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sat, 27 Sep 2014 14:29:04 -0400 Received: from host2.jankratochvil.net (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8RIT0xW012780 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO) for ; Sat, 27 Sep 2014 14:29:03 -0400 Date: Sat, 27 Sep 2014 20:28:59 +0200 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] Fix library-list.dtd -> library-list-svr4.dtd Message-ID: <20140927182859.GA21940@host2.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes Hi, commit 2268b414f486239cbcc0f756f157c3e03599efac added file "features/library-list-svr4.dtd" but the added code uses "library-list.dtd" instead. Curiously after changing for a test s/name/nXme/ in the DTD making the gdbserver output non-conforming there is no warning or regression seen (tested gdb.base/shlib-call.exp, using_xfer is still 1). I did not check more why the DTD conformance verification does not work. No regressions on {x86_64,x86_64-m32,i686}-fedora21pre-linux-gnu in gdbserver mode. Jan gdb/ 2014-09-27 Jan Kratochvil * solib-svr4.c (svr4_parse_libraries): Use "library-list-svr4.dtd". diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index 3deef20..978564c 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -1209,7 +1209,7 @@ svr4_parse_libraries (const char *document, struct svr4_library_list *list) memset (list, 0, sizeof (*list)); list->tailp = &list->head; - if (gdb_xml_parse_quick (_("target library list"), "library-list.dtd", + if (gdb_xml_parse_quick (_("target library list"), "library-list-svr4.dtd", svr4_library_list_elements, document, list) == 0) { /* Parsed successfully, keep the result. */