From patchwork Tue Jul 22 18:38:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kratochvil X-Patchwork-Id: 2132 Received: (qmail 11308 invoked by alias); 22 Jul 2014 18:38:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11294 invoked by uid 89); 22 Jul 2014 18:38:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 22 Jul 2014 18:38:21 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6MIcK8Q008644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 22 Jul 2014 14:38:20 -0400 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6MIcG2E017656 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 22 Jul 2014 14:38:19 -0400 Date: Tue, 22 Jul 2014 20:38:16 +0200 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [testsuite patch] Fix paginate-*.exp race for "read1" Message-ID: <20140722183816.GA11930@host2.jankratochvil.net> References: <20140722173635.GA9532@host2.jankratochvil.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140722173635.GA9532@host2.jankratochvil.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes Hi, even with this "read1"-fix patch it is not fully reliable. But this time I do not have a reliable reproducer, it just FAILs during fully parallel Fedora GDB build; but running the Fedora GDB test by hand PASSes. +FAIL: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: cancel pagination (timeout) +FAIL: gdb.base/paginate-execution-startup.exp: cancel with ctrl-c: cancel pagination (timeout) I have tried the attached patch but it has no effect. continue&^M Continuing.^M (gdb) PASS: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: continue& ---Type to continue, or q to quit---PASS: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: continue& paginates FAIL: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: cancel pagination (timeout) ^CQuit^M (gdb) p 1^M $1 = 1^M (gdb) PASS: gdb.base/paginate-bg-execution.exp: cancel with ctrl-c: GDB accepts further input Reading symbols from /unsafebuild-x86_64-redhat-linux-gnu/gdb/testsuite.unix.-m64/outputs/gdb.base/paginate-execution-startup/paginate-execution-startup...done.^M ---Type to continue, or q to quit---PASS: gdb.base/paginate-execution-startup.exp: cancel with ctrl-c: run to pagination FAIL: gdb.base/paginate-execution-startup.exp: cancel with ctrl-c: cancel pagination (timeout) ^CQuit^M (gdb) p 1^M $1 = 1^M (gdb) PASS: gdb.base/paginate-execution-startup.exp: cancel with ctrl-c: GDB accepts further input Jan diff --git a/gdb/testsuite/gdb.base/paginate-bg-execution.exp b/gdb/testsuite/gdb.base/paginate-bg-execution.exp index 3ba46a3..e1f908b 100644 --- a/gdb/testsuite/gdb.base/paginate-bg-execution.exp +++ b/gdb/testsuite/gdb.base/paginate-bg-execution.exp @@ -88,6 +88,7 @@ proc test_bg_execution_pagination_cancel { how } { set test "cancel pagination" if { $how == "ctrl-c" } { + sleep 30 send_gdb "\003" } else { send_gdb "q\n" diff --git a/gdb/testsuite/gdb.base/paginate-execution-startup.exp b/gdb/testsuite/gdb.base/paginate-execution-startup.exp index 4dc2376..22958ab 100644 --- a/gdb/testsuite/gdb.base/paginate-execution-startup.exp +++ b/gdb/testsuite/gdb.base/paginate-execution-startup.exp @@ -147,6 +147,7 @@ proc test_fg_execution_pagination_cancel { how } { set test "cancel pagination" if { $how == "ctrl-c" } { + sleep 30 send_gdb "\003" } else { send_gdb "q\n"