diff mbox

[patchv3] Fix SIGTERM signal safety (PR gdb/15358)

Message ID 20140323165745.GA23830@host2.jankratochvil.net
State Committed
Headers show

Commit Message

Jan Kratochvil March 23, 2014, 4:57 p.m. UTC
On Sun, 23 Mar 2014 16:19:08 +0100, Yufeng Zhang wrote:
> On 03/16/14 13:53, Jan Kratochvil wrote:
> >+    gdb_test_no_output "set range-stepping off" ""
> >+    gdb_test_no_output "set debug infrun 1" ""
> >+    gdb_test_no_output "set debug lin-lwp 1" ""
> 
> The test fails on aarch64-none-elf.  Should the test only run on
> Linux targets?

I see that lin-lwp probably does not exist on such GDB.

That "set debug lin-lwp 1" command even is not needed for the functionality of
this testcase.

Does this patch fix it on aarch64-none-elf or should it be really disabled?
Could you post me off-list gdb.log?


Thanks,
Jan
gdb/testsuite/
2014-03-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/gdb-sigterm.exp (do_test): Remove "set debug lin-lwp 1".

Comments

Yufeng Zhang March 24, 2014, 4:33 p.m. UTC | #1
Hi Jan,

On 03/23/14 16:57, Jan Kratochvil wrote:
> On Sun, 23 Mar 2014 16:19:08 +0100, Yufeng Zhang wrote:
>> On 03/16/14 13:53, Jan Kratochvil wrote:
>>> +    gdb_test_no_output "set range-stepping off" ""
>>> +    gdb_test_no_output "set debug infrun 1" ""
>>> +    gdb_test_no_output "set debug lin-lwp 1" ""
>>
>> The test fails on aarch64-none-elf.  Should the test only run on
>> Linux targets?
>
> I see that lin-lwp probably does not exist on such GDB.
>
> That "set debug lin-lwp 1" command even is not needed for the functionality of
> this testcase.
>
> Does this patch fix it on aarch64-none-elf or should it be really disabled?

The patch does fix the failure.  Thanks for your help!

Thanks,
Yufeng
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/gdb-sigterm.exp b/gdb/testsuite/gdb.base/gdb-sigterm.exp
index b57680d..f52517c 100644
--- a/gdb/testsuite/gdb.base/gdb-sigterm.exp
+++ b/gdb/testsuite/gdb.base/gdb-sigterm.exp
@@ -36,7 +36,6 @@  proc do_test { pass } {
 
     gdb_test_no_output "set range-stepping off" ""
     gdb_test_no_output "set debug infrun 1" ""
-    gdb_test_no_output "set debug lin-lwp 1" ""
 
     set test "run a bit #$pass"
     set abort 1