Message ID | 20140323165745.GA23830@host2.jankratochvil.net |
---|---|
State | Committed |
Headers |
Return-Path: <x14314964@homiemail-mx22.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (caibbdcaabij.dreamhost.com [208.113.200.189]) by wilcox.dreamhost.com (Postfix) with ESMTP id A622C3601AF for <siddhesh@wilcox.dreamhost.com>; Sun, 23 Mar 2014 09:58:04 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14314964) id 567A0507F155; Sun, 23 Mar 2014 09:58:04 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id 2E356507850E for <gdb@patchwork.siddhesh.in>; Sun, 23 Mar 2014 09:58:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=rYPX 2q094NxZJ4MufMy6NuvLHeQ192F82VSTUe7WjgMwhKLcu8y6ANdXFKoj3ulYoC9v 5YY214nOQtV5P+bQiJGtlT+B//ZIPfRBSGf0CifwBZnkHB2MxD1r6BkEpsyMqQgh ExyCrR+LrwaCwissWD42mOPEvkUNCScqapoxZbU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=bFrnOITwiE SyDG5KrWF2Wws1Nxg=; b=Qzf/80c7oPu1LwtBZaY5NUllw/++GGaNbITCYlbdw9 fmHEGCwUxnj2WkOHg4Tge0xt+722X0tsKC16b+gSFn0HF+Wfz9xscL7RfNRf+5MA 4uqeSdQDDb3fz015/qZXjmf/clasjHuwWLDEMA9FWbFhQhSpS+qktAac7bRSGWh2 g= Received: (qmail 23693 invoked by alias); 23 Mar 2014 16:58:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-gdb=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23106 invoked by uid 89); 23 Mar 2014 16:57:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Mar 2014 16:57:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2NGvmLr011198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 23 Mar 2014 12:57:48 -0400 Received: from host2.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2NGvjBU009859 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 23 Mar 2014 12:57:47 -0400 Date: Sun, 23 Mar 2014 17:57:45 +0100 From: Jan Kratochvil <jan.kratochvil@redhat.com> To: Yufeng Zhang <Yufeng.Zhang@arm.com> Cc: Doug Evans <dje@google.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> Subject: Re: [patchv3] Fix SIGTERM signal safety (PR gdb/15358) Message-ID: <20140323165745.GA23830@host2.jankratochvil.net> References: <20140314183709.GA28050@host2.jankratochvil.net> <20140314184535.GA30853@host2.jankratochvil.net> <21284.44419.745786.47756@ruffy.mtv.corp.google.com> <20140316135334.GA30698@host2.jankratochvil.net> <532EFB6C.2030003@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <532EFB6C.2030003@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in |
Commit Message
Jan Kratochvil
March 23, 2014, 4:57 p.m. UTC
On Sun, 23 Mar 2014 16:19:08 +0100, Yufeng Zhang wrote: > On 03/16/14 13:53, Jan Kratochvil wrote: > >+ gdb_test_no_output "set range-stepping off" "" > >+ gdb_test_no_output "set debug infrun 1" "" > >+ gdb_test_no_output "set debug lin-lwp 1" "" > > The test fails on aarch64-none-elf. Should the test only run on > Linux targets? I see that lin-lwp probably does not exist on such GDB. That "set debug lin-lwp 1" command even is not needed for the functionality of this testcase. Does this patch fix it on aarch64-none-elf or should it be really disabled? Could you post me off-list gdb.log? Thanks, Jan gdb/testsuite/ 2014-03-23 Jan Kratochvil <jan.kratochvil@redhat.com> * gdb.base/gdb-sigterm.exp (do_test): Remove "set debug lin-lwp 1".
Comments
Hi Jan, On 03/23/14 16:57, Jan Kratochvil wrote: > On Sun, 23 Mar 2014 16:19:08 +0100, Yufeng Zhang wrote: >> On 03/16/14 13:53, Jan Kratochvil wrote: >>> + gdb_test_no_output "set range-stepping off" "" >>> + gdb_test_no_output "set debug infrun 1" "" >>> + gdb_test_no_output "set debug lin-lwp 1" "" >> >> The test fails on aarch64-none-elf. Should the test only run on >> Linux targets? > > I see that lin-lwp probably does not exist on such GDB. > > That "set debug lin-lwp 1" command even is not needed for the functionality of > this testcase. > > Does this patch fix it on aarch64-none-elf or should it be really disabled? The patch does fix the failure. Thanks for your help! Thanks, Yufeng
diff --git a/gdb/testsuite/gdb.base/gdb-sigterm.exp b/gdb/testsuite/gdb.base/gdb-sigterm.exp index b57680d..f52517c 100644 --- a/gdb/testsuite/gdb.base/gdb-sigterm.exp +++ b/gdb/testsuite/gdb.base/gdb-sigterm.exp @@ -36,7 +36,6 @@ proc do_test { pass } { gdb_test_no_output "set range-stepping off" "" gdb_test_no_output "set debug infrun 1" "" - gdb_test_no_output "set debug lin-lwp 1" "" set test "run a bit #$pass" set abort 1