Message ID | 18513.1423000644@usendtaylorx2l |
---|---|
State | New, archived |
Headers |
Received: (qmail 23241 invoked by alias); 3 Feb 2015 21:58:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 23230 invoked by uid 89); 3 Feb 2015 21:58:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, NO_DNS_FOR_FROM, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mailuogwdur.emc.com Received: from mailuogwdur.emc.com (HELO mailuogwdur.emc.com) (128.221.224.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Feb 2015 21:58:01 +0000 Received: from maildlpprd53.lss.emc.com (maildlpprd53.lss.emc.com [10.106.48.157]) by mailuogwprd51.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t13LvmAk013426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Feb 2015 16:57:51 -0500 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com t13LvmAk013426 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com t13LvmAk013426 Received: from mailsyshubprd52.lss.emc.com (mailsyshubprd52.lss.emc.com [10.106.48.27]) by maildlpprd53.lss.emc.com (RSA Interceptor); Tue, 3 Feb 2015 16:54:26 -0500 Received: from usendtaylorx2l.lss.emc.com (usendtaylorx2l.lss.emc.com [10.243.10.188]) by mailsyshubprd52.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t13LvQNU012265; Tue, 3 Feb 2015 16:57:26 -0500 Received: by usendtaylorx2l.lss.emc.com (Postfix, from userid 26043) id 880775DE3D2; Tue, 3 Feb 2015 16:57:24 -0500 (EST) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l.lss.emc.com (Postfix) with ESMTP id F370E5DE3D1; Tue, 3 Feb 2015 16:57:24 -0500 (EST) To: Stan Shebs <stanshebs@earthlink.net> cc: Joel Brobecker <brobecker@adacore.com>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org> Subject: Re: two agent expression nits (one line each) In-reply-to: <20141220171955.GG12884@adacore.com> References: <14583.1410458050@usendtaylorx2l> <547E24E5.8050908@earthlink.net> <20141213134428.GF5457@adacore.com> <23074.1418658035@usendtaylorx2l> <20141220171955.GG12884@adacore.com> Comments: In-reply-to Joel Brobecker <brobecker@adacore.com> message dated "Sat, 20 Dec 2014 12:19:55 -0500." Date: Tue, 03 Feb 2015 16:57:24 -0500 Message-ID: <18513.1423000644@usendtaylorx2l> From: David Taylor <dtaylor@usendtaylorx2l.lss.emc.com> X-RSA-Classifications: DLM_1, public X-Sentrion-Hostname: mailuogwprd51.lss.emc.com |
Commit Message
David Taylor
Feb. 3, 2015, 9:57 p.m. UTC
Joel Brobecker <brobecker@adacore.com> wrote: > Hi David, [...] > Since you understand what should be done, would you mind sending > a patch in for Stan to review? > > -- > Joel Joel, Sorry for the delay. Here's the patch. Also, I haven't forgotten that I owe you an updated patch for bad structure offsets. And I have some others in the queue to finish up and post, as well. Stan, Here's the ChangeLog entries: gdb: 2015-02-03 David Taylor <dtaylor@emc.com> * common/ax.def (setv): Fix consumed entry in setv DEFOP. gdb/doc: 2015-02-03 David Taylor <dtaylor@emc.com> * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. and patch, as requested by Joel:
Comments
Hi Stan, Would you mind reviewing this patch for us, please? If we are going to change a spec, we might as well do it earlier than later and so this could be a good candidate for the 7.9 branch. Thanks! On Tue, Feb 03, 2015 at 04:57:24PM -0500, David Taylor wrote: > Joel Brobecker <brobecker@adacore.com> wrote: > > > Hi David, > > [...] > > > Since you understand what should be done, would you mind sending > > a patch in for Stan to review? > > > > -- > > Joel > > Joel, > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > I owe you an updated patch for bad structure offsets. And I have some > others in the queue to finish up and post, as well. > > Stan, > > Here's the ChangeLog entries: > > gdb: > > 2015-02-03 David Taylor <dtaylor@emc.com> > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > gdb/doc: > > 2015-02-03 David Taylor <dtaylor@emc.com> > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > and patch, as requested by Joel: > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 351ccdd..0118d7d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor <dtaylor@emc.com> > + > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > + > 2015-02-02 Joel Brobecker <brobecker@adacore.com> > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > index 8b27725..27c97cc 100644 > --- a/gdb/common/ax.def > +++ b/gdb/common/ax.def > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > DEFOP (swap, 0, 0, 2, 2, 0x2b) > DEFOP (getv, 2, 0, 0, 1, 0x2c) > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > DEFOP (trace16, 2, 0, 1, 1, 0x30) > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 9c12d9a..34fee48 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor <dtaylor@emc.com> > + > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > + > 2015-01-31 Gary Benson <gbenson@redhat.com> > Doug Evans <dje@google.com> > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > index 788de1c..297cd5e 100644 > --- a/gdb/doc/agentexpr.texi > +++ b/gdb/doc/agentexpr.texi > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > 16-bit on an unaligned address raises an exception, you should fetch the > register number one byte at a time. > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > Set trace state variable number @var{n} to the value found on the top > of the stack. The stack is unchanged, so that the value is readily > available if the assignment is part of a larger expression. The
On 2/3/15 1:57 PM, David Taylor wrote: > Joel Brobecker <brobecker@adacore.com> wrote: > >> Hi David, > > [...] > >> Since you understand what should be done, would you mind sending >> a patch in for Stan to review? >> >> -- >> Joel > > Joel, > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > I owe you an updated patch for bad structure offsets. And I have some > others in the queue to finish up and post, as well. These changes are both fine as posted, thanks! And I agree that they would be good candidates for 7.9 branch as well. Stan > > Stan, > > Here's the ChangeLog entries: > > gdb: > > 2015-02-03 David Taylor <dtaylor@emc.com> > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > gdb/doc: > > 2015-02-03 David Taylor <dtaylor@emc.com> > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > and patch, as requested by Joel: > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 351ccdd..0118d7d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor <dtaylor@emc.com> > + > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > + > 2015-02-02 Joel Brobecker <brobecker@adacore.com> > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > index 8b27725..27c97cc 100644 > --- a/gdb/common/ax.def > +++ b/gdb/common/ax.def > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > DEFOP (swap, 0, 0, 2, 2, 0x2b) > DEFOP (getv, 2, 0, 0, 1, 0x2c) > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > DEFOP (trace16, 2, 0, 1, 1, 0x30) > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 9c12d9a..34fee48 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor <dtaylor@emc.com> > + > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > + > 2015-01-31 Gary Benson <gbenson@redhat.com> > Doug Evans <dje@google.com> > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > index 788de1c..297cd5e 100644 > --- a/gdb/doc/agentexpr.texi > +++ b/gdb/doc/agentexpr.texi > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > 16-bit on an unaligned address raises an exception, you should fetch the > register number one byte at a time. > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > Set trace state variable number @var{n} to the value found on the top > of the stack. The stack is unchanged, so that the value is readily > available if the assignment is part of a larger expression. The >
Stan Shebs <stanshebs@earthlink.net> wrote: > On 2/3/15 1:57 PM, David Taylor wrote: > > Joel Brobecker <brobecker@adacore.com> wrote: > > > >> Hi David, > > > > [...] > > > >> Since you understand what should be done, would you mind sending > >> a patch in for Stan to review? > >> > >> -- > >> Joel > > > > Joel, > > > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > > I owe you an updated patch for bad structure offsets. And I have some > > others in the queue to finish up and post, as well. > > These changes are both fine as posted, thanks! > > And I agree that they would be good candidates for 7.9 branch as well. > > Stan Will someone please commit these for me (as I do not have commit privs)? Thanks. > > > > Stan, > > > > Here's the ChangeLog entries: > > > > gdb: > > > > 2015-02-03 David Taylor <dtaylor@emc.com> > > > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > > > gdb/doc: > > > > 2015-02-03 David Taylor <dtaylor@emc.com> > > > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > > > > and patch, as requested by Joel: > > > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > > index 351ccdd..0118d7d 100644 > > --- a/gdb/ChangeLog > > +++ b/gdb/ChangeLog > > @@ -1,3 +1,7 @@ > > +2015-02-03 David Taylor <dtaylor@emc.com> > > + > > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > + > > 2015-02-02 Joel Brobecker <brobecker@adacore.com> > > > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > > index 8b27725..27c97cc 100644 > > --- a/gdb/common/ax.def > > +++ b/gdb/common/ax.def > > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > > DEFOP (swap, 0, 0, 2, 2, 0x2b) > > DEFOP (getv, 2, 0, 0, 1, 0x2c) > > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > > DEFOP (trace16, 2, 0, 1, 1, 0x30) > > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > > index 9c12d9a..34fee48 100644 > > --- a/gdb/doc/ChangeLog > > +++ b/gdb/doc/ChangeLog > > @@ -1,3 +1,7 @@ > > +2015-02-03 David Taylor <dtaylor@emc.com> > > + > > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > + > > 2015-01-31 Gary Benson <gbenson@redhat.com> > > Doug Evans <dje@google.com> > > > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > > index 788de1c..297cd5e 100644 > > --- a/gdb/doc/agentexpr.texi > > +++ b/gdb/doc/agentexpr.texi > > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > > 16-bit on an unaligned address raises an exception, you should fetch the > > register number one byte at a time. > > > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > > Set trace state variable number @var{n} to the value found on the top > > of the stack. The stack is unchanged, so that the value is readily > > available if the assignment is part of a larger expression. The > > >
> > These changes are both fine as posted, thanks! > > > > And I agree that they would be good candidates for 7.9 branch as well. > > Will someone please commit these for me (as I do not have commit privs)? I have now pushed them to both master and gdb-7.9-branch, after having re-tested them on both branches. For the future, it would be helpful if you sent the whole commit, rather than just a ChangeLog, because I had to write the commit's revision log, which wasn't completely obvious since I didn't grasp everything. Fortunately, I was able to cook something up from your initial message (which I had to fish back) and your discussions with Stan. Thank you nonetheless for the fixes, and for your patience! > > > 2015-02-03 David Taylor <dtaylor@emc.com> > > > > > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > > > > > gdb/doc: > > > > > > 2015-02-03 David Taylor <dtaylor@emc.com> > > > > > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 351ccdd..0118d7d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-02-03 David Taylor <dtaylor@emc.com> + + * common/ax.def (setv): Fix consumed entry in setv DEFOP. + 2015-02-02 Joel Brobecker <brobecker@adacore.com> * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. diff --git a/gdb/common/ax.def b/gdb/common/ax.def index 8b27725..27c97cc 100644 --- a/gdb/common/ax.def +++ b/gdb/common/ax.def @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) DEFOP (swap, 0, 0, 2, 2, 0x2b) DEFOP (getv, 2, 0, 0, 1, 0x2c) -DEFOP (setv, 2, 0, 0, 1, 0x2d) +DEFOP (setv, 2, 0, 1, 1, 0x2d) DEFOP (tracev, 2, 0, 0, 1, 0x2e) DEFOP (tracenz, 0, 0, 2, 0, 0x2f) DEFOP (trace16, 2, 0, 1, 1, 0x30) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 9c12d9a..34fee48 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2015-02-03 David Taylor <dtaylor@emc.com> + + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. + 2015-01-31 Gary Benson <gbenson@redhat.com> Doug Evans <dje@google.com> diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi index 788de1c..297cd5e 100644 --- a/gdb/doc/agentexpr.texi +++ b/gdb/doc/agentexpr.texi @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a 16-bit on an unaligned address raises an exception, you should fetch the register number one byte at a time. -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} Set trace state variable number @var{n} to the value found on the top of the stack. The stack is unchanged, so that the value is readily available if the assignment is part of a larger expression. The