diff mbox

[5/11] Add M32R_MAX_REGISTER_SIZE

Message ID 15D6C0CC-388D-4C9D-AC2F-5A924908D09F@arm.com
State New
Headers show

Commit Message

Alan Hayward April 4, 2017, 10:13 a.m. UTC
Max size set to 32bits, which I determined using regformats/reg-m32r.dat

Tested on a --enable-targets=all build using make check with board files
unix and native-gdbserver.

I do not have an M32R machine to test on.

Ok to commit?

Alan.


2017-04-04  Alan Hayward  <alan.hayward@arm.com>

	* m32r-tdep.c (m32r_push_dummy_call): Use M32R_MAX_REGISTER_SIZE.
	* m32r-tdep.h (M32R_MAX_REGISTER_SIZE): Add.

Comments

Yao Qi April 11, 2017, 9:02 a.m. UTC | #1
Alan Hayward <Alan.Hayward@arm.com> writes:

> +/* Big enough to hold the size of the largest register in bytes.  */
> +#define M32R_MAX_REGISTER_SIZE	4
> +
>  #endif /* m32r-tdep.h */
> diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c
> index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dacd3325d66bd77964 100644
> --- a/gdb/m32r-tdep.c
> +++ b/gdb/m32r-tdep.c
> @@ -677,7 +677,7 @@ m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
>    enum type_code typecode;
>    CORE_ADDR regval;
>    gdb_byte *val;
> -  gdb_byte valbuf[MAX_REGISTER_SIZE];
> +  gdb_byte valbuf[M32R_MAX_REGISTER_SIZE];

valbuf is only used for argument registers, r0 - r3.  Can you rename
M32R_MAX_REGISTER_SIZE with M32R_ARG_REGISTER_SIZE? and move its
definition into m32r-tdep.c.

/* The size of argument registers (r0 - r3) in bytes.  */
#define M32R_ARG_REGISTER_SIZE 4

OK with the change.
diff mbox

Patch

diff --git a/gdb/m32r-tdep.h b/gdb/m32r-tdep.h
index 102cccecd200b7c192ade124a2fb9d9c59bdb5dd..037fd8965a7c01bd8c3ec0d1eb4a49a70d4478e6 100644
--- a/gdb/m32r-tdep.h
+++ b/gdb/m32r-tdep.h
@@ -47,4 +47,7 @@  enum m32r_regnum

 #define M32R_NUM_REGS 25

+/* Big enough to hold the size of the largest register in bytes.  */
+#define M32R_MAX_REGISTER_SIZE	4
+
 #endif /* m32r-tdep.h */
diff --git a/gdb/m32r-tdep.c b/gdb/m32r-tdep.c
index 40f29d343b91f254cce2dd783553795c9c990eff..cb53a352b2d47068ad7cd5dacd3325d66bd77964 100644
--- a/gdb/m32r-tdep.c
+++ b/gdb/m32r-tdep.c
@@ -677,7 +677,7 @@  m32r_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
   enum type_code typecode;
   CORE_ADDR regval;
   gdb_byte *val;
-  gdb_byte valbuf[MAX_REGISTER_SIZE];
+  gdb_byte valbuf[M32R_MAX_REGISTER_SIZE];
   int len;

   /* First force sp to a 4-byte alignment.  */