From patchwork Mon Feb 27 21:29:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 65711 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6CB1D3850230 for ; Mon, 27 Feb 2023 21:31:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CB1D3850230 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677533493; bh=5aFRkDDBSWelH7G/DA6AvNBgf9qKbGjXXVEHYJNpAe0=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=mF/YV3XkbHBDa3rZZTKtPASWbq6b9ghjbWKU9wEniwsiV9doRxJQU8C42cdtRuKao yuF5q3ogrFJTYF/LYflEG+mNrMgM68Rrf9SKwTj/FxD+Rs0/6rBNPqCdGoSgSisY0p KEO+OtQ9zZG4Z0iZlfMoiIq2nyZFk/1HxSIU0Rgc= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 763D9385842D for ; Mon, 27 Feb 2023 21:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 763D9385842D Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-99-Iil8OP3FP-mTfEo1p95fHg-1; Mon, 27 Feb 2023 16:29:51 -0500 X-MC-Unique: Iil8OP3FP-mTfEo1p95fHg-1 Received: by mail-wm1-f70.google.com with SMTP id az12-20020a05600c600c00b003e8910ec2fdso2859061wmb.6 for ; Mon, 27 Feb 2023 13:29:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677533390; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5aFRkDDBSWelH7G/DA6AvNBgf9qKbGjXXVEHYJNpAe0=; b=Yf0mkQABUDypHGzU0j5fwbc5waL6jWd4dFDVcEi6k2ottZN3FzeLFZIpnOm8SVTU/F rUYHA2Rs8+qz6+TWLUy7LIPruFC0Xt1J8DBpeFiOEWds/11YcTQMT54LIXcFfK/mJT5V /gAOnSqVv0heCjzfnAkwdLO8R091qOPq+Zem6EBiXJO1nsol5rAg92SEw7NNrc3IB4do kr3Ty9Xp+l7dEZZoNBpRiutDOSMTuZlTyhcX8560M2gaSep6FRxrhqrv6sROjLQ/wT9c 8EPn/cwSXKx5XbZ/g93CzKPSDtF7joOg+kx69CF2O71rgf59EKw2/KhAJRiGP9zyTTkl SUXg== X-Gm-Message-State: AO0yUKVttemlARG+oYAOj8OKTewnBBG+J5kUyIuU4+KCV+m4qLbABI+8 tUJwnra4qY54Y+fUZorQI1kj2wV/CkgDCtyfnpmLggLxS2xwXBkh/wgVhzJPmNFFzaaJ9UIqEWX nANJuaqNsKhu5ki4GY4LweL3j2LUh9H7vffALXi/9M5K9DttVi5bYJcJZHT3r31rDMb94iMrdYD FJ7no= X-Received: by 2002:a5d:6a85:0:b0:2c7:deb:c61 with SMTP id s5-20020a5d6a85000000b002c70deb0c61mr403501wru.39.1677533389833; Mon, 27 Feb 2023 13:29:49 -0800 (PST) X-Google-Smtp-Source: AK7set/y5rfa4KoZ/1Ho+Xng50BzvyZvsdyYlcZootzi/L5javPvYNe88ckGkIZJiqVrJv359NDEUw== X-Received: by 2002:a5d:6a85:0:b0:2c7:deb:c61 with SMTP id s5-20020a5d6a85000000b002c70deb0c61mr403493wru.39.1677533389483; Mon, 27 Feb 2023 13:29:49 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id k11-20020a5d524b000000b002c573a6216fsm7839589wrc.37.2023.02.27.13.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 13:29:49 -0800 (PST) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH 13/13] gdb: remove a use of alloca from symfile.c Date: Mon, 27 Feb 2023 21:29:26 +0000 Message-Id: <1538ddf7e258f98821898f15426f0e88c919e372.1677533215.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" Remove a use of alloca from symfile.c and replace it with gdb::byte_vector. There is another use of alloca in this file, but this is for a type other than gdb_byte, so will need something other than gdb::byte_vector. There should be no user visible changes after this commit. --- gdb/symfile.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gdb/symfile.c b/gdb/symfile.c index 373f5592107..1a9f811f0ba 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -3429,13 +3429,12 @@ static void read_target_long_array (CORE_ADDR memaddr, unsigned int *myaddr, int len, int size, enum bfd_endian byte_order) { - /* FIXME (alloca): Not safe if array is very large. */ - gdb_byte *buf = (gdb_byte *) alloca (len * size); - int i; + gdb::byte_vector buf (len * size); - read_memory (memaddr, buf, len * size); - for (i = 0; i < len; i++) - myaddr[i] = extract_unsigned_integer (size * i + buf, size, byte_order); + read_memory (memaddr, buf.data (), len * size); + for (int i = 0; i < len; i++) + myaddr[i] = extract_unsigned_integer (size * i + buf.data (), size, + byte_order); } /* Find and grab a copy of the target _ovly_table