From patchwork Wed Jun 27 14:55:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 28077 Received: (qmail 64204 invoked by alias); 27 Jun 2018 14:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64131 invoked by uid 89); 27 Jun 2018 14:55:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 14:55:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1530111346; h=From:Sender:Reply-To:Subject:Date:Message-Id:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7/GpX6J6n1KWqg3VnfxsfDGl9muqr2ulXZu9yZ0J4jA=; b=YMDAP3mtCPBiYS2edjtBzneFWiFcqBnu018olVBS+8W4XCaJYT/H9xWU5Jjz00rg Ax/50Y8/S3NvNnBIuaQ/kWjqDhO23n1kbaJtoF9FOu8n9YpYgmSE2q4ZOEqCBtJk bQbeEi8WaQve8o6JwFaYwCE0yLGAGtCic6kU1XAlalk=; Received: from ESESSMB503.ericsson.se (Unknown_Domain [153.88.183.121]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 16.35.31169.275A33B5; Wed, 27 Jun 2018 16:55:46 +0200 (CEST) Received: from ESESSMR503.ericsson.se (153.88.183.112) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 16:55:46 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSMR503.ericsson.se (153.88.183.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 16:55:46 +0200 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 27 Jun 2018 16:55:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShJw8gSGyxyiatIP9OzrGpTqmv8RBiNVMn92zW2Nugs=; b=X1Ep+6ijX04DBIW7zWa3OcyipaVxPJOM9gSQlyjf+BOGs/EctfmuLadJRmwyZUwED9wavQBdT8QGHt0YKjDBlDjAc1WuUhuXQ6+YmFffAPKpFamwpAWUTKyOUGtgdHPjopXcg7ye4FLJBfLnp5YiX/gBQN22syqZyZvnBEYBADg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ericsson.se (129.192.64.65) by SN6PR15MB2399.namprd15.prod.outlook.com (2603:10b6:805:24::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Wed, 27 Jun 2018 14:55:42 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] Add overrides, fix FreeBSD build Date: Wed, 27 Jun 2018 10:55:30 -0400 Message-Id: <1530111330-17606-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes Fix this: CXX fbsd-nat.o In file included from fbsd-nat.c:44: ./fbsd-nat.h:40:7: error: 'find_memory_regions' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] int find_memory_regions (find_memory_region_ftype func, void *data); ^ ./target.h:702:17: note: overridden virtual function is here virtual int find_memory_regions (find_memory_region_ftype func, void *data) ^ In file included from fbsd-nat.c:44: ./fbsd-nat.h:42:8: error: 'info_proc' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] bool info_proc (const char *, enum info_proc_what); ^ ./target.h:950:18: note: overridden virtual function is here virtual bool info_proc (const char *, enum info_proc_what); ^ gdb/ChangeLog: * fbsd-nat.h (class fbsd_nat_target) : Add override. : Likewise. --- gdb/ChangeLog | 6 ++++++ gdb/fbsd-nat.h | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d4ae16c..c315246 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2018-06-27 Simon Marchi + + * fbsd-nat.h (class fbsd_nat_target) : Add + override. + : Likewise. + 2018-06-26 Joel Brobecker * windows-nat.c (do_windows_fetch_inferior_registers): Rename diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h index 8c90dd0..3e34600 100644 --- a/gdb/fbsd-nat.h +++ b/gdb/fbsd-nat.h @@ -37,9 +37,9 @@ class fbsd_nat_target : public inf_ptrace_target public: char *pid_to_exec_file (int pid) override; - int find_memory_regions (find_memory_region_ftype func, void *data); + int find_memory_regions (find_memory_region_ftype func, void *data) override; - bool info_proc (const char *, enum info_proc_what); + bool info_proc (const char *, enum info_proc_what) override; #ifdef KERN_PROC_AUXV enum target_xfer_status xfer_partial (enum target_object object,