From patchwork Wed May 30 19:03:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 27575 Received: (qmail 40452 invoked by alias); 30 May 2018 19:05:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40287 invoked by uid 89); 30 May 2018 19:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 May 2018 19:05:00 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 57.F1.00712.9D5FE0B5; Wed, 30 May 2018 21:04:58 +0200 (CEST) Received: from ESESSMR503.ericsson.se (153.88.183.112) by ESESSHC013.ericsson.se (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 30 May 2018 21:04:22 +0200 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSMR503.ericsson.se (153.88.183.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 30 May 2018 21:04:22 +0200 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 30 May 2018 21:04:22 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Wed, 30 May 2018 19:04:20 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed 03/15] Remove regcache_raw_update Date: Wed, 30 May 2018 15:03:41 -0400 Message-ID: <1527707033-27183-4-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1527707033-27183-1-git-send-email-simon.marchi@ericsson.com> References: <1527707033-27183-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: SN6PR0102CA0010.prod.exchangelabs.com (2603:10b6:805:1::23) To BYAPR15MB2392.namprd15.prod.outlook.com (2603:10b6:a02:8d::11) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BYAPR15MB2392; X-Microsoft-Exchange-Diagnostics: 1; BYAPR15MB2392; 3:kLfvu37Rgtp/cHKIplKfjtglE/n58TH4GImP3ubwd/P9Cv8NBoXYBD13Rx1lleLMehnboDNCuh67nZ9lVPFSF+zUJFPMr9fxUhGfxABg2fr3fy/lDyljYLmfGlZhsY680eL6XkvGL8PZpa7SEs4f1McpLFtreGo8wOFwlEGENi7WxOpN+enyH++7PzpxZehjX+GecEtl2u2PZ8z5NyXOfVS6jM0KLkpEPR8VmcOxwb2UfsIVR6jnIBziDdSIsOXQ; 25:LJsVT/n7vbBePqBiR2DECkQuNRcE8/fQDAejPy4/ToJ+MRjt/iigfva5VeicjRIq0wRZcqAOKDcNXf8T+DGdKzde8soC2phy6E6dU8yhJdf34FHfkffLm0tG0V01IoIE32XzO2UubwNHj4gq8Rgd6kIuwzQHT8JTH3VIYB6FqcZJ7SWH8d1NEvU2Ag8VdzfY64qA1mjmLiZNacTOGF9oLMVqSG39yj0wpGEuXwDYTIrcnBUWVLtwTOSDShlLGlW9+IavYud9lXPa0ngT4LeN6PQRzwTUNVAKX5AYN19cU6MtusmxoTD9IhXH4q7h4GMEAkmp2h6ApTFtfx4pvhR6IA==; 31:sf0DtCU48FSs25Sm0CVq64zI7udz74v/kOSO3YDp0V99pgs5P0kLVQ6hvUA7O9A+RPg18aPE3A+WtByQV6c8KWVMeoyTKwTxX4XUxXLJfnrVa2mgw6gQqFG4rPPygUO67RUYx3xLU1INy/5X1414NKsL7YMRBqhqGHF0yhc6KNkcUTzu61iUYO9KR8jTPPWTxrz5bsRXq9MSMclsmdS7wrQk1IH0my2My6S14oQYNVE= X-MS-TrafficTypeDiagnostic: BYAPR15MB2392: X-Microsoft-Exchange-Diagnostics: 1; BYAPR15MB2392; 20:QxyiRF0D40ErHiWAzKSvxsbm3WkAJPqMv4kNxC7bi6oStUsWoJAsA+nhy4J/NGsMyTOU4NI/8z7MMonjXPqNB4jvLX/YYMfPwN6Xv1sxP9fO6pKSfd1SBuLjOfSurm4UL3ML31L29V9/o6gDd+k2nXaJygnSutbwvsXnpwgDhszduiOVhMu61zbInm9HuGfktXf4TLbMI0ofeX0iEEJIBsfrNmEBiapRNrWF22Mobt2d+ChJpnMRkNijwwsGAnnm4/j24VtT3cnHcUsUyohGKWztd9S3dMVdbGePMtB+FDh3jlwXSRmqsGNDqoSrhRajs+1CTSMmDI0W08FAE9ueE+SgjVZt8xKI2HkVv5kyooVXbP6wujA2GeApQiQl1IEKzbBv3lO5C7CMxrjFVioE173f7p9fNJGsus/egXfLcQK2WWhJX3NLubffL/9PzFbRKwP7fJy7hRNyA+bRZO2leDwETQArkeIcOAStVt3y3j1PVDLJCoUyND0e+hW+BE0l; 4:i+e64N/+v9Vfyl2ANuOw+5h/7LA75IMqbRQ2SNKp8sfjgwRG7zKSN2sbcm2jdWylf/s4K2/xeuw5Y384FjxzeqhlzuWgKXfeublxN0tNXsATjriQXuIN4f2cTyTHFjQR2ipIDN7D7h1j2tu6FFUx4njSkLXX0Cgmd1xLpQKDtV1g1dkXsD8O/fiEgXbuVsOUyKFkyPOqIdlp/AzWKrwZQMhXI1zTsQyM+IRzCTpwjifDnQ9seqtKWfb8c5xAHsZAXdqet890yVjkFTVVV18L8d56/WNVz89s00hxZ6NMc82cPIAeg1RQRwAZB57/1KMK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BYAPR15MB2392; BCL:0; PCL:0; RULEID:; SRVR:BYAPR15MB2392; X-Forefront-PRVS: 0688BF9B46 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39860400002)(39380400002)(376002)(54534003)(199004)(189003)(50226002)(6512007)(486006)(8936002)(81156014)(6486002)(25786009)(26005)(68736007)(8676002)(81166006)(51416003)(86362001)(52116002)(956004)(2616005)(44832011)(76176011)(476003)(446003)(11346002)(6666003)(6916009)(305945005)(386003)(6506007)(47776003)(53936002)(2906002)(36756003)(7736002)(97736004)(4326008)(16526019)(5660300001)(186003)(6116002)(3846002)(316002)(16586007)(2361001)(2351001)(48376002)(478600001)(105586002)(59450400001)(107886003)(50466002)(66066001)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR15MB2392; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR15MB2392; 23:6gD2vW5BXCez+wQqtExPIdHlEbR0Z0WKGryKxFg1m?= =?us-ascii?Q?vTd+4r0vJHJHC3kDO9T8Uylq0gJu852oX6NfvknxEl5ZjoATNCJqJjQK19hz?= =?us-ascii?Q?4lWwqQtNbd05ijNxDPi79no1Fw3VDNH1LPrtskqmupV4HZJSdJ2t2ChAPqkx?= =?us-ascii?Q?h+TdBGZbOZs09cpD+a/OjfkZ8W3DOPBdUKTpAQk5T9t6rimJdDx+9o8I4BSp?= =?us-ascii?Q?Sc5ej63n71OcDzgoeHJm91NwmPvUuK6kUqCkkZc1KjAH0HHNiK0ujIpwByaf?= =?us-ascii?Q?93O0XQ70GT27VWRXSKSXr6X8mU/XNpcwjQEzaGoABxMj0RUIFNM5HtYQPrK2?= =?us-ascii?Q?qlzsobI9DG/fcZW1V9UGkdj/Du1Hc2GthsiDFkSvKNNjvto7IoTqgsQyr2ig?= =?us-ascii?Q?s2ndbvBK4WyIF+wXqCiy1BWFFvA1IlpvurhyMvRGkwdYKGhscqdUJkfaC8bg?= =?us-ascii?Q?ZhlossOC24Ne5c8iF/xN0fLq9MldrKrWOj19t7pRbQrSw0C0Awn1tXE8UDmk?= =?us-ascii?Q?gXnMe/Q3AcUbeQzo5CHauLZSht8fYa6KL2OGhCqmdw0n/NkUxn+W/Dy5wkOl?= =?us-ascii?Q?5gbo72vIOHigwyi60FM0sHFwLue4TOVYWIcXhfl0KESViqQUW8fK2/zb/Fp2?= =?us-ascii?Q?VTidTGj+i3YC72H08T5Eg7Yr5kpqJ4/GLMpxYfIcn8lhF+HPb0Ikxpe38AQi?= =?us-ascii?Q?X9Z5ZjcfUNERvuWeFKeoWIoTmWrZyNR8G2/yVCuQkKJLXCMmUYJRnPGXFIpI?= =?us-ascii?Q?tFaQvdLyYw0JHNN+xtMGBYbPYxM9VQIwOZW6lXhzbsLPpOVz+mWf1WQbVohw?= =?us-ascii?Q?G90WFH07jElZn+mTJVElvXvybS1UInx48lKK1pb0np/RGRoqA0lo/7E+SV/L?= =?us-ascii?Q?WDqxRhsr+u9Qyxv9WCCB//F8ah4RnWQ0fo6WwsMHreT2ghmKks4UztDMsEFS?= =?us-ascii?Q?a8jjmLtH7S1wi75l3uFbGpEpPe8duPEZ2DEs/G567CUxSG0rT7n/sfYcdZrS?= =?us-ascii?Q?Akprnes29xE2zJmtu73jAvUxLJRJqbV0H4vKR+llriL8R5XReN0DVZ5psyhA?= =?us-ascii?Q?p0Cz16QaLthXkNsKyXfiBITJA9QJn53FtNoTH3o+9cVvmYfdAuCgrQ6RIKPD?= =?us-ascii?Q?TS752oAingzHC78Dtk587Xy1/0bl4IR4MI6JMUsq3XSRhPUCsj0hlXiDapP9?= =?us-ascii?Q?xrsP5heK1KzNBQcZRAfse/4zxnEehQ1mXmh2PTb0gVsOyzYQCzeoNnksIqxe?= =?us-ascii?Q?Ep5DHfv8i8EId/wP5aDKbJ62Rj0LN7keOSoQT2twmCBgB/IvIUQ3edkzKaae?= =?us-ascii?Q?WWsDFqY6QAKgKIQz+FDI6g=3D?= X-Microsoft-Antispam-Message-Info: 2vLL3y++Zn3lI9FPYmxL3ob194EH476uDTpHQR+b/eyQcyqpliCoqZZpoo1tEmQ0TqfR9NKr6gPPcBtgB8RJW2Y3KGJBvdmcWRNTHdug7GZEyZgY9VXjhrcgzoMdcgDOdcqzANHlw5EpI35d3oB8rbb7YPPFbYJSMk3T/ID/2AMUZjEHsIpHcpOz8Tp5LZsx X-Microsoft-Exchange-Diagnostics: 1; BYAPR15MB2392; 6:6b8nc7EwbdDcKNFP8Kf/hiAf1p7hpoYgNipleoNajOidJtVzi0Z0HEw67unlkP2KgkNZsGBJHNPdCrYOP9FZpL3i9B7LhsmyIBqQk1dk/KheM1UbyreR4qV4hSyiQ6GmWC7MpLaAGF6hJNq5W/adTps/3g7qDOSuDv3wCu9ROl92xrDaK/IEHtpBFJjNorAUP9XnGwsQXUZseCLnLNex7i9lDWBNotcQDgjIuc76BMT6A5u+tTn2Hb5BfZ3NQIvSLjAtdlOZLZXHNXsJmwgJwyy8GY9NpkcEN8ZaUXi0wGxpt67knbLQMTaczYUrfYDkkJkHK9QLmE3w2QMBfzNw+gohSTw08NcaLpfunxQG3NsklYBXnu8pzPZyLTrJGC5kXHntL0pndEz1BEZdEGMw+Hqj8wek4HNLxAfrtuue5vTWa7knHJws6cc7voPCl0SWprnEo/3H9EM/1W6XptRFxg==; 5:E/IftGIjiUCvLa3b/hRcSDnCO2rgkwn3+y2u17NqokyLiSUi3dCECLq1pt2pSnxAEmOjaRhVZM4ocQVs9/V3QnDRIW7CjRyuEbjF0o4eMFZednUJSjDR4ZmTBOr63EgZpGnAV6+5YWIX850D/R811hbaFNN5rE2ju2hSjsnN7so=; 24:V1RUFd4UmBebCZ8HFcoSIWn3C27W8RJlQPksW7MLx/sYrU/pqTP7UzmcLnfZmWmWOXXPzPxXKfTl9T/nIOQJDyKwlBoM8OhUE7AHfm/SE00= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BYAPR15MB2392; 7:orzVFhdavYYsnOq2084vKOGiU3HbcLLw0h5CGrarCFjQWSUJikqy58ixg/fBdcf9vNNbflt6W5YJ6fWCQ1LpWoupuZ5NAh7DIn95tSeYpzVCcLz/xDo6DYHFPiqKFIilh1PlFn6jGC9SCdbSVTMBSll7B1k1eKPCLNUXI1WKwpE8MYmG1kKo/Whc21KCSk6+gnz5RYmmCb1AUEMob7Sw8KSg/1efm4mgdWLthJpw076Uibsl/j+iCxJsWebLfVBT X-MS-Office365-Filtering-Correlation-Id: 7125ee6a-17ce-4f8e-368f-08d5c660268b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2018 19:04:20.4079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7125ee6a-17ce-4f8e-368f-08d5c660268b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2392 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes Remove regcache_raw_update, update callers to use readable_regcache::raw_update instead. gdb/ChangeLog: * regcache.h (regcache_raw_update): Remove, update callers to use readable_regcache::raw_update instead. * regcache.c (regcache_raw_update): Remove. --- gdb/ChangeLog | 6 ++++++ gdb/regcache.c | 8 -------- gdb/regcache.h | 5 +---- gdb/remote.c | 2 +- 4 files changed, 8 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ef6d921..4f451a2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2018-05-30 Simon Marchi + * regcache.h (regcache_raw_update): Remove, update callers to + use readable_regcache::raw_update instead. + * regcache.c (regcache_raw_update): Remove. + +2018-05-30 Simon Marchi + * regcache.h (regcache_register_status): Remove, update callers to use reg_buffer::get_register_status directly instead. * regcache.c (regcache_register_status): Remove. diff --git a/gdb/regcache.c b/gdb/regcache.c index dd1dde2..64d167a 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -489,14 +489,6 @@ registers_changed (void) } void -regcache_raw_update (struct regcache *regcache, int regnum) -{ - gdb_assert (regcache != NULL); - - regcache->raw_update (regnum); -} - -void regcache::raw_update (int regnum) { assert_regnum (regnum); diff --git a/gdb/regcache.h b/gdb/regcache.h index fa177b5..dffc27f 100644 --- a/gdb/regcache.h +++ b/gdb/regcache.h @@ -35,10 +35,6 @@ extern struct regcache *get_thread_arch_aspace_regcache (ptid_t, struct gdbarch *, struct address_space *); -/* Make certain that the register REGNUM in REGCACHE is up-to-date. */ - -void regcache_raw_update (struct regcache *regcache, int regnum); - /* Transfer a raw register [0..NUM_REGS) between core-gdb and the regcache. The read variants return the status of the register. */ @@ -257,6 +253,7 @@ public: enum register_status raw_read_part (int regnum, int offset, int len, gdb_byte *buf); + /* Make certain that the register REGNUM is up-to-date. */ virtual void raw_update (int regnum) = 0; enum register_status cooked_read (int regnum, gdb_byte *buf); diff --git a/gdb/remote.c b/gdb/remote.c index 3df9ad4..3aca5fb 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8339,7 +8339,7 @@ remote_target::prepare_to_store (struct regcache *regcache) /* Make sure all the necessary registers are cached. */ for (i = 0; i < gdbarch_num_regs (regcache->arch ()); i++) if (rsa->regs[i].in_g_packet) - regcache_raw_update (regcache, rsa->regs[i].regnum); + regcache->raw_update (rsa->regs[i].regnum); break; case PACKET_ENABLE: break;