From patchwork Mon Apr 30 15:07:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 27054 Received: (qmail 3352 invoked by alias); 30 Apr 2018 15:08:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3319 invoked by uid 89); 30 Apr 2018 15:08:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 15:08:03 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id B6.27.30337.15137EA5; Mon, 30 Apr 2018 17:08:01 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC021.ericsson.se (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.382.0; Mon, 30 Apr 2018 17:08:01 +0200 Received: from ESESSMB505.ericsson.se (153.88.183.166) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 30 Apr 2018 17:08:01 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 30 Apr 2018 17:08:00 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by BL0PR1501MB2003.namprd15.prod.outlook.com (2603:10b6:207:31::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.18; Mon, 30 Apr 2018 15:07:58 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] Use bool in read_index_from_section Date: Mon, 30 Apr 2018 11:07:45 -0400 Message-ID: <1525100865-1748-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: MWHPR13CA0016.namprd13.prod.outlook.com (2603:10b6:300:16::26) To BL0PR1501MB2003.namprd15.prod.outlook.com (2603:10b6:207:31::33) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:BL0PR1501MB2003; X-Microsoft-Exchange-Diagnostics: 1; BL0PR1501MB2003; 3:rHSaraa16EnOs+JDZS2Bqdws9T6O4eGwz1xU1PxUfLM9oaA+J8sW5nHyKOZlOdfiQ+ylsnmtXuUha9VYnme2AatrjEt32lvf3VwxBBATU/5KErvoiprTNGS7MYNjiIVkHN3ugcRr9q0ElJG6eLlHpmDfpOvR/YWD3ki137ZH0dOuVz42aOLFKK8Es7WVBCWk/JmnITqGkVlbEeq0hdqE5HJslVnckgjULK0TQDVSek18kzDjNtgEc0Tj2fwffEZY; 25:qLtDc838MlJb1jsELdltau3ZxVBNEUUi+fnbovLm7gtqOU6g/6d55t2VRBXSTwK4y2K2hPeA6J/31iOZ9xLImGd6fQ0gYhJcx2y8s9qwHbuAAja3TFwzrjMitRgTu6nP3Gw2uJf30mpIFoX9x1dxNiHN6v+VZhQRd67XuBf8p6drOWXCHkIZB3l7JSGBv2OV08wJ3LX5mv52uYeW22DsIGlSMHwuuO4criSEEIayop5gTmboWj+s2ro7EB5qv0p7vTrjkpBzizJJelSGudKXdbxaELLPJbfbGDOC88oVRuQlbvCW6GoFj1PoRMduzxofAjYonv+gVklz218iezl3qQ==; 31:Hwh5pMKPi6oyx8HZkyGzqMYYUlgdTyAd3kY5j1dM8xHScrPPLJQL5IK7P/O9iirekiyfHRZ2LTZ9mtT3rEroOimICRCLt5zfi71dw8rbRp+oX4O95E8UnExA25qVBvu9+XEO1ZQJKc+copb5ICsHoTC1kQPu1gNDRl/usL1jgg6lKAy938ODomYqiOa8+tEJbsEUQulajwfGooAZfJd0hPKzt3DYDCA/YBL/H5Wlj9I= X-MS-TrafficTypeDiagnostic: BL0PR1501MB2003: X-Microsoft-Exchange-Diagnostics: 1; BL0PR1501MB2003; 20:sr4pyW0vxn2AxalUjev0VjqtSPdJ9htpEnxO1G2nADTRNHuWeRTQBnZxL5Vm4TVAFmZFcy7Hy3XBjjr5c2ReNjRmn3wt3Bj47KH75TQcPNqOOk65sOc26vhy1D8iwnJes/KiZdVEhxnrsGp0iJrZOGGsZmRT0mrJhGlHGVpDNNJTA0XbYms79tsmRgTGNY35OmeFe1tQxVgfHWWOUZiYj7qowdtGL0b9l4RUIBh8voRspj9bfJOVF1hyItSYjkGD0E0j6jMaCCIDAJcOJf5GnRDfhER19mFMgvv4R9/ScFy9qBx4qvhIQDtmLB0uUjS7jgNvy8Ls9rTKQ8tA59wDKg7AKaZUnA29ubsjpQ89W385FXYjm1nLPJkN963+UTZcLje6bQXg0CFBHkVMAX6Rh+y9VR9DzV1VNJu34XGk41N8smyRRa3nanZlmHyP6Mt5PbrFrd9giySqVaxypm+8aVDvNUuHZfQ8WG+CSm3zqb19pHYRGwFunsaILzXGNC7m; 4:S/gRuX0syYcAh4WMInFY0n+qj18YZZN5stUT5muvtPU754dhHuHS8/+tYgeksXWAF1veBosdVsvOjVNvj7KoMDrw0TEOlgge2yxEVXtZnuK27JaHsBzjA2+nqKdmrOHEnljnBmVxM/kTEjhekfGuz3LW8/7HoFaRTl6eaE2rJuQGWcZJYFqC5Cb4U82D15hmRJQRCWaz89URQzSk4/HYOWPOMbpvADBf/4gobpkQ3reky7VHAIRE4wz4KtbgRM+1z5CST+TBfMJYYll8JdEgaeI/YQWrBzpPWgFRKIOWZsnebQS9URuXnNk3xcgWplEw X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:BL0PR1501MB2003; BCL:0; PCL:0; RULEID:; SRVR:BL0PR1501MB2003; X-Forefront-PRVS: 0658BAF71F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(39380400002)(396003)(376002)(39860400002)(54534003)(377424004)(189003)(199004)(107886003)(16586007)(16526019)(386003)(4326008)(5660300001)(6506007)(26005)(186003)(105586002)(1857600001)(51416003)(476003)(3846002)(106356001)(53936002)(6916009)(52116002)(36756003)(6512007)(68736007)(478600001)(47776003)(86362001)(81156014)(8936002)(48376002)(2351001)(2616005)(956004)(50226002)(2361001)(7736002)(316002)(8676002)(50466002)(6666003)(25786009)(66066001)(44832011)(6486002)(97736004)(2906002)(305945005)(486006)(6116002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR1501MB2003; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR1501MB2003; 23:MQEO/j8X7oxVNuZWJ/bR+twzxfpKUKCQ5lQCgrn?= =?us-ascii?Q?O5RgKDE0oNTznXrk1m1Qyf0gPY7rOciJ5kmhtHSsPyqfRXHK1TjeXXcUoWs+?= =?us-ascii?Q?l1iDT0AYmu1aUPwdWpRhR1gxBslA8ZRdy1sTo7JTSXqOoYht9rTQmfTlnDOw?= =?us-ascii?Q?eP65KqfwfwhPjg0KRmOP+9xQv5EvwCYNiUhYbyDOBMmYIXPN9wPBtLSvnx/E?= =?us-ascii?Q?iDZDA6O2JVj8ikyrcCmgCZ9T1g4sWdZQvYfdUnjS79Wd+CYe+LgfhmgPAGtN?= =?us-ascii?Q?gHtcPS9bX3LR23G68wrY7lCeyzky/O4uD+X9RHnC9jchF1NLrt18iqEOuk76?= =?us-ascii?Q?gKJZMueobRWuZG4pP2jJ+JlU0mW3cEJFiVn/zsAKRB8Wo/f9S424iMy29FVV?= =?us-ascii?Q?5OrK03UBQHtRdwK8zj5bC7zrSVbOExrkGzqc8cS6uViTLlScl+CeqWDLnlA+?= =?us-ascii?Q?NRCcTr/sSEjZksS0jXU0OwZU6NeozhzckWyEEMpuc0OoPdmhsM0Ly4I2LG8Q?= =?us-ascii?Q?aMV42Jtm7Ewr5fqR9+QWKKDMLwylpDZMEbt7pCIjudYqk4w3EmTsDVTCZUnj?= =?us-ascii?Q?fidXLgvh9jcjFGfricWAftN+gUOmT2SAUQxteKJzA/tngFyjDi6NYcilv4Jl?= =?us-ascii?Q?vz4olLZsqwSTpeISQnr98f2IBxjnSK0dqrbykdE/kowYUBrcS2mE6Fb11WMx?= =?us-ascii?Q?SNyo+Ufesmc3Is6KoY6BH5BgYqAgZWwNN68MTCRu3O1O3IEZKNpqiBprRsaG?= =?us-ascii?Q?bWyU9R8IxVxbPPFECCA+D2HnZxkmunnZw5+cdAt3Kx2tomd5zEwb0xC9eWxV?= =?us-ascii?Q?S1wFNRIJBlzRjuvgjRUJajkQLXkyxbq3m1LoRHtCScXsuNfDheN1lqpFSW7I?= =?us-ascii?Q?o+H52BFgRYJm/p/vdUkHC3OcFE9mqDhUzOovRNyHDnbQo6xMkZkXUow0UStC?= =?us-ascii?Q?/e6DJHN/c+gnuCZhJ8uok4QCeaqtR5lKU8OPYQ8fxUfgq1oalsV+ygE/nFfR?= =?us-ascii?Q?/qbXI++HRPvHH8SEI9LtBzwIgyi+TD7Qlg21WbQJS4gR85eWW84mP8m4squX?= =?us-ascii?Q?SuPslLI0f9qk45DiZq+CIVF88Bfpf3p5/tjcsPKr798tDgtj+1tITJbAMUC+?= =?us-ascii?Q?nBuVidrh4okc/TbK6uYa/Akc1e/oSTUPr8Xx4yjVjXZsTzSZnwkPayWXMDBu?= =?us-ascii?Q?Ht4gkKfeW2yIgldPYt5UN7gq7l9wZFFKyhIZ+3BViv7DAdyz7j4yHfgc4RJJ?= =?us-ascii?Q?G7lotAD4+daCXrNLSC8Ye0rCV/uKT7bO1Jzo9n+Lt?= X-Microsoft-Antispam-Message-Info: ZxLD/hnG426oiaenck05d2sGJwtsAelrgCRZnpT76XIPueriNcFYqN+9LocaesMzV0aREUbKaogG/YGt1EzbUR9vtf46EMlo4QSfRTbxoM9A1XX0wmUE5AcXcKl6790uvutfPOMdffzhu7BOCy2g84psDdQAEEnTpLTvGMv6fVKiQXCopn1w+3UbARJNAqQ/ X-Microsoft-Exchange-Diagnostics: 1; BL0PR1501MB2003; 6:LW+uJ9fh4Q9hly1rRZ7M7ZRWXdHxSbUJMQAmJtixn+hJRx2hqzjAk7S55MtXwyCzanSnHOk/8NjgDzWbwR5oCugsTumtZzJtPsDJJDfhwE33zMAJr2i90I1J4n7me/q87xg7WNbKGa4SJioO7pM6DbqHvzZ2yz/O/No5g/OYbSG131y/KTfZgRjXM8vVGN/nCDAyPI5tQCjUpA+vd5If0+Dc58kN4qxnSWVJIJAfCnBWgktFSV9rtlme2Oruhvv5S4NyHcLQesQXRkUoOBC6XYyBhcMHFEW1oEEn/NyT4Rb4jDhuHr0Pkx7jalD+6UXkwGjqwGgCGZYIPDZVhv6E6kQMFbJFLZwRNG0J+PB1eb1BqCraF7Rdz/oSRsNjyZ42MGIyanS1z8Gd9br/d5La0pJLk5MmOF5/33U14Z19PtPTDlZsiiiNcScISbhjqijWdGY7ZcyWP/I/pj57GzoOWg==; 5:eS2uTKO2iOxbGhpulN9CDaluBfBSgKQTk5336Jx5PPS1MdV5O3QenVXZumi1knhuJBSWzwrX1ynpMPHyHW/Bxi8Ngr0O8ErcFw1iT+nhx5kA9LkfaQM8i2gv2HatE5f68GIj+uLyfo7Z8YMXLyP8H7VBUWLAtL9sDgKcl14RVSs=; 24:Li28QynM5RM+AfN9Y+H0RAYxZGTMNCitYC0c1BN35gsB3UwbibqdmN0f9kAiu08fww58f3+TjE0JKVEGbqzrGvjKnT+pHbyfHwGYUs1epsQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL0PR1501MB2003; 7:jjrqiHvYgN8qYV/WoK//YGcYdfxINl9d/x31S63tRmD5FjImqZyGFI6jU9HOcFJS/e/M7lAsJJXffI3fRsdjCa8MAQNj/SHeXRIwbCfSqNimSrEEswaj8xJO2s9Y3O1XtutZEn4JkXh+nedGRhRXEKxPobT39Z+wNfHVF/NQxG9YXf3BrSyKDX4+Hdkqb4HgFtMgY3WRKE998eRbUqHs5I2IxFjb7tV6HZyszgjwJg4YSgHD6xoWEOXXGE58nchg X-MS-Office365-Filtering-Correlation-Id: edd05ded-47a9-4153-a79d-08d5aeac2930 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2018 15:07:58.3486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edd05ded-47a9-4153-a79d-08d5aeac2930 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB2003 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes I happen to be working with this function, so I pushed this little obvious patch. gdb/ChangeLog: * dwarf2read.c (read_index_from_section): Use bool. --- gdb/ChangeLog | 4 ++++ gdb/dwarf2read.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bb80e1e..2a68a1b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2018-04-30 Simon Marchi + + * dwarf2read.c (read_index_from_section): Use bool. + 2018-04-29 Fabian Groffen PR gdb/22950 diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 9eb98b2..fb10964 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -3411,7 +3411,7 @@ find_slot_in_mapped_hash (struct mapped_index *index, const char *name, /* A helper function that reads the .gdb_index from SECTION and fills in MAP. FILENAME is the name of the file containing the section; - it is used for error reporting. DEPRECATED_OK is nonzero if it is + it is used for error reporting. DEPRECATED_OK is true if it is ok to use deprecated sections. CU_LIST, CU_LIST_ELEMENTS, TYPES_LIST, and TYPES_LIST_ELEMENTS are @@ -3420,10 +3420,10 @@ find_slot_in_mapped_hash (struct mapped_index *index, const char *name, Returns 1 if all went well, 0 otherwise. */ -static int +static bool read_index_from_section (struct objfile *objfile, const char *filename, - int deprecated_ok, + bool deprecated_ok, struct dwarf2_section_info *section, struct mapped_index *map, const gdb_byte **cu_list,