From patchwork Thu Apr 26 19:34:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 26990 Received: (qmail 62220 invoked by alias); 26 Apr 2018 19:35:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 62203 invoked by uid 89); 26 Apr 2018 19:35:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=target_board X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Apr 2018 19:35:23 +0000 Received: from ESESSHC021.ericsson.se (Unknown_Domain [153.88.183.81]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 6A.9F.26811.8F922EA5; Thu, 26 Apr 2018 21:35:20 +0200 (CEST) Received: from ESESSMB505.ericsson.se (153.88.183.166) by ESESSHC021.ericsson.se (153.88.183.81) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 26 Apr 2018 21:34:31 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 26 Apr 2018 21:34:30 +0200 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 26 Apr 2018 21:34:30 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.17; Thu, 26 Apr 2018 19:34:27 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] testsuite: Fix cc-with-tweaks.sh being executed in the wrong shell Date: Thu, 26 Apr 2018 15:34:17 -0400 Message-ID: <1524771257-13690-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: CY4PR0101CA0015.prod.exchangelabs.com (2603:10b6:910:3c::28) To DM5PR1501MB2006.namprd15.prod.outlook.com (2603:10b6:4:a1::36) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR1501MB2006; X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 3:L5A++oA3Mmm51M5sIFltIBE4AIu51AJrJXeNpD2jerXXyExBtQPXzt/CxiU2J/FQ1lkXUmNS7KPpkcEVZshg/W0zl78aQTuQutnNljlPzH4SQJ/XMDJ2rhplDgFQVspqmiW5vNwzpWnF/DLZ0CiUOVGWsAblGTN41TyYzaqITqwMx0mg9Ca0xgvmdJcgrx+HWBOEKDGv9ZgFrHlo6y8B3f73aNrAaPcpMy+2itzhkqxvnA8Gl834BoyR+mE+Yay7; 25:ht5K/zwT1VS69hiS2Hv5vsPGFzkVHkkGoV9x7yE4JR4rEiSrZOCzuWAp6b2aMxUCmsU6Y0wRZyt9hGj8Bga5lc2/LG0Un22ADj8/BxkPjqWEF97TU6FfQlYVa/ulDR7gBqvHRFqvvYdjK24dvs8EnLl2kVK09VZkK7VRWRhhIJGC5AOKwFYlBqoWXbXldoI3P79WvcRdwcYcGp66HYEt3SG9g7jo4AaByumXyS5xT0k3obzduYzLns5dBP/i5QOnL63mvBjj217NGIgNTrjWmUv7qbRSr9DNt9m1xZ3IW8Jpt3yNKE0E1pnVzFBDupsEGkhmvmhOu0R7pJ8SLjsgkQ==; 31:tOr6nDyV71SBX/uPYxxf4KhrIWx1ZgLjXN1h8ZbjsG9BhUon/V/JC/qFisQdboe8nuozHTKz9W+9tfvWLfNXcoRfFFBcKJTlZwtoO2zoJLBbMxrfLsQaDL38mJe+XGtZbF+QXVMuo0gfBZ27Y57E7JI6fPNnUME0RLAXR4Sa3EHfTOG+/B0SXrE7R8kqkzDzZ50nFnoJ7VDV3Y6NsiFXptmKIbuc8wUEVSAtpfnncVI= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2006: X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 20:sts4CHWaQjVIJCUzzZPWMBoSNCmieWzaLoXAZRpdZIF28GHArjB4ic8yoCkw5Gw1Fz1+3lgu4sTtuIPHlG3p/TGfWWSh0dTdfsBnmKp4WrbefbqGjG+MGLmrJ7dG9uVAzEKyZ9jnz/W0BbP1i3vaRPxg48BRdTtlXU7/CenWCA8AiK//XuCxCtH8ggtmjo3QZyonc0Y8jZ5gqpwYJPm+fVwUTdAC+RJIZnMicCbQ3f3YwvbyfRFHgrlMzoYjrzbmzQi0K+RC0VlO9ScNR8lwPebZbWnA8/uma/NWq8m2sa9ZiO7WkEyKlcXHxCoEferz07aVzLC+xKeTpJ/UDbP9/c/dbgjTz4jQkndbGFOqJdLo5qNvWXokrjq4LSP+Sow0EKU0C7BWQ8FMmz0KrJGK9U46dG1Zc1nfHNGMcB8G0aJkhB4qaIIBJYi5Qxv8Z5zKcbnzjkb1Fv6utaVLvApQm2oqAmbSWTyRmC2abU/NM69Qw+0JUARXCXar7+tQl+27; 4:f2vMqzHQr2Wj0vHFxa9yRvFBhHX4ndtiee8inORczGefvrqyr5OQ7x9p/hD0+keERO8ZlJWo0h1hCNAse+LvjwKwvRpTRxaqByxBuBDZuXA5Z3AmHTH+PPB3P83onYth+jV3wB+Lns0K9UO1eIWKd36XMpjUo7LCL7142ZIsYry4DgR0DG8w/C8awNbDOQtZc50t6ebMObVQdffNOYIZZMMuUw0ee5tGGXz0ZDH1sRB5x4I3sco0Shn38azz7RRhNmziLohzzBmncPzDsE9nVw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231232)(944501410)(52105095)(93006095)(93001095)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR1501MB2006; BCL:0; PCL:0; RULEID:; SRVR:DM5PR1501MB2006; X-Forefront-PRVS: 0654257CF5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(396003)(39860400002)(346002)(366004)(54534003)(189003)(199004)(1857600001)(6486002)(386003)(186003)(6506007)(2361001)(44832011)(7736002)(105586002)(86362001)(478600001)(956004)(25786009)(16526019)(2351001)(2616005)(50466002)(486006)(305945005)(97736004)(52116002)(47776003)(26005)(5660300001)(107886003)(2906002)(6916009)(50226002)(81156014)(36756003)(6512007)(48376002)(476003)(16586007)(3846002)(6116002)(66066001)(4326008)(316002)(81166006)(8936002)(53936002)(51416003)(8676002)(106356001)(68736007)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1501MB2006; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR1501MB2006; 23:il1MvFek5B9mHN742+qt/gWzLpJclUHJ6IwZzgM?= =?us-ascii?Q?cte2QIkK//Us2yl/nzU6nBMwZoc4764BIJOnfRwHB/g/JabDrGIDLWcHG1sl?= =?us-ascii?Q?b4zWlnZK/5GKITIyDf9kACeVoMgf/CdlkxaRsTN7NYRl5KsNT+Kv1/ixN+5z?= =?us-ascii?Q?1PhyzD4tv25iHqOV2eWF+muXPak6ez/fjCiexshU7uNKSyazBJTGP0cjj8S6?= =?us-ascii?Q?WPOpyzqeI1bR7wfBDaAxKMAeCnkpbJ+mgCX7Vyth7l8hmPdewTUYlz2wsMP1?= =?us-ascii?Q?key4tQjqw1FVDjccECDY4hh7y/GcuQk/x8QO85dqUBu/GkItB3Dg1eWbnR7p?= =?us-ascii?Q?T4uozKrGh5r+xWUo0uPbwIo7Hp7f65uiIuzbBTvGD/nLMztn7SR+RcPw4/Vy?= =?us-ascii?Q?umJMz1YKLK+uQzL1xItdkLNsYCTA5tKjL2FSFQRjK/UkaGGr9P3xt8s5NrYq?= =?us-ascii?Q?bia+1oGus945Ls9WS0fLi7IGfPWw7Ps6sjdKb5EkGfitf1WUyjRJe2a4friN?= =?us-ascii?Q?EMQWYLek9Qr/UkS9rIkFWcCcXKqmz+wsER3mD6IF2Gpn3Spu9LnjUuFVE1Rt?= =?us-ascii?Q?IF8usNkrrO2sjRi4oLePr1+PwV0+VlVuPCwIWmADh+LEtpUevBrl53V4zTht?= =?us-ascii?Q?sbGryN7mKX7VZjHTWHVDf8s/oCuK5nY2G+bn8+5P/FR8c0qPQUCoCjtelUjR?= =?us-ascii?Q?K03H7wpwpHp/IWSxIH4IHF0A/gbETu8v9P6hcfFQHmE9LgbfOnVySS1WlMRd?= =?us-ascii?Q?chduW1Dm8FvCxqR/ZQRIDC09CzxgYAqaTxjx7xAshhWPVmbxka6L7ELqT8L6?= =?us-ascii?Q?tyfzlklvoqTznkttv+g7DEimRWfx36sQIExA7wwoLzhT9U1VZr6dz9QfiReF?= =?us-ascii?Q?NqrHOSqDO1THG0vQd9eddzHR5EAesyG5RtOLlUCcb90Wc9Ig4tzOSRTLHS9a?= =?us-ascii?Q?R673KGbEduIBV/Z++YJNvHGz+KWO4ZnH8AJsp1VuuCDDtl8PCP8m7TmbcK+/?= =?us-ascii?Q?fqXFV8pcZIK9D5TgGR4pzyfBvzAZZHr57lWTClwzIvKxDXsa5FCh/mJD98pb?= =?us-ascii?Q?yaTTVyKzXjLR8z+ksnYYBuhDXeFG3aLZ417Q9vbdNW7Vv3PR+JhjCoSMncwT?= =?us-ascii?Q?Yy1Z3AEn80v/LnCNulZPX8R+Y57Q2r2klvqIwqYcMe5b2DQhO+q9gejHb+Ff?= =?us-ascii?Q?5/qZXr3ufuuyjG9/BYN5Lobr8rf7BWTxX7pp1cULl+Hvp9wl6/ef5E54eDie?= =?us-ascii?Q?BESMeeF3uqa1QAMyIN8o=3D?= X-Microsoft-Antispam-Message-Info: nO+X+OiAFQbYMdLTqcFmh9Ne4cKPES2pWlMRQsV3CAkFrbGdE91jEffZCmqRSSavrZBut/Bxujwf7J+tqOeh9aNksQ56tp221/xCTgcYjCVBcb+UYi8fjCbDdgkwsx9c2aB7NiFDrW5aBSy4uxaBwurF9hi4GRSXlbNDyhH3d2qxp9lHSZqKgnfp9yjL1qqW X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 6:ndhBmtlR2UX8hdI2UVfzk0Ziqt2SxfCFOAWrQHzacOQ8DEwqnhq8Ty/ULG4sZIWh/GZd36BGcP7XvW/00ePo2IcX820qqwUqdwq78TWC8ZXY8lz9gRT/8lbAHyup7BhYeD4cMiVhw7WrkmMrPMt7Zcx81Q3PXvkWUeSse2Bti8xuHyx3nS30RLi0WvNjfnLTUxnC1mqQwj5ff3hocrd0v3KCML0E2H3mmoHvHg8AFXj45Ma98Mkjg/J436zdB8Ml7xBoIR9J8bWIAYeFZzwP5TM9hE6mGgDYvIP3jhKdCVUxgcCFYxJcnLrLZ9DuxbFpD+uk1KmM4wByy3NHYibKsTFzceV6nwoLEuHMPKT8+MruCuBEsbvD4O0S7zt6Xll+GRTryKsu2YPa60SWmeUEWNmeT9ePhuepbtc10/sNOwo8AW6b+jo5r4GyHz5T9qYjlWTxgDijMkGowP3+swd02w==; 5:zWc78laTQK9TLgeRQ4mS6Cgf5y958Qs1mTJN28CwgO/j8uhwKsgX1dgauQtKRLeS3XPhNawf0C1DqUNcgUh4ICN88p9JGazuTgUvVUdejOtAij2+tdRPOxYv8E+O/hj681zq4ZNnr0ChhwySw3BgpQf9Y9RerugnWVtwO3T1Zfg=; 24:H2OBKh0pOuxQs605DWxx+ipPY4utdvCuDfCPPAFlglf5atv6uQ4mR5ElQKGskweGXsnGE1pX5aEO5rdPsnJOewCe6ovgg/3OsRrcRsLVvCs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2006; 7:314fzCHm9sMIJ7AMlLtWz5uEAywv02uGbkGG/ySrw29CcqlzO4dCC66vjkPr+sQu5D5ByKi76GpqB+VlgeBIu9JIhDnKZtRdmYIL7tCPWdRPzz92S9FIHer93FeLqG3QTuwcrtbfJYPNGrJnFsIwHHjhsF2a/qbUVrJpPtSmDJvSCRNz7u4bCRc467fPjXQHgytYwN/GBmJMNLSx14XQWka/sQGbCRKQhfs+AoNYIlW9sAoN3tRkZiXPHI/HhJTj X-MS-Office365-Filtering-Correlation-Id: e75c80dd-75b4-429d-eec3-08d5abacb9a9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2018 19:34:27.7783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e75c80dd-75b4-429d-eec3-08d5abacb9a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2006 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes The cc-with-tweaks.sh script needs to be executed with bash. When trying to run this: make check RUNTESTFLAGS="--target_board=dwarf4-gdb-index" TESTS="gdb.base/return.exp" I get: gdb compile failed, /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: 174: /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: Bad substitution The reason is that the board files execute cc-with-tweaks.sh using /bin/sh, which points to dash on my machine. Remove the /bin/sh part and let the shebang choose the right interpreter. gdb/testsuite/ChangeLog: * boards/cc-with-tweaks.exp: Don't call cc-with-tweaks.sh through /bin/sh. * boards/dwarf4-gdb-index.exp: Likewise. * boards/fission-dwp.exp: Likewise. --- gdb/testsuite/boards/cc-with-tweaks.exp | 4 ++-- gdb/testsuite/boards/dwarf4-gdb-index.exp | 4 ++-- gdb/testsuite/boards/fission-dwp.exp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/boards/cc-with-tweaks.exp b/gdb/testsuite/boards/cc-with-tweaks.exp index 7f94142..1758e24 100644 --- a/gdb/testsuite/boards/cc-with-tweaks.exp +++ b/gdb/testsuite/boards/cc-with-tweaks.exp @@ -44,8 +44,8 @@ set contrib_dir [file normalize $srcdir/../contrib] if ![info exists CC_FOR_TARGET] { set CC_FOR_TARGET "$found_gcc" } -set CC_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $CC_FOR_TARGET" +set CC_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $CC_FOR_TARGET" if ![info exists CXX_FOR_TARGET] { set CXX_FOR_TARGET "$found_gxx" } -set CXX_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $CXX_FOR_TARGET" +set CXX_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh $CC_WITH_TWEAKS_FLAGS $CXX_FOR_TARGET" diff --git a/gdb/testsuite/boards/dwarf4-gdb-index.exp b/gdb/testsuite/boards/dwarf4-gdb-index.exp index 81bffbd..6e02141 100644 --- a/gdb/testsuite/boards/dwarf4-gdb-index.exp +++ b/gdb/testsuite/boards/dwarf4-gdb-index.exp @@ -36,8 +36,8 @@ set contrib_dir [file normalize $srcdir/../contrib] if ![info exists CC_FOR_TARGET] { set CC_FOR_TARGET "$found_gcc" } -set CC_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh -i $CC_FOR_TARGET" +set CC_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh -i $CC_FOR_TARGET" if ![info exists CXX_FOR_TARGET] { set CXX_FOR_TARGET "$found_gxx" } -set CXX_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh -i $CXX_FOR_TARGET" +set CXX_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh -i $CXX_FOR_TARGET" diff --git a/gdb/testsuite/boards/fission-dwp.exp b/gdb/testsuite/boards/fission-dwp.exp index 0414981..82a0253 100644 --- a/gdb/testsuite/boards/fission-dwp.exp +++ b/gdb/testsuite/boards/fission-dwp.exp @@ -30,11 +30,11 @@ set contrib_dir [file normalize $srcdir/../contrib] if ![info exists CC_FOR_TARGET] { set CC_FOR_TARGET "$found_gcc" } -set CC_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh -p $CC_FOR_TARGET" +set CC_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh -p $CC_FOR_TARGET" if ![info exists CXX_FOR_TARGET] { set CXX_FOR_TARGET "$found_gxx" } -set CXX_FOR_TARGET "/bin/sh $contrib_dir/cc-with-tweaks.sh -p $CXX_FOR_TARGET" +set CXX_FOR_TARGET "$contrib_dir/cc-with-tweaks.sh -p $CXX_FOR_TARGET" if ![info exists READELF_FOR_TARGET] { set READELF_FOR_TARGET "[transform readelf]"