From patchwork Tue Feb 20 16:45:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 25977 Received: (qmail 2501 invoked by alias); 20 Feb 2018 16:45:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 477 invoked by uid 89); 20 Feb 2018 16:45:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 16:45:34 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 6C.53.26548.8A05C8A5; Tue, 20 Feb 2018 17:45:28 +0100 (CET) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC018.ericsson.se (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 20 Feb 2018 17:45:27 +0100 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Tue, 20 Feb 2018 17:45:27 +0100 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Tue, 20 Feb 2018 17:45:27 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Tue, 20 Feb 2018 16:45:23 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] remote-sim: Add missing ATTRIBUTE_PRINTF Date: Tue, 20 Feb 2018 11:45:10 -0500 Message-ID: <1519145110-28409-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: MWHPR15CA0044.namprd15.prod.outlook.com (2603:10b6:300:ad::30) To DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19f5a9e6-3a0e-4ca7-655d-08d578815695 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM5PR1501MB2007; X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 3:d/8Bo9lA55kZll0EwADSw0m9WPSJTDPBhkdcnBQYCD7feiNqiE2zwJgeG5la8o58tuPukan4DQb/7Yys+4ksz2kgAisX3eywfg3nmp81pAHsdlHxNtw6wFzyHRgZeeKcPp7vUChAe5nGacAQPSBjwIMnWrGKUCCTiphhdIkWIGyLHVOtE4ZlVpgKrx6Y6NPLnQq0WZAFQPvxJjK6rTWIRf0XpMYg02mvP8+dAmoJMf6VEpbKn6XhDXBrFcJGj2Hl; 25:/wvuK8yUYnglMjDDfb+tfUtzoKWVVvQjUlWSPOIBzJPCHqRNrQdAiFHYlfGP6Q6hd6wPo93cRN/r/L0KUWT9smBVcnxbek+ai0Bue7zhskQfd5hUuzgwA7BwwgYObpRYecHTaFqOiSmile5zfRYi1XNPHVxWzkunuqf6xzx0yCGybWMFmQpCiseLDhJhDN5oGmUc3P3iTnw8xAjuXdrYBiR/fwMZj18tKyHjPcQYL5OzLg5ZlDan5f0QL52KeyFuEz/2E3tBoC4sELisw1LBneg2xqH73k2HIEr7p2cQWwDWZcJT4jqPwMUrXOR5oEBvENrQvkb2CqJkiNdDVwRcZQ==; 31:0HOxzjFsBnQJCJ9sJHoRoEAitO/HYy7ok0viZEHpr31xqcNn3lkkXOzznGLYY5CfqmtPpGg4wjgURbZfwnwUKab3vS06FaKP51SyJ13hKWzlpYidQwITN6jSpguKRFITZAJgBFoLYDzUTNb+GVVvyIO2LKR9ZoYBQz9U3toS0o6WiuAwWbTMN+5zLaTrD8l8JyQPFiEeOggEdNruIzx8Ta+cc6dzW81qh5qkOsHIdMo= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2007: X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 20:ooLrr3GgCtxik6GbxpiN/qdgu711JI0DnYGj1ZTBBaY3QYRP/z8sfRGZDVoCtjPOycj/vRIALej+3fn6iIDVRPDDrWkznfqzuvHUrSj5WBhUsw3CKBIkkvHRodKkHs2rVp1UzMNEkjP2azSTmvO2RUOcQxoWG3HKMHZL3qJ+QTzwrX18ZNq2q06+Cqs6t+Xnzeyv9gUNl4JpTf8ez15ecMs2FHVaJqUYzfTBOyd15zIlghNcn8JXFdCxB9PnobkOcrFiJl0WwJruljWXKjuJpugYROSXggmUoHuMdTa7Qcrelpa+zUun8VsMs7VbvuLC6USlLCUlcwSy9AofLqABx8PB282WVDUBnrOKf376IpDWo1/VeCcnt9RaK8ZJPNvzJlecSFVnsSjvJFxJkHi3ekJqSHtcFUQqROebN//rmbnQ9zzQXuxjqRcCVVmKlKzFo2nN3n/KPC/Lyyieo0gxuQqtTOuQi/UnSPR6ZioHzFr6uptjWrKYuVQ0f5ErxdZf; 4:plqVRhW1IcNPTl5rBSfjkX9skAGhbAZ0GIqidIcWetIqiXN2hQbJswppdoTcCg2kXwbxMYtXrzruZ2RMMyROViajTRRtA1Jmv5TiPhQsSSJYCAIhLAXtO+G13Q/Uc/rXKQLH91BOdWybgCTRjQDbvkFNv7wBNgqHxa/+fjv6M4fUGaqIanyZgGoH0vcimnYIZoKKxZGyZACNwJJe5ms1j1j+7u6IO27j4Hzr8tHPoksM9npgjUISJVeabnF2ML3ou7XmoiOCnvWDAIhmCskX4fYzBJCeJ6rgjgTvFrAI84TS1oXQ3QJe3++9JD8w0ypWhSEevaqMoVB7k70HUo0bl3hgj3XMVH0cXWK7phTawQ0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(10201501046)(6041288)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR1501MB2007; BCL:0; PCL:0; RULEID:; SRVR:DM5PR1501MB2007; X-Forefront-PRVS: 05891FB07F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(366004)(39380400002)(376002)(377424004)(189003)(54534003)(199004)(8676002)(1857600001)(2906002)(81166006)(81156014)(6486002)(8936002)(48376002)(4326008)(6506007)(305945005)(16526019)(6666003)(186003)(6116002)(47776003)(36756003)(2351001)(107886003)(26005)(2361001)(386003)(52116002)(106356001)(3846002)(66066001)(7736002)(51416003)(478600001)(50466002)(25786009)(6916009)(59450400001)(105586002)(6512007)(5660300001)(316002)(97736004)(16586007)(86362001)(68736007)(50226002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR1501MB2007; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR1501MB2007; 23:Lu6Q6Q7Oftu+rnExZZb8cI3/XkSHMIGwcohYuOT?= =?us-ascii?Q?TUPBzkya0m1B00caA3Y9WoYXMOJN1qgdJ2+RKyEOSq7vb8aCBqR6JWI5Jrnd?= =?us-ascii?Q?fIVMbbbZPcOGg4/C0f6yMLRFkPs9znipXLyLW/t4w2Vw53zmcH0gzxst5bPi?= =?us-ascii?Q?EeXwFr0RW5Ra7IGrGVIfdOaCwTyG88MVjJtBx+Uk0lqIa+bEidU3CpV6e2W0?= =?us-ascii?Q?Feqa2dIaUnjFfNA951UOmDwjaVfOrRcX2B39LIBx1P+yFn0PT7wMt9r6zRgw?= =?us-ascii?Q?EhPB27zJ7Tlf12v/7Ut2eheeu92ONi+HWSHT9Cl0huUJBQMcy44JoKxaIZ2e?= =?us-ascii?Q?6r7Tu5NakXjGNRf4u9qTWUBuQqpKxm0TR+G7mXyXIQoJeZ7SsS3xHhaBcI0X?= =?us-ascii?Q?UncV+OL6mIW0PB6QH7XovwgTTdIglrRNRTGt9eMNP6sIwWA6LKjVTgkiSboB?= =?us-ascii?Q?s0h2fs+5Zr8ehN1ARugJZpWVRIvBYps9KY5IybFyCxPW5W3wtorzCeHd+cav?= =?us-ascii?Q?igmAMbcrrisphYrA1rOjl/v6/SQ2jQuRqZowwHCvDsTOfsDU7CGQdswjr7bd?= =?us-ascii?Q?CSEyOgCHCYU75dXKfsejFqdO5mWCD0i8PmYfeW5/LJIwxSTJrfc24Z3EzJWc?= =?us-ascii?Q?/ImUfsQlNF4Fb3BfMuC3pH7gm4gegj3x6j4VV3EX/ToKFe8uEdihBlCIIflc?= =?us-ascii?Q?GhcZTcDOArWCkuKJYslNxWeopJxWkEi8gusFm/Z8O0JCCNpj9O7nxH5Fhj0B?= =?us-ascii?Q?Wn2+0J2KC5xhsu4JgURcQnscdu/51zjhTk/XunpE4J4mbR/yYKolA3MyMn+S?= =?us-ascii?Q?SyrvTWcAChLWdijq5YTMjuOnUOSmra7Tu42PtNHGiPLU+0Zi8K5IRDJk8TwT?= =?us-ascii?Q?Q5P/sRNQZqlE6A5bSHJxOhHiHP0JFzghgzYODfvB3gfLr7hEe3kcG376cITg?= =?us-ascii?Q?JDiR+nVMSCBjuyZoNjPtxpJf3pMr4sWFqtHf4oN5f3u1ZdQYlisGl6iRswxV?= =?us-ascii?Q?b3sxdo4HGhB2Xxq6r+U+zEprljTCP/1gnLqIjH9i5XyoJ1iXeCuYwPhyG+Dh?= =?us-ascii?Q?qd8Zt5h6OowTd0rMx+7yRT5njdjaiWaMR/SI+qscYy4GUCaPjyQhIdsPu57n?= =?us-ascii?Q?WuSMD6pWuGmewTw+Uyk/rznfn0jJ9dUH0YK0Y976mDZC210PXacTGOznOlfR?= =?us-ascii?Q?Uzg262TO3iHvQw+SV+ybBg3XCqqiGeeRp1oHn?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR1501MB2007; 6:st78lNYCPUJovuBkyPSu4U7BJwaOE7YuQyT2acQeLEZc4KCdr0Nsgq7cyA1cokzDzZrAa9GCLYXGckdawbu5pKDc6Qks4wlGwaDE+3xoOHdxHMeHU0hmrG4seDQGHEABrVUZDJdPqrHxKbJfU4qV7j3PYdU802SoyQDnU+/uJdgAcc+PNkBK9Je05pVEHT0vkZLZ/9LE3skOgQpxAB8VqaNaatMZlNP0QRIhrstleD2bTH6O11rgkrrKnAuzCZZ+ThFrP9UjeOgFUaJufCywOl5axB7fh7oiXm0e33MlPUXMPKR2j5kTPs89/DnEMLCaQZ+JU6SYtj5Ri/N3biFPrqDOfdXx41378PtouVyiTYU=; 5:+DH1C9BrizDvSrmw7D2XuDNv3fVBDX6f13XPPwng/rXziaTTDfgvhuHf11kqzqwb5rLeJhsPy+0IiUbtbnQ88vvrOiQmlZs94fGpl/PzEgfBk+LTA8HrYSUjzJCyE9M+cSql2jb0WJN8x9JY8WKBzIfedESxlxPA2KzMczCsObw=; 24:TTtg9LLD0G8/knBR9ICcupHBA9sl9I36OM/msudDV4cTys1qCU5WgWQISF8LxCRgaMcxNOYttbXnoek7OU1ztVVPOG4YHV9JYsg/DTLNS5w=; 7:IR8G/vCFWBmQzZh2mKVhnqQmxPm4p1bspUwxljr3Cqaz2Seg5tb4nWEwrL1ZH5Yex0VRVoPHk4rR45kb3sf0ciIKt3XRae6ifVWM4y6BdrZi28SGjLkN9AO+ii+u5enXJyE92YdfL+ivz5cxfPOsqE9qRdAZXt41qyOLKB3HHe4V5ei49RhU0CEpGSlV+DT1K4TlVDI1MtkyoDwSPYTHkJs9p3MrLiZwe3//ey3iMRpXCBPcKx9BEp3QT3zLI5dQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2018 16:45:23.3570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19f5a9e6-3a0e-4ca7-655d-08d578815695 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2007 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes Fixes: /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:385:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stdout, format, args); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:394:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stdout, format, ap); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:402:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stderr, format, ap); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:413:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral] verror (format, args); ^~~~~~ 4 errors generated. gdb/ChangeLog: * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered, gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF. --- gdb/ChangeLog | 5 +++++ gdb/remote-sim.c | 10 +++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eac1572..9f78ed3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-02-20 Simon Marchi + + * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered, + gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF. + 2018-02-20 Markus Metzger * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp. diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index 2f8fb68..456fa8a 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -376,8 +376,8 @@ gdb_os_flush_stderr (host_callback *p) /* GDB version of printf_filtered callback. */ -static void -gdb_os_printf_filtered (host_callback * p, const char *format,...) +static void ATTRIBUTE_PRINTF (2, 3) +gdb_os_printf_filtered (host_callback * p, const char *format, ...) { va_list args; @@ -388,7 +388,7 @@ gdb_os_printf_filtered (host_callback * p, const char *format,...) /* GDB version of error vprintf_filtered. */ -static void +static void ATTRIBUTE_PRINTF (2, 0) gdb_os_vprintf_filtered (host_callback * p, const char *format, va_list ap) { vfprintf_filtered (gdb_stdout, format, ap); @@ -396,7 +396,7 @@ gdb_os_vprintf_filtered (host_callback * p, const char *format, va_list ap) /* GDB version of error evprintf_filtered. */ -static void +static void ATTRIBUTE_PRINTF (2, 0) gdb_os_evprintf_filtered (host_callback * p, const char *format, va_list ap) { vfprintf_filtered (gdb_stderr, format, ap); @@ -404,7 +404,7 @@ gdb_os_evprintf_filtered (host_callback * p, const char *format, va_list ap) /* GDB version of error callback. */ -static void +static void ATTRIBUTE_PRINTF (2, 3) gdb_os_error (host_callback * p, const char *format, ...) { va_list args;