From patchwork Sat Dec 30 02:57:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 25146 Received: (qmail 20580 invoked by alias); 30 Dec 2017 02:58:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20569 invoked by uid 89); 30 Dec 2017 02:58:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:Sat, H*r:e400, HX-ClientProxiedBy:2603 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 30 Dec 2017 02:58:15 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 3F.A1.27591.4C0074A5; Sat, 30 Dec 2017 03:58:12 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sat, 30 Dec 2017 03:58:12 +0100 Received: from elxacz23q12.lan (192.222.251.162) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.3; Sat, 30 Dec 2017 02:58:10 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] Remove unnecessary call to get_thread_db_info Date: Fri, 29 Dec 2017 21:57:58 -0500 Message-ID: <1514602678-12363-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR2001CA0004.namprd20.prod.outlook.com (2603:10b6:404:b4::14) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-Office365-Filtering-Correlation-Id: 9f15d5b8-61dc-42d8-d574-08d54f312961 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020020)(4534040)(4602075)(4627136)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 3:TWzOPl5tjpICoWg//+MhG2Hmd0eIw5J/JnFgrqrNYq66VjNDMyRYzZPU+WPkjFDi7PYoEfvi9YvxtAQQ1efRAOC1c2s0XGV+eW07e+9bdRzfDSmYqXF/QztHi4OO3zqYfU+/Y44LWo2Fcj5/hcJWxOCA01Q51adXtpwkuy/sH87bkGoX9PlyagHlSCWfkham4Ob6DqrgrgeoAWLXAL9ij2vHGOR6XwoQmzDhVuN694xTAdykcU5adQeU6KwU5iM4; 25:Kq9B2WXOPzZhydBeE27teist1+pryXPHlID3Eas2Bm/g/wezf9j9Y0ZBN2sWU+LQm6rnWDowL/0m/MGrlvdkKvP/cp1NMo0HiKDexheAWZFOyGSmCsDLouc3V0EKubBBcG9RCo/JcWJLqULE9zBxQjcJIaNfZBX9/WCV3eC+GSJlMK9ktDC4pH765xXopnkiUiKt2KrS4MFi8JwcxUfQzbPOcYXXZDL70WJtSnZRInBDXQoBiUIF/3i7Am9LtUONuXvy7CRWYtQwBLBe0ukyl45VZnSsydATfYrzD06AKIi11Oko/LFhIi3MEB9VcCuSH+8+Zazk8VCZxgJ9zeuN408O3pOhwPYZdL8Kzf/7Xiw=; 31:qy+s6j9apmyMKD8GvQsMD18cC2FPp9KwN8/RPOrDkwRdUqV96vkFHJ2szZmkpnGJNjdLK5z+y85KzfWBIS2a/o1aJC3/cRmXng/kqHnf+MB3bNYXJCoF4FTpXTySFisziEYKIHn/w8zg98QQYpkleyjAVjZn6Cg1EvxUcMmnJBThVB+MR0jJdFlIruuIUrpMsRVqIgr8O5U86SIX4PYSR7w1ejj5CY7Hz12gf8MeNM8= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMSPR07MB310: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 20:fnEtDTdWWcOsYuHwIt8SRaOmiQnSr8HLSR8qXpCJOuGcNJidgjW22iJcezWEJgCOjlKMkGPgO0vyH4G/8Qj2NkwS18oDCvD0hbaUQbReQ6WyB7ZVXCXr62L+KKgUkdaYZL5y8CG5UEBB8qs7bFtestGeoVyXCSg+kEblCh7LF0/n1Ez2tBSBkDQQHy5xKwT37H+qKfpAQKSaB1bPO+koBtGMjqr4j2eMCey85/vu7QeM+0h9+W0cjgdYlXWGZqma8s1PyDxw7tFe28SmaVaLhUz5rolDV8HaalPQcIU+wMSb3FJUTHbiOMXKJRh+SpHtE0qEaR81CSODFn+61IaGx+CB815Gl8hbLLHL1koXVfkM4VJWA0Ns7HSKY0jI+KEY83/bXcuHFcL0RriZ1K/4FtKzGXGZymRxB0C7wl8ylhIFYaQDuXtTVlxpXDxGXgmqlV/TCNdwKUpvwGiyeVHs834VCR7n9CylOONLuiCHtpla/XzFCNJiKF7qV1attCsT; 4:Jooi1qxGtcMatQNbny45tM2Afx21inzh4hbePShIbvlA4JF9r0iJHGoxsfQ6TrLI7hT8ch/kHaZ1jM+pLUuBznJqips0fnZFnrWbf8FIHCLmj0vRDOK+RK+IfOpGE2/m55yGVraSSk7MPl3wWVGBu7zD6C85dAuFZ3uA4kkK34qyMYfJ4uvD1x5f4CtKbHBlXN3k82uEioqMaF1jO5K4sOVcsuwvuqsKbElCJpHgGkF1Yr9ASTEVECLPtyhpKB+fC8cGnCL9FCPslEy7rZsmodWgXVgPKVhZ+mmtnCLVjBTG3Hwdv2xTuggrUrqqlZEO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231023)(944501075)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AMSPR07MB310; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AMSPR07MB310; X-Forefront-PRVS: 05373A0663 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(39380400002)(346002)(366004)(54534003)(377424004)(189003)(199004)(8676002)(7736002)(66066001)(305945005)(478600001)(316002)(107886003)(52116002)(53936002)(86362001)(2906002)(68736007)(50226002)(4326008)(21086003)(16526018)(4001150100001)(25786009)(8936002)(47776003)(16586007)(6506007)(97736004)(386003)(69596002)(5660300001)(6486002)(105586002)(6512007)(6916009)(106356001)(59450400001)(81156014)(81166006)(2351001)(36756003)(3846002)(2361001)(50466002)(48376002)(6116002)(51416003)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB310; H:elxacz23q12.lan; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB310; 23:UWfkIvu5b1ngVCRA+QtvYuj8lvXO5pQ63NpX8bmRrl?= =?us-ascii?Q?lWTPPjXIwDmaLakOxILK66iYeaKqb5nmFtGtWGhHPZ3jsMG0eTXO2jQ7f77/?= =?us-ascii?Q?UwX6zemPpEo0+5gCBThtVo6ruoG/Y+ljKsUSfkIpBpWIRoMw3zuR4HwfLQQT?= =?us-ascii?Q?a4TPEeENVMuqTq/7VenZs2ItG/6gspzuL6lfsDMIaw3mm59mIF9YuLfWmNEk?= =?us-ascii?Q?Qlkh0IcQkmWoSzB9xskxpXcGTgJhw3y+GlsNXBscWOAPUAcpmJICt2DKci5r?= =?us-ascii?Q?5YfytlARgpCMcliobgOsbfe0j04bjZVkDWl8QtvtUmutoHwiz9C70n3MhqQv?= =?us-ascii?Q?i7uF/zjh1+INj2VeLX7TEKeaeuwPuC7GuzrD0AKHUfGgkHmGeozazV+oXxNx?= =?us-ascii?Q?HL4I/fKkYHrOsrRBsrySLuE8vYibCfA+WSeEIWC4j4mguWCbYRJ84MgMH3/a?= =?us-ascii?Q?vzJpAwrTFDEFLl4jZIljrqTfIMUUtUPVoIhpj7XJWuQgH1zcDSSPZH/q+hrV?= =?us-ascii?Q?+Uxd787C2jZnu+wloi3B6/V68YFyDpj8ezV3KpIYprYOMc1KQZZFQ58OzFJ3?= =?us-ascii?Q?3/rGTHjtCexCvC1eXsDwwliHmLzH11SfJCealnb7LfLnI4UegXH/XwnoVsvH?= =?us-ascii?Q?Hy/fLmeUTH0AIZ0nFHGpO/o9P4mWeDY6crOpPwZG2l8MSCKcT886jhWCjZue?= =?us-ascii?Q?9ImPepbTyNCt5rn82/wdXnS/Mz3MboEkXYKZlzJp0/2yxQqIj1BAKc9jsZtq?= =?us-ascii?Q?nuurXCY9QnLi7F7OXH4jfiDsWe4ky+jNGrZoUWblMxoRMU/tF19azral1IU+?= =?us-ascii?Q?LY5OZH5o+RPsJWrONDd+LmsYQ+z9SYhdLKZPQbDVM/TzDoB1qdg9SvUdghrd?= =?us-ascii?Q?EN7bOLMyTJpnyon/NdH+vRbgiix6ao8gDUi3VRXC9PxhjVckffKlnjNwJbwq?= =?us-ascii?Q?n1XmqMKBMDeu7t/EMwAQ83EuRLYTdyTZEWcv182qqRqxDP/wnxYhy9NFIvWO?= =?us-ascii?Q?KjOAZZ5e/XGic1eKEGdhv33yCkZxcqaLSp1OmUgTfYBD2xYZiIaQp2ePZH6K?= =?us-ascii?Q?8oX2A7Sh2Nrds4tsn1lJsR67HwAwxI4MNrACQr3lGUIR6cRcU05pOW6w7M+1?= =?us-ascii?Q?bK+AavOul472823Ea3fTgGVOVkno4DhKMI8Bnx8zymK8iZrVg+nSbwvQVSFv?= =?us-ascii?Q?G/6VmtTP0Xic79ekk0cQrqXjTaKuAtoA2rSAzmAk86veyY1yZNpBCVTw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 6:Mcy7VZ95vr9FbWETsn6d7OPMqwfjCQ05jx3dYzQjLKMgL5CnaOvQi2VZvFxha139ysHdoujegD1cQpU6ZpAEy4QyhILTKqd4TpWUGJ4ERZkCwOJYexBD2aIArQuqjH6BYtlj4NB4H0badeoKu02CAAVFt7pFKASmE6ChVuzy5xjSqLc75Rh9ruRFlKedUfbqWg7sUJA9diODAkAsLq78eJ+c5jO45QZN1KKdYN88l01gVFHXosOzOXhJMt26O8gCjxWlhpUrkiKpBPA5lvebuDPlDAWBftfhg1fZm5pWNwt5vNqXv7nu6Hfk16qvFXmWz2WW5f3U1/fkwCnbwaWBh9lecF8XfI+bN8MJ+UDySvg=; 5:y/gm+tVNM480waCYOHozq8gJFA7EI/YUiPEc9n66+oaPgZ7tlnbYbsZQSBVweZUfUX4bKA83sRy/jOqj+VpUsjtmudnFYQbKuu+7Alufjg98mV6L49ju2XW7hvkq33JORTzOHysQsEJtoQUIeVyR++m7FdinIOuBk9jiN3MG5Fw=; 24:+1VjWe+CitTe3oBLc0PXAUFjvaMNiusAZ8KWZyR69l3tb00vn2KffBwmEZOCvjciIqZldJbOYM2cuiqiCV3D84B6DornX8uL9VvgNA7ddx4=; 7:1M8Dz9f5nEZ3rqwwOtXJRF0DMBIWMwhuDTlJxy1sgSBl1XsVfkVfwominMPsZ1AK1uu9pr3YKAmmjFFlt+zxxVlQSOL4ZaRi9mvnsWK/gyM8iQBlQEVLJs3DRgwVjTgZ87BmD8v2GyhF0WIsUY/N8qPKY8XwfSthvtpyw0keO6KORt7sp0WtAH8QknBCFU8JybI2Oy52m+t68mfPYQ4MaL6E4Kj9wfx7lipfKMgP1CPsnCalIjDCdS95M8h5ycN6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2017 02:58:10.2812 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f15d5b8-61dc-42d8-d574-08d54f312961 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes In thread_db_detach, we call get_thread_db_info to first check if there exists a thread_db_info entry for the pid to detach. If there is, then we call delete_thread_db_info. It's unnecessary to call get_thread_db_info in the first place, since delete_thread_db_info handles the case where no thread_db_info entry exist for the given pid. gdb/ChangeLog: * linux-thread-db.c (thread_db_detach): Remove call to delete_thread_db_info. --- gdb/ChangeLog | 5 +++++ gdb/linux-thread-db.c | 6 +----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8555b55..bba278e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-12-29 Simon Marchi + + * linux-thread-db.c (thread_db_detach): Remove call to + delete_thread_db_info. + 2017-12-28 Simon Marchi * target.h (enum target_object) to_detach (target_beneath, args, from_tty);