From patchwork Wed Nov 22 12:21:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24440 Received: (qmail 87331 invoked by alias); 22 Nov 2017 12:21:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 87241 invoked by uid 89); 22 Nov 2017 12:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1489, H*r:sk:static., H*RU:sk:static., Hx-spam-relays-external:sk:static. X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 12:21:49 +0000 Received: by mail-wm0-f52.google.com with SMTP id g130so13511809wme.0 for ; Wed, 22 Nov 2017 04:21:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OdAqdsZTH6yc2xpzrUtOKZKMZw8jvNorTWijiAFZFzU=; b=Gct/8z248/jidPI0+Mm439L8fAi6hYtwvz/aAjdPR0W/RAS61rj/mKKyeqUv4sfB6E 5RpwjnnI5qNxpBuxiO9Q91WoMOAt/8QC1wVdkQQhK86T1s4VypMj3o9XTqMmdGz2mls0 JkZNHdcwI2jA9xWlFpUa/aKw8Xw/DQS7EPoVjiXCd+fNY18qjC4djKnu4Ph3ZUayZEyp YTKsC8joTxu/9QNDpSEN3ZjUy32rcmE0TQ+wrZ5pGicx2xDNa8RXnzvh+ovwMDCALQMt G/xwWGhmJsesIhoQ4bhNiO3D2oZjyM71MmxO8Ubbv+ktAcp7O9vtEz5HurORIOjKKe67 m5Cw== X-Gm-Message-State: AJaThX55ZXn0EX18ddNocmrgexcNvkEzyDlAyLBU0VqG1nHlvtAQjVa6 f5u9mKbasgMW+DVVXk7Gust+LA== X-Google-Smtp-Source: AGs4zMY79y/O9uNFxto/ELRDzgBPic28aZXoAhwJYw3KR21B/5A7lSkhBLETJV/T52opjlIDvYndAA== X-Received: by 10.28.92.208 with SMTP id q199mr3799398wmb.96.1511353307467; Wed, 22 Nov 2017 04:21:47 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id s30sm7273691wrc.89.2017.11.22.04.21.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Nov 2017 04:21:47 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Cc: msebor@redhat.com Subject: [PATCH 2/2 OBV] Fix build with GCC 8: strncpy ->strcpy Date: Wed, 22 Nov 2017 12:21:40 +0000 Message-Id: <1511353300-11688-3-git-send-email-yao.qi@linaro.org> In-Reply-To: <1511353300-11688-1-git-send-email-yao.qi@linaro.org> References: <1511353300-11688-1-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 X-IsSubscribed: yes Recent gcc 8 trunk emits the warning below, ../../binutils-gdb/gdb/python/py-gdb-readline.c:79:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] strncpy (q, p, n); ~~~~~~~~^~~~~~~~~ ../../binutils-gdb/gdb/python/py-gdb-readline.c:73:14: note: length computed here n = strlen (p); ~~~~~~~^~~ gdb: 2017-11-22 Yao Qi * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy. --- gdb/ChangeLog | 4 ++++ gdb/python/py-gdb-readline.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a9e7528..63ae72e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-11-22 Yao Qi + * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy. + +2017-11-22 Yao Qi + * cli/cli-decode.c (help_list): Use memcpy instead of strncpy. * cp-namespace.c (cp_lookup_transparent_type_loop): Likewise. diff --git a/gdb/python/py-gdb-readline.c b/gdb/python/py-gdb-readline.c index a02fa8c..ab14b8c 100644 --- a/gdb/python/py-gdb-readline.c +++ b/gdb/python/py-gdb-readline.c @@ -76,7 +76,7 @@ gdbpy_readline_wrapper (FILE *sys_stdin, FILE *sys_stdout, q = (char *) PyMem_RawMalloc (n + 2); if (q != NULL) { - strncpy (q, p, n); + strcpy (q, p); q[n] = '\n'; q[n + 1] = '\0'; }