From patchwork Mon Nov 20 16:34:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 24372 Received: (qmail 102188 invoked by alias); 20 Nov 2017 16:35:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102145 invoked by uid 89); 20 Nov 2017 16:35:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1335, 9313 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 16:35:08 +0000 Received: from ESESSHC014.ericsson.se (Unknown_Domain [153.88.183.60]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 57.FE.08439.834031A5; Mon, 20 Nov 2017 17:35:04 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.60) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 20 Nov 2017 17:35:04 +0100 Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Mon, 20 Nov 2017 16:35:02 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 01/19] Remove usage of find_inferior in regcache_invalidate_pid Date: Mon, 20 Nov 2017 11:34:25 -0500 Message-ID: <1511195683-2055-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> References: <1511195683-2055-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: CY4PR03CA0075.namprd03.prod.outlook.com (2603:10b6:910:4d::16) To AMSPR07MB310.eurprd07.prod.outlook.com (2a01:111:e400:802f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 480a4796-7e39-49aa-a2be-08d53034a6a6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258); SRVR:AMSPR07MB310; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 3:rrmHx4ssod06JPUXP8WJuAnIuOpFQd/TLq7aUfJ7PCUmm2KSEbuL30B/N2s4AZ7eDpW7tTsPvK4GKgi0MEpQ55Eo9yq2VBzMbdEXI3/4P/NnzKmrKqxDVJ3z7qV4J8ckxkxfKYOUSIDZjt1l7aXZhK+cyVR5PmgE/xDcS5/yu0HjSN47BC4TjBNiF7v43wONRMmPRPmA/aPCqk5YqywZ1Tt/wZitysK1rAGLCBNP2od6kFeatYf7jpeZBXhQBsU5; 25:tofVzFkbSkGUJQktEhT3nLmn9kEedxRo27edpygCJaAL5QPxfFUlLmiLzI0yJs1c+QZlY0DVH4EuDNKC3JJsM+DjziwWK65lqzmlAgHv296DrsMJ64bQxxp+znh9PJQ87uQvWrNnrWE7WzfU24SNkP7zf4GM9f+2ppBnmmunPZGF1YdYZlLJA5leXtdMJ5k+eXG/zY50HjJO/fjksvoFYeE3G9HvavWpgZ+SbRSe7IPLbH8v++MBDyaecNLgZ7h2o3RlDk1MAj0AJAofsj0u671cMT7ehURvDlvSMeqCPiBDhi80ji1ic/5SQcBIkDjtIIf4ZG8vtnsPfKE+3Jn3EZ/PgJ5oq8OpxDwZETDRFw0=; 31:te03WOGBppn+Vnef5N4faHw2xMfkxAeCBHmhuSI8B+XlRklzaGN3ASgrqoJmmWDo91tgbWpB3HZQHbP9L7vSalZzCSitoWpOlfvpLm/AsH0Rvkknr9fx2F/kEBaBIu/jFLdpA8YZNAJlkOdjfkk6TmnVBgMCxb/EeuEf933TjrJ7eozw5rpKlNYGKhqLC5X9tYm8QJFfUv223fnDEtFOGhFPW2n5+EyoIHkPXRbMng8= X-MS-TrafficTypeDiagnostic: AMSPR07MB310: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 20:PIp2b/RtZ037dVXpnkUV32JkpF9qz1VFZOIDwj86QOHQ/AIIjCYgwHoV1/dOucmMp0FebIvQ/GM1ef5zWfBzoirTZr/N5SPYSqwt46Wj+v6R80r84hSR7tiBzlWYFHoxid2Nasu5HHg1CLCa1LOCrlVw6LjkoPcglFp+QhPmUZ9LRw3echvK0bDZj9zLPy356ijj7vJXVivBkp03UnLwf167gauHdChruYlx6yDWB1MLUgzag4CtK3aBt+MESTxRs9m2W8Fvw8xNk4Y4GMPrCVKnoVThqKfBXYIzE8BMMkOt8vjE3ZPwP2a2nxqt0WzKuu1J6URpQnXTnoPDCWONKXiTmLj37IOdmNozUYzMRoZuLdnqrTxNF7j6/GcKHZqGuiIlQ3x4Jnpa4Vc0vAYlKAWRVIVqzUR2eyUqZifUyU5jTGlsKiX7e/fWdJhpVvoSG+EkgMLdxfZoU7PQ4FFa3NjUJ0s1Mz/skxj4X8NKoLzff15ZI3u2nh0TYeNRIlU0; 4:XkcBba4EI3csqr5xjVNLDWLQwmdZdwwu4xC/N4q30mHUkHGdPjDrmkuNL90UXvn2T8sGwIeixN8cVwRZSN1ZUKixsBSRWTqK8clqpzAsFSO6FegLdVYI9nV9wP16tRDiOWIzoO7Ce81XT3cj048Fxrh3qMF36PdWOF017JtYvqLk3dXsm0v1+PONSo847dYNW8MeAs4ZcGsCc1CtyFtrynf2zrt/jt7JbIoWE9x7b6yGNgfWjusJjdKFIQ1NR3JqCxDrSnjoswB7sFPFOl20OywKDyB6skllNSavef2MgkhIVhm+287ahmzN6tPaHN70 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(3231022)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB310; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB310; X-Forefront-PRVS: 04976078F0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(54534003)(3846002)(97736004)(66066001)(5003940100001)(33646002)(16526018)(50986999)(76176999)(6666003)(81156014)(305945005)(7736002)(81166006)(6512007)(5660300001)(316002)(6506006)(6486002)(16586007)(6916009)(2950100002)(101416001)(8676002)(2351001)(2906002)(105586002)(36756003)(47776003)(86362001)(50466002)(48376002)(50226002)(8936002)(106356001)(68736007)(2361001)(53936002)(478600001)(25786009)(6116002)(4326008)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB310; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB310; 23:qRZgQFqFLUNH7e2nhN/gV5b2eYfzmQZ/cofGUbAadH?= =?us-ascii?Q?nVFfSpzIH+9Y1r9zfkjPWQs412x29D1DWAgUzk6dkw7p8VgdFsq+it8+J/o7?= =?us-ascii?Q?D8KEHvb2TOxEbm0kEOapJqUDQwG0ZuU0ikfGK9l+SFfpCf6GRyoAZa4N0PZu?= =?us-ascii?Q?Rr5ydpPTlFYTOr0R5YL6JS8NJBpx+Z8zci91hyay59ws2+yEWh7UPdOiWYEm?= =?us-ascii?Q?Q6ASjYYZMuzQcu46gSrOyWHDfkXhSBublO6bYoXpcMRICgGVna59vA2SjPib?= =?us-ascii?Q?cTB8gULHFPetWklMfRltvqOtKOUFAYw3t00G6DJ9dC5xDLGooy5skQlfThEe?= =?us-ascii?Q?yqQ0evRmn8GvLjmvLAJcIVeGvSxkimBH91H9Lik3oYkAH1NkdCATevp6+0jM?= =?us-ascii?Q?+XYJ9MfBa/gvAbp7AU65mhFp5W2omQm+LhuhZc8UjN9Ov7vF5ru/HBytCeXz?= =?us-ascii?Q?UC0h8nwIsmXT4wvmYrxMZHjcD61mrD1CK25TATt2Oxi9myDHVRYdzU9PsoGx?= =?us-ascii?Q?4EtyWfwr0U1ZpG9CRYComRiU5SlkRjGsvuOYdeMSMfzctj8iLFkhoK/yciZh?= =?us-ascii?Q?DqC2TuSAES+EBlaJSG9IJe0CByEbLiXYIaNYxIL0iOkfMTRFOLrPQD3NthSY?= =?us-ascii?Q?zQJiNRWQLuHjL8lY1wKgIyXqFqtAYl60yMtjJPFkZ1oN6QgInv0iKqBl8oqn?= =?us-ascii?Q?V4xZpLbI5pKDUIJty+xPcwfFPawrPykfvp3zPkNn520Ic+VpyzVCrNLW5jiw?= =?us-ascii?Q?AXy9ZX6nug7oJ3vdHmgWrSD6EpMgV+Hm26RMULIkypJlvTcGAufHgJ9yoBp4?= =?us-ascii?Q?Y5MehAmGwjMEAEq9+gbbNf2Qhjdk/cKi5BYgmHArhIWbtF+LWomvgGD1S9va?= =?us-ascii?Q?fITKbDjCOCji5GzF+t2SXrclMLIuWBrj498ndvS+VrJiUDbaAQhXBeJxVdXz?= =?us-ascii?Q?bzBvoZJEkPnZraJPZBCI2gHsmRWluUeTleCfOxYaP0jUQ3HJ/1Y56xCORDOc?= =?us-ascii?Q?Tbho76LJIWb0rzLejMyRQeF7ITYaVrrqnV/S6A/geeZUO5kjJ+9kkfEzSctU?= =?us-ascii?Q?LifYEmS49a2VjZhuqFjOvuLwTdVw6DRiNfJ0LdmE2wYHEio4lIsgPR5PauAA?= =?us-ascii?Q?Nr4KI5ZmfPPJbD2U0tPiAM6B2LVGnm?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB310; 6:piVKscVaP9S6y3B4fA5DJZkOioJl9U4lqBtwQtUhb/7AGHtyhhkD7Di2mCxzReAVRK+SzvSWwnFUXQzHHhzD5qT2IFjLV0w6o6vUcUhH1qr+IrJ7NRd1+x41XsTR8jK3jSDe9cCg/pSwaS8+wEy59VdssV4b3QYGPxMlk4k2a5gJWXusuwR3+XiiUjiXs9wfYUniHahoFJxM4dKLPhrq9XTOwPmjpWdVslJnSKlDmB+5nilzra2YQiGl0jjDK+DR/fX8lF+zSDzWzCYjCrYN9YNBPDbrVKyP26E4bcAcp/b9UH62PEEv5+LxYqaHUvQOvwSPo0tXcEMV02ta55iSx1Bqnojpcml+2MFOEicc1eE=; 5:a91z8GdWIdKQ28ANqQgb2b3JYB7mqQ4EVPuAb+KuTNUjokB4o0esPSYMYaObgrYEMRnVTEXYZbgWtprSO5wp5MdIDXNqAfuwehQ9QT0gm4PFDmVqHH4zXRwXE16TDJnyzMnMvkUREOPzIf9UnQYH0VyFE58EeM+fhrzT5dGmciU=; 24:LbC7d9jwJpZLePpJu64sbECShOkX1akmk1uFqMA9mRzIdn8hLCV03XFKdIQ3uLWvf/TAapn0DbXFchP+mh6gffZqez8y5eU9++qVnkEfU5I=; 7:fXgC68a/irlYtIeJZUU/GOnXD6rDb8EeKt0QuTY6jkaAHm+uB7ycKOshZGOxKv4/WL6T4B+mtNEsti7mm5357QNygIge+2bE5JdrC566ceL+7qCT3N3TJ6Ewx1bCh1ZmCzZyKZK7KOA+JFCdbW5Igxq/4wNT6klQgNC5jr1dy15R71zzmzJfaGFRpZZj7GuHBw0sei2j3thUMHw+Gn98dgTnSwb4bmy0aC/5rAOVR8Zy0FE0+fGbTGsMrkVfIK9S SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2017 16:35:02.7195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 480a4796-7e39-49aa-a2be-08d53034a6a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB310 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes From: Simon Marchi Replace with for_each_thread with pid filtering. regcache_invalidate_one is not longer needed, as it was only used to filter the pid. We can call regcache_invalidate_thread directly. gdb/gdbserver/ChangeLog: * regcache.c (regcache_invalidate_one): Remove. (regcache_invalidate_pid): use for_each_thread. --- gdb/gdbserver/regcache.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index e45e60e..5f71523 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -93,24 +93,13 @@ regcache_invalidate_thread (struct thread_info *thread) regcache->registers_valid = 0; } -static int -regcache_invalidate_one (thread_info *thread, void *pid_p) -{ - int pid = *(int *) pid_p; - - /* Only invalidate the regcaches of threads of this process. */ - if (thread->id.pid () == pid) - regcache_invalidate_thread (thread); - - return 0; -} - /* See regcache.h. */ void regcache_invalidate_pid (int pid) { - find_inferior (&all_threads, regcache_invalidate_one, &pid); + /* Only invalidate the regcaches of threads of this process. */ + for_each_thread (pid, regcache_invalidate_thread); } /* See regcache.h. */