From patchwork Fri Nov 17 15:22:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24309 Received: (qmail 118653 invoked by alias); 17 Nov 2017 15:22:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117820 invoked by uid 89); 17 Nov 2017 15:22:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.128.194, Hx-spam-relays-external:209.85.128.194, sk:break-i, UD:break-interp.exp X-HELO: mail-wr0-f194.google.com Received: from mail-wr0-f194.google.com (HELO mail-wr0-f194.google.com) (209.85.128.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Nov 2017 15:22:13 +0000 Received: by mail-wr0-f194.google.com with SMTP id z75so1066210wrc.5 for ; Fri, 17 Nov 2017 07:22:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Cza1xZZiKtMXqN11AhMfQC46YlLxBVCNtZ7vuAGdO/M=; b=GB7rXwvcZZSj/vG2W0hl+boE7bsZGq1O/Gji/bXspb6E8IViSmPb7K/vSPUsxR85HG Pnz9meqdnHeE+mTChC3W0M6NQDuqvCXXYCgYnEfURNgS28+CEXVOAQEYpOEnyAQHJa4n vqPb+P3fZ1GoJY9P8go2KznrGDnWKiv6akVkZWd7YFUx4jfioPd8NApGrwE8ae5+En95 eenXQDKzkjZIq66hPqBUFJTj1peV1gtbgvHpIkG34LdRnZXCeJgKttBqmlmT5PZDv8W6 tREeKCYCrviOdaV2l8t7/7aG/ENXdXqW9ER4V2X5K1MmVArlWW+KAwcePkrqRAXdbmMh iYlQ== X-Gm-Message-State: AJaThX6G+/N5DiPec3hnVGsvTnzKjpd1Rod2S01S6CGnUzqX+htL+z1N IPDBMS8NtoTFvpZnsfRAWB/mlA== X-Google-Smtp-Source: AGs4zManQxxMlmqfrCoIyEB1aUD9NInnZ2dba4MkuzqiPL0nLDOSlV6hl+VEzQxcnNVgAVlFKkRmPg== X-Received: by 10.223.185.33 with SMTP id k30mr4802163wrf.40.1510932131089; Fri, 17 Nov 2017 07:22:11 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id w5sm2009250wre.18.2017.11.17.07.22.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 07:22:10 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] [testsuite] Pass -pie in ldflags Date: Fri, 17 Nov 2017 15:22:06 +0000 Message-Id: <1510932126-11752-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes -pie is a linker flag, it should be passed via "ldflags", instead of "additional_flags". Otherwise, clang complains, clang: warning: argument unused during compilation: '-pie' gdb/testsuite: 2017-11-17 Yao Qi * gdb.base/attach-pie-noexec.exp: Pass "-pie" in ldflags. * gdb.base/break-interp.exp: Likewise. * gdb.base/jit-attach-pie.exp: Likewise. --- gdb/testsuite/gdb.base/attach-pie-noexec.exp | 2 +- gdb/testsuite/gdb.base/break-interp.exp | 3 ++- gdb/testsuite/gdb.base/jit-attach-pie.exp | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/attach-pie-noexec.exp b/gdb/testsuite/gdb.base/attach-pie-noexec.exp index 82e6af6..56a42cb 100644 --- a/gdb/testsuite/gdb.base/attach-pie-noexec.exp +++ b/gdb/testsuite/gdb.base/attach-pie-noexec.exp @@ -20,7 +20,7 @@ if {![can_spawn_for_attach]} { standard_testfile .c set executable ${testfile} -if { [prepare_for_testing "failed to prepare" $executable "" [list debug "additional_flags=-fPIE -pie"]] } { +if { [prepare_for_testing "failed to prepare" $executable "" [list debug "additional_flags=-fPIE" "ldflags=-pie"]] } { return -1 } diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.base/break-interp.exp index 3a6d9a9..460e5f6 100644 --- a/gdb/testsuite/gdb.base/break-interp.exp +++ b/gdb/testsuite/gdb.base/break-interp.exp @@ -625,7 +625,8 @@ foreach ldprelink {NO YES} { lappend opts {debug} } if {$binpie != "NO"} { - lappend opts {additional_flags=-fPIE -pie} + lappend opts {additional_flags=-fPIE} + lappend opts {ldflags=-pie} } set dir ${exec}.d diff --git a/gdb/testsuite/gdb.base/jit-attach-pie.exp b/gdb/testsuite/gdb.base/jit-attach-pie.exp index da77a4a..eb484a3 100644 --- a/gdb/testsuite/gdb.base/jit-attach-pie.exp +++ b/gdb/testsuite/gdb.base/jit-attach-pie.exp @@ -21,7 +21,7 @@ standard_testfile .c set executable ${testfile} if { [build_executable ${testfile}.exp $executable $srcfile \ - [list debug pthreads "additional_flags=-fPIE -pie"]] } { + [list debug pthreads "additional_flags=-fPIE" "ldflags=-pie"]] } { return -1 }