From patchwork Wed Nov 15 09:12:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 24248 Received: (qmail 37542 invoked by alias); 15 Nov 2017 09:13:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7717 invoked by uid 89); 15 Nov 2017 09:13:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Nov 2017 09:13:00 +0000 Received: by mail-wr0-f173.google.com with SMTP id 4so19877555wrt.0 for ; Wed, 15 Nov 2017 01:13:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=xWGB8upDLHM9Q1i8FcD19rVOOm4Pd0SM9XEzT3tmrOk=; b=l6U2haHMYsNPvOYs3A/hWVbbiBUe60j43sycJ0alGQ3TLZd6AQplEg5dfbWjUEbnwD 8X96YRkDeoWG9Tnq1OkI7Dyh//OAl3jm895tw10FiKvc6lmMivpCJHPh/Yo1uUNvIb49 SuXf4nuXaaeiN+uX4l2yasOdLFTRvnPtehkGym+LfGi13ZOdkIOdMZbFDGJB2bNqIPi+ aPST/GtRMpdUjx0PgB34pj1YBF9R+jrLtjh+me4e9mgTrxaMvymQyxY65HWOWQ2198dY NwRkjczjwRFPu5UREDqKyJnrL/ovPaSWUFJIQmdWebabHrMtaLYmYmp7Yl6Ov+nRNDtM JOVg== X-Gm-Message-State: AJaThX7N4/+/kqnPo6cf8tNVM8bIbLiYBAY68n2F4bazBoKTuuMzMOaA wfp+Fd93rLFv7ZFcOKVeMA4UgQ== X-Google-Smtp-Source: AGs4zMYNXHBCmkr2NvoIsxcIm9+rmWLVcNDbBkHZhaHYpl0FONxBOJujNL+89xHXjDZQzcmoionZgQ== X-Received: by 10.223.151.141 with SMTP id s13mr1029125wrb.168.1510737178184; Wed, 15 Nov 2017 01:12:58 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id k69sm16954826wmg.45.2017.11.15.01.12.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 01:12:57 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 3/3] cooked_read test for readonly regcache Date: Wed, 15 Nov 2017 09:12:51 +0000 Message-Id: <1510737171-15435-4-git-send-email-yao.qi@linaro.org> In-Reply-To: <1510737171-15435-1-git-send-email-yao.qi@linaro.org> References: <1510737171-15435-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes This patch adds a test to check cooked_read for readonly regcache. For raw registers, cooked_read get either REG_VALID or REG_UNKNOWN, depends on the raw register is in save_reggroup or not. For pseudo register, cooked_read get different result in different ports. gdb: 2017-11-10 Yao Qi * regcache.c (cooked_read_test): Add more test for readonly regcache. --- gdb/regcache.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/gdb/regcache.c b/gdb/regcache.c index 3bc8608..b926194 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1865,6 +1865,82 @@ cooked_read_test (struct gdbarch *gdbarch) mock_target.reset (); } + + ::regcache readonly (regcache::readonly, regcache); + + /* GDB may go to target layer to fetch all registers and memory for + readonly regcache. */ + mock_target.reset (); + + for (int regnum = 0; + regnum < gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch); + regnum++) + { + if (gdbarch_bfd_arch_info (gdbarch)->arch == bfd_arch_mt) + { + /* Trigger an internal error otherwise. */ + continue; + } + + if (register_size (gdbarch, regnum) == 0) + continue; + + gdb::def_vector buf (register_size (gdbarch, regnum)); + enum register_status status = readonly.cooked_read (regnum, + buf.data ()); + + if (regnum < gdbarch_num_regs (gdbarch)) + { + auto bfd_arch = gdbarch_bfd_arch_info (gdbarch)->arch; + + if (bfd_arch == bfd_arch_frv || bfd_arch == bfd_arch_h8300 + || bfd_arch == bfd_arch_m32c || bfd_arch == bfd_arch_sh + || bfd_arch == bfd_arch_alpha || bfd_arch == bfd_arch_v850 + || bfd_arch == bfd_arch_msp430 || bfd_arch == bfd_arch_mep + || bfd_arch == bfd_arch_mips || bfd_arch == bfd_arch_v850_rh850 + || bfd_arch == bfd_arch_tic6x || bfd_arch == bfd_arch_mn10300 + || bfd_arch == bfd_arch_rl78 || bfd_arch == bfd_arch_score) + { + /* Raw registers. If raw registers are not in save_reggroup, + their status are unknown. */ + if (gdbarch_register_reggroup_p (gdbarch, regnum, save_reggroup)) + SELF_CHECK (status == REG_VALID); + else + SELF_CHECK (status == REG_UNKNOWN); + } + else + SELF_CHECK (status == REG_VALID); + } + else + { + if (gdbarch_register_reggroup_p (gdbarch, regnum, save_reggroup)) + SELF_CHECK (status == REG_VALID); + else + { + /* If pseudo registers are not in save_reggroup, some of + them can be computed from saved raw registers, but some + of them are unknown. */ + auto bfd_arch = gdbarch_bfd_arch_info (gdbarch)->arch; + + if (bfd_arch == bfd_arch_frv + || bfd_arch == bfd_arch_m32c + || bfd_arch == bfd_arch_mep + || bfd_arch == bfd_arch_sh) + SELF_CHECK (status == REG_VALID || status == REG_UNKNOWN); + else if (bfd_arch == bfd_arch_mips + || bfd_arch == bfd_arch_h8300) + SELF_CHECK (status == REG_UNKNOWN); + else + SELF_CHECK (status == REG_VALID); + } + } + + SELF_CHECK (mock_target.fetch_registers_called == 0); + SELF_CHECK (mock_target.store_registers_called == 0); + SELF_CHECK (mock_target.xfer_partial_called == 0); + + mock_target.reset (); + } } } // namespace selftests