From patchwork Sat Oct 28 03:38:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 23948 Received: (qmail 69111 invoked by alias); 28 Oct 2017 03:38:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69097 invoked by uid 89); 28 Oct 2017 03:38:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1302 X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Oct 2017 03:38:27 +0000 Received: from ESESSHC012.ericsson.se (Unknown_Domain [153.88.183.54]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 47.F2.09869.0BBF3F95; Sat, 28 Oct 2017 05:38:25 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.54) with Microsoft SMTP Server (TLS) id 14.3.352.0; Sat, 28 Oct 2017 05:38:24 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.lan (192.222.251.162) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.3; Sat, 28 Oct 2017 03:38:22 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] common-utils-selftests.c: Add ATTRIBUTE_PRINTF Date: Fri, 27 Oct 2017 23:38:06 -0400 Message-ID: <1509161886-9902-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DM5PR04CA0039.namprd04.prod.outlook.com (2603:10b6:3:12b::25) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59924104-948a-4a76-795d-08d51db55762 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603199); SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 3:qD4sFOBcHDmT89IjglfbDNgFf9dAR67NJT7yCamiVJw8w6op57sOrlsDTwbcrYaOL7T69dHiHJnDcbuON0Yxo8gb8e+AEJ9Tpl0UCT1nRVSbbkKdSv4BNLWGggjsNoGWz+QF5WjznaitVGIWwTPfzPaZzXKMZk/VzDTaK5XksWQznJFytTYXBlYzaiE6ubBnZUZtuogS992AbJIZYVOY77jnxQm2XBc+lcPRz4nOw0UvWQNWAw4BOObg+7YZjFEh; 25:PF3drQZXB2+/XA7mgilBdiuMe88tPubKeIwQ98FHTM6qwdS9kxFlC5ufW6x8NR2Pbe25qbVUSvz/sUVgKPniys9A5ZuxVTpgxOqGr0pVlMf3TOVUN+c0LpyrOI273/mWxW2sZQFwV284ZuVZAiBO6HMTg0tRsW6eUKniWG/2MMu1bKGkDYjAHntHg64UERZzcKgjuSgzQwKmAxfzOBDuK3HLVF5rj9u7YYwymTz9YjFRitAdnUGAGhAB2LWtR2KjM91wJ5ckPPusgr3PTPNY4uoczPLx7hEBNZWDFtmi6E/0aquLYqnucfBLAdJegUjwULSxWJRVVq51e+nDpwc06zSehbpiF72/kkPpNeim50s=; 31:X1HgudDsjgVBOVqo+zZMtKB8zOnNCdVLyRZYFIOSM4eRGn9JwewUUxewVK/MWoI29k/az3HWu95ZQ6caxsptpli6BTNF2byJtCW32zw13bAoeXkD1QLyuL25LJMOuraNzMNhFQRAqbDKqNeIp5akyCmTh9iZODJPCL43SJJcgKjV0T2DXKCEneqaDU4XgGrQUHB9tIMT5vr1jmUwzSVIGyXr5Xce6atuH4RA92/ns+4= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 20:CcX/NhztYD/J50V2uBdkA3MeO8gHLMSVfoMCm+gnU3S6sDueERxd7DWkmlDCoqwxaUD5dy61uzjPsc9BqkukWhHZ9gVpreP6dBLSB2p+vW1F9RFgvmX4bYskafr8aqWK0qqOdtC7cUI3RDRhONa7EYnn1juKzfUkTZluUb4x8rTkexwqu4QSlX7BuMXxMQtafIZPq27Cfx8LgYRP1FiVcar7qdPkuCyCOknDbke5KHYUy/WJk5iK+VUpEgEoIakoRShHOtLPDoMnip9QWBBd0RJ6B1iOk6v0s89z/g/gCxJwMuXxq00B5Qp/QyxtidJSoVVpf2oYKVzXUEinqL/B85wPWUyYhAsWc7HFketFRAtchXnehRYuKM27/ZPFiEqI1/FM5aRuhe/Nk6a24PR0ABMvcOnnypJUxzMvvIFdjurXtYSO+a/6Uhh326f0HXP0CNeffIZamEGo+TZTF4AgmYwMcbfj3D/lPPhccwb6Dm8pMsOAgNrnG50S6j3E3ysg; 4:rT3jjXemez+bPBj5zyqIX1ifkeJCHrQHFmjbkqIW/Nvf7KCDfywTfi4ZaU4O4eS14y+nDg3X5Y2eNlVhRDlOHbGiR2VxlpO70Hns4RNOGvwTgcijb/CT7kWsrsLv8CeAor9cerJiNnSmyo+hiNzxOxM3MW4LIgmFJvP/je8jrj9VK/1OOUZAOiZe4y6FNbLVol6nS5d7LSJTMQCpMCw9gmozZPpBs/sjiJH9rTUnqtzzoH0NWW7p95N49HSy414pXLalPU9kSsQUxh4RPPq5aH/RUg7IUC6cfvtX38pJ2dlNd0L5VHtfZ8qc2A3xUr6r X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(3231020)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB312; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB312; X-Forefront-PRVS: 04740D25F1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(377424004)(54534003)(189002)(199003)(68736007)(6486002)(16586007)(66066001)(4001150100001)(53936002)(106356001)(69596002)(47776003)(189998001)(6506006)(478600001)(7736002)(316002)(50466002)(36756003)(21086003)(2906002)(48376002)(305945005)(50226002)(5660300001)(6916009)(6512007)(25786009)(8936002)(6666003)(86362001)(50986999)(81166006)(81156014)(8676002)(230783001)(4326008)(101416001)(6116002)(107886003)(97736004)(16526018)(2361001)(105586002)(33646002)(2351001)(5003940100001)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB312; H:elxacz23q12.lan; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB312; 23:C2J3nrFmWNMdQqX9NlaaCNWi0ugl9BOZlnRltoVTkA?= =?us-ascii?Q?ZgikoK60DawN0aZuZVAEsqjFgREE37vMrjpzq/PPYzCFDEjsPpDRnamMKqK5?= =?us-ascii?Q?1SIexXi2nSYTuIJBNKT4LxgRnbexgS/nfh/nn9kosVSnYXS9SZgtnQNj1SOi?= =?us-ascii?Q?u0XzNJXj1JF0HQ/HkU2Miebz7iRMGGAAzLkgN/yPU3aVVEdynLiBwNsqHdV0?= =?us-ascii?Q?UcKXkhOJBl3p+FalnZg+1xBz89bQEmoKU15Jvaome5oAVbulAxVMzm07FX/d?= =?us-ascii?Q?f+PzbCGG0j/f76rY1b0o6PikNP163qpORYLSblNJQM7nsw0aXk9b9nI2/jk1?= =?us-ascii?Q?WiV/adEKaPNnunSYhxZcDhqMB+5ZB6T/fGCGChM4dKPtjLOlMpn/JX6x7eu3?= =?us-ascii?Q?ZGLqTfcjJLEUPQSJsHnoHl9526u/3n+BVOneaoBFjh2OfaScq5BHcr2TMgIn?= =?us-ascii?Q?ursgzJrxYdOCSjf75ai6W8fNsh+4KEhz6gdnv+SdWHYLn6WzKkt17O4Q7TC2?= =?us-ascii?Q?xwg73iLcQOZU2k/rTcNXC22F6MjGFstAtan/84dWakvKJUwd+ncFsQckHe99?= =?us-ascii?Q?BFbacIjUfKB+hXYiSaacCftpzXpMePRfeO7XexyQhv9CSDe1SyEDNENSJai0?= =?us-ascii?Q?mt2BeLcu1LPNAZCLXJC0j0a1zqgqMVcOOi3ONmdMNghuhSNSf1jyswMbR5OO?= =?us-ascii?Q?WUw+UI7qowElwzk4gUkC+leuFx/lhQ+4DuwOh/OqsDQRhfeOsSWBu9t4VhXL?= =?us-ascii?Q?FSsdWm04OSefahN/zIE7ROCV46Sn2D9pSZ6HZycFyUuu/Fmt8huHeO1VDPC0?= =?us-ascii?Q?afnnoSQO0V5VaCHjbVfJLObaliqW4+5KBY0ZON0eIuiEy/pqwl0qiBLLbb19?= =?us-ascii?Q?sUOxEviba5ABpUVavtDYBstxBuhb7hWKYgjta4MOWFLbOCzviAHGVMvHCGv+?= =?us-ascii?Q?lYg+iONyIDti3UZIuPdr4faAow2qIm1zHG/i2qn7foFg2i5ybcK9hbf204cN?= =?us-ascii?Q?pPdrc+dQ0AP+ynWAPGRe/cuOy9O8nTvXx/lsZHkg17gkE7+7AaLV09GUxvOm?= =?us-ascii?Q?hlihtHFSjK2b+3MTcluSp+2P/wmdXARul0YjMvShTusbqyb2+HI+2MOSExw3?= =?us-ascii?Q?AO1b2509W9Eg+bR22DfCIcJ/36CAl2OJ1VKwzs77anlr1AN3tNTzdmmdL7AK?= =?us-ascii?Q?kohmpMgw+A9r2nROhALh9FUNZswIq/EaHsGgypm/LN5UbwSYdEwvuMIty9Mz?= =?us-ascii?Q?Aa/+ZaksVDFlZ6vXo=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 6:KDLUrHVnD7QVLCwDrVfzD7I5ybY9tYjfvAKHB1Wkh3XLvd5YUHnRcF9X3Y3y7y1rHKO6Tcq/GsNobi+hGBjZ5PiRYVr6YZ+vgRYXy8QecFH1bNpSjzOZXkPmbi1GJfr1luCVLYQHFLUd+/wTghPK7u6qG01PTVPGOkz6BYclcIOjQzNh3f7PxA5bkgLtnxlrC21Wa4aqzfjiUFeDk4hFH5pVJxYXkhvqdKzxjgkPeQ0sWJLL5JiU4EIdaQV7kGDdbImrYY2vSpgac0lk26hemZcL5k+3Hxy0bia8MbLznep9MVao2DmD+V0UQuLpCezm61QGV8d1Zm+NEkk8VDii0SE5McYOKxrOuhx3Xpglp2g=; 5:GrEnHILdCV4kelyQw0btYY7hw7VbIQkQIZSf9yQoOicwIis1Xn8clAoGLzndRWV6Ql6aWifQWMVVym7upBd6tcPlDb29huWmo2GQdWFAC6iWZw40nCy9CwyENLCl2LxTwRNIouYpwbwtg56MSQRlo2Kne80JABtEvPg0QM7/UyQ=; 24:jHoE7P9Qo59mDzIqkcqtVzbN6uGEVBCQ/P+o8EJnvn5uuATVjEXL0qZraS1TnpFEiVVomG2HpQmLqBXUz792fy6vJV7VBKvYHEhYb5MpCZ8=; 7:towxFXH/i4rgmlZu6AegBVPgEQ7OYBB9uFPl4Lsf65fEpG6cHpkpA1Z3AnS4fRh+GLcZSKFbXiLcOgAT8KZxaZ8CFGKqw1k2g2spdeZwlarMUSlhaOjuCw+mC28CFoA/VGUzFSUR9N3Balq0/a3ORoAUwSoqMu2KhJVrgqwElFH7WjWDzBkXp2Hk909rK7JjYMV/i/kEkLNIZMZD98stJikT2eF96sX3adBjtFQPnfE3hvecVesz/uCxWU2kJqWZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2017 03:38:22.6869 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59924104-948a-4a76-795d-08d51db55762 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes Fix this, when building with clang: /home/emaisin/src/binutils-gdb/gdb/unittests/common-utils-selftests.c:50:40: error: format string is not a string literal [-Werror,-Wformat-nonliteral] std::string result = string_vprintf (fmt, vp); ^~~ gdb/ChangeLog: * unittests/common-utils-selftests.c (format): Add ATTRIBUTE_PRINTF. --- gdb/ChangeLog | 5 +++++ gdb/unittests/common-utils-selftests.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 51e3422..9fe6329 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-10-27 Simon Marchi + + * unittests/common-utils-selftests.c (format): Add + ATTRIBUTE_PRINTF. + 2017-10-27 Simon Marchi * xml-syscall.c (struct syscall_desc): Add constructor. diff --git a/gdb/unittests/common-utils-selftests.c b/gdb/unittests/common-utils-selftests.c index 0f26b21..c48904b 100644 --- a/gdb/unittests/common-utils-selftests.c +++ b/gdb/unittests/common-utils-selftests.c @@ -41,7 +41,7 @@ string_printf_tests () SELF_CHECK (string_printf ("%s", X100000) == X100000); } -static std::string +static std::string ATTRIBUTE_PRINTF (1, 2) format (const char *fmt, ...) { va_list vp;