From patchwork Fri Oct 27 09:31:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 23901 Received: (qmail 51687 invoked by alias); 27 Oct 2017 09:31:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51648 invoked by uid 89); 27 Oct 2017 09:31:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Oct 2017 09:31:52 +0000 Received: by mail-wm0-f51.google.com with SMTP id r196so2313534wmf.2 for ; Fri, 27 Oct 2017 02:31:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=JpBMyiTRbLv/DkDTHKFAjdTTPq6vop2icCXYd7TkA+8=; b=LHksR9DsfO/XDHTL4GZSY6N3YD8qYa1LAXMxKbHZBqmU4D8dAaOzqO8Ok7h6+uiyER pZ/1rxYupC9iSvdI6Gyr8rU1i/ZCwMvZdEgH/AxvLfVOabuvnFmoKIFLUrWJ35HfyH/M JcLeSPqwlkrbcTqpOWViSezS1lbHQRFJQVHCPi6uaQoA9KGhv3k5Q4mZj7N2IC2ktezC fdIE0PwGXx1dOq6avpmnVRaYJMVH9nUOQ7lVS3F5+uG/PyyQKuaB3sgu93shGL+QEK8D rotUtzwkjA+/IpBVZAq6lh2Qb1Sa1pLadvXdHbHKWMn8L6n3UDLQWhxdzvsWXkuA8vKp DiXg== X-Gm-Message-State: AMCzsaVenucif51W/xfqfLEaEl30THrpVTWMuRzc4E2zy40a6H/P+bHm XPH0N6Qg2DfDWhRZ+0kQMk0chQ== X-Google-Smtp-Source: ABhQp+SaxATxKT6X7iMVrTZZunz/Do11K6QPIJnpRyhiBXMQPl5ljQpKaK2y69NnV3HF03yO8jaumw== X-Received: by 10.28.134.149 with SMTP id i143mr57303wmd.79.1509096709422; Fri, 27 Oct 2017 02:31:49 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id r29sm10349378wra.71.2017.10.27.02.31.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Oct 2017 02:31:48 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 2/8] Remove code wrapped by "#if 0" Date: Fri, 27 Oct 2017 10:31:36 +0100 Message-Id: <1509096702-12202-3-git-send-email-yao.qi@linaro.org> In-Reply-To: <1509096702-12202-1-git-send-email-yao.qi@linaro.org> References: <1509096702-12202-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes These code wrapped by "#if 0" was added by af030b9a, which added the new command to dump registers in 2002. The email didn't mention this either https://sourceware.org/ml/gdb-patches/2002-08/msg00227.html It was there for 15 years, and nobody needs it, so we can remove it. gdb: 2017-10-18 Yao Qi * regcache.c (regcache::dump): Remove code. --- gdb/regcache.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/gdb/regcache.c b/gdb/regcache.c index 5a1152e..0d3fe3d 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1330,21 +1330,6 @@ regcache::dump (ui_file *file, enum regcache_dump_what what_to_dump) int footnote_register_type_name_null = 0; long register_offset = 0; -#if 0 - fprintf_unfiltered (file, "nr_raw_registers %d\n", - m_descr->nr_raw_registers); - fprintf_unfiltered (file, "nr_cooked_registers %d\n", - m_descr->nr_cooked_registers); - fprintf_unfiltered (file, "sizeof_raw_registers %ld\n", - m_descr->sizeof_raw_registers); - fprintf_unfiltered (file, "sizeof_raw_register_status %ld\n", - m_descr->nr_raw_registers); - fprintf_unfiltered (file, "gdbarch_num_regs %d\n", - gdbarch_num_regs (gdbarch)); - fprintf_unfiltered (file, "gdbarch_num_pseudo_regs %d\n", - gdbarch_num_pseudo_regs (gdbarch)); -#endif - gdb_assert (m_descr->nr_cooked_registers == (gdbarch_num_regs (gdbarch) + gdbarch_num_pseudo_regs (gdbarch)));