From patchwork Tue Oct 10 18:51:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 23460 Received: (qmail 76386 invoked by alias); 10 Oct 2017 18:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 76356 invoked by uid 89); 10 Oct 2017 18:51:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-ClientProxiedBy:404 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 18:51:17 +0000 Received: from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 96.64.13256.3A61DD95; Tue, 10 Oct 2017 20:51:15 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.69) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 10 Oct 2017 20:51:15 +0200 Received: from elxacz23q12.ca.am.ericsson.se (192.75.88.130) by AM3PR07MB307.eurprd07.prod.outlook.com (2a01:111:e400:881b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Tue, 10 Oct 2017 18:51:13 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH] get_integer_valueof: Don't output value in test name Date: Tue, 10 Oct 2017 14:51:02 -0400 Message-ID: <1507661462-32717-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: BN6PR10CA0045.namprd10.prod.outlook.com (2603:10b6:404:109::31) To AM3PR07MB307.eurprd07.prod.outlook.com (2a01:111:e400:881b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 175c88ef-40eb-4d8f-413c-08d5100fe16d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM3PR07MB307; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB307; 3:RKeu/zdicnRrZIhojIeID94sIKyNzNQU4i9b5Uw/pvwsPU3dmGsu0Fiou3WNK1GvYcMtB1C7rkMpNWP9jh3lHeBULFgKb/c/N21dS53YCHSm8MKzhHzDqbLrNAKhDKLx48mDcj0d77jMnCgMKZUAx0Wq7isqIm+eaUCwvF7MHR2tFwXXSWB9oVKlBS3zou67hi8JeItyyqf57B8h3Ip+HePCeASwxV2k1PISFzi1y3L9MeE3bNW4liLHMb1GbR+P; 25:r/5fENWUXzFIhNOEA8saNdht3H1L7RA8nX1xJHPmvQhE7xad2MLHJUzphQjxBDNunFblzw/oGiIGQmLAaof8ewuJyJVIPdp5mvLr/1OW8jXNbD20oez3xSj4NW860Ai8IpHTHhsjjdSFIzW7Ouo5vBuMskd4wh5TEuX06udsKzfJzZzy1tte7bh4D7oOcVJdMdpUBLW53WFKDRPQ4Bu0ayWu8IzE3KmzJ5wlmlMZE9gi+fP6ig9Od42pSrvrFfAr42Wcj4GxQPpurk8n0o0bKQ7gJGoap25j59YQIl92kWPaZp3SzXZbzfBHTOygQX3wk6tsyWpoUByA2figHgVHyta7w3akZjYFUOErRa4Htjw=; 31:9Qjl7zF8MYAVQTt+mjPdahwkfSI2eVZ9zzsOpKhr0cKWtuzUvjd1x8o3ewM11mGu0iFEstArcfKOJRvQlkb1+RXZ1JUpzKhpT+1JHf6mPjjRs9Pe+uGUuZrMaj2ldXFRfs83+jXCxHXLhgtrI+wOiEGz9prweaGSX8GjP0RAbEJvnfGoLKX4QjQQe1YaAKb/oko4z/uZaJkP+24m74HHS5SurWvbX6Di3tJpaiT9DSw= X-MS-TrafficTypeDiagnostic: AM3PR07MB307: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB307; 20:FxWi80Q2KJkHSm7YJLngqaNTryWQdcz0Sb4IvD/tTZomYKGwGmBedJbmoj0O22M75bxqIe6271DtvJxp/t600jSfC6vK3RzYidPrPDTH7lPJgqWUjP3iwDmYfcz+Zin0sLGlPMIHyKCdkPSiOeAKnVnWJqtB0W2BZk+AKTWQnAxxTQMNheSNyGYhIZk1tuj1d2R49Nz7RPAxmiZAtU8plXXa7FNv3lTtKwCF8ScTwikgevPn9JZBhpNX/zWVfnttpY5x/7vgp86ltiAxkREDIxrgnr9FHbG9UwIiHpb4HxmYKTAUL8Om1EQEZVS21Mf+rs18F/4NTn4gW5bq3vbndSKSZN9t9WeS/B7W26zKYK8abOeSpFHZAse6ToFst653Ppkm8anlc7POa1GkFehcDG05pTTtNxEpbojOyD/9gJKF7MlF4mrpiCMBLdyB/uYgCaZIjjzF7jnwUjSnA3wIoRhwAHoaTkrnZN3SglIAClQRDOzrYRMqD19IrSmWdTsW; 4:DqlzfSg9u3n+jIaxxDofLKqXkHJ5Y14cq4WGldh1htY8wJIqX6nWdOG0+KAgU9q1wOPgl1c+DkfpHJ3Ls5yqkJbsdiZQ5IT0Da1fnOj+Lrb10gma3k76ARX4EFt3luagUc4qoiKocSa1tzgdbujx8uxyq+c3kxKN1BJdHXjpnLNMhysJViISgx9VBRJLNFh68heqnf4LyjeUmfPI//9HVK0vn6EsWJjeUzYOE2EhOMZPGTtFOZn2d29927dbrBft X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR07MB307; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR07MB307; X-Forefront-PRVS: 04569283F9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(54534003)(189002)(199003)(305945005)(2906002)(8936002)(50226002)(5660300001)(6916009)(6666003)(6486002)(189998001)(66066001)(5003940100001)(47776003)(86362001)(107886003)(53936002)(50986999)(101416001)(2351001)(106356001)(105586002)(6506006)(50466002)(6512007)(33646002)(2361001)(36756003)(97736004)(48376002)(4326008)(81156014)(7736002)(68736007)(16586007)(16526018)(316002)(478600001)(8676002)(25786009)(6116002)(81166006)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR07MB307; H:elxacz23q12.ca.am.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR07MB307; 23:NwnoPyENbo5f54IhRzaEkds8szfwnWc6++Eo4qDsS2?= =?us-ascii?Q?dI5D9voBHgtBTyNw70jGeiag6DBKOPoPVkeO6volTU4k7od4hTXVZ/Ydn2p8?= =?us-ascii?Q?1oJRctLlYSO7HZb0Lb+07VuJfKnBQF6HxoMnqzsgCgiRyt9hAvPqafSveEHv?= =?us-ascii?Q?S+a1iPUA5s6iTO0gjiOGmCA6yxctD4w6musD8t4sIb7y+NRTDhLJZVcjsXCd?= =?us-ascii?Q?HxEBam0MscK17sSKrZu2eKU+Wp5nFeEeyCIZSbnsjwvIA092Sy4MZ+1syyOE?= =?us-ascii?Q?9Y0M1IsUVkZfxz7u/1gqHp6s383MpAdTJXfp/8BxIs6UhUkvwmT/0v/v9vMn?= =?us-ascii?Q?1NkmnG7HoFdFoL9VB/xYBAeQhED3BMK5s32xUOJiVaD/IA4OTog7gjRxxcsD?= =?us-ascii?Q?sVrmlpEYihq+aByJ1cbUFvs76DK5ybgaCCLd4bbFmRgI7I6R1HeIyWvQhMWJ?= =?us-ascii?Q?Zzv7bZ1THVGtYy0OObsN9EQJ46hNNVewzGH+qECWJUH1gOxbs5Ro8sRZhTrs?= =?us-ascii?Q?WG8otOWymA+49URPGV6iwhF7smhpbzK4aRn+OilYme6EIGK0a9YXiB9sSoAw?= =?us-ascii?Q?MLWXR1ZAORCVJPLs3RrY6QIwLqp5ftuH6curpP1A4w+tIThkrWmQPU9UGMBX?= =?us-ascii?Q?ZHh2EB69sJ6+xSGM/raSETGqLph7hva43kY8d2bkEVKB4Mq+rp/1UQBypHQv?= =?us-ascii?Q?XK73UlokJutIxnMTDRHUql+87t56PYrP9JSPRhrRATQfsa2YuXhW5nBEGOe1?= =?us-ascii?Q?bkMUNMgua2+dysO5xtZBNA4u0xcKsy2zDQ+oRWkyinD1Glwkoudix7GmPMFN?= =?us-ascii?Q?cNEnLo1rjx23p3sLcE+PH0P4yVvqzXGrlTEbgnqBLamLKuXh54PtcBh8XydG?= =?us-ascii?Q?KrlTYloVy6ge/QHNFgZ6WOd3S2knPahOmLEYrvyU2psXyHXV86bYWittMsT/?= =?us-ascii?Q?ixV5JE8n8nM9pxoIJi9QGZCrW2j8u4lljOKfYo+vYE81kvur2ynbtDoJqDJP?= =?us-ascii?Q?5egFXuOyKT1LpzTq9DtNNG5UHSGZg3CF0mOVkjEMYlFotdQboyykI9LNvavN?= =?us-ascii?Q?4ihmYtROQ62xSIS/Hn7+Gjv7bAL/qlEWPnd7QpNW9nyJFvnvh3B/svwOe4L8?= =?us-ascii?Q?BwJuGnI0E=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB307; 6:8NKpPW8Oevb1ESvWzuHcE9XIsJVmTONDKL4HGp4bRw2lqd+Ltn16OlU0RKBvWdkgjT2do3Lys/bqeOnDUh7vMnTTFCnpdSj4VlSUYI4SuPw2MK5BpM0dD0GreN98EeCwXRkUFMVIloslpzbBEZK2UpWmuT1hXJnFDrPTWJLOfYEfHMsGCkzRAuBNNKgbLgOSZN+LqCwGv9+T6zIIe+9gaJFI2+SytMnHASAZNoboY5lgXt3pRlmaoacuG4oFhXt7kqa+Cs4Jmzydt3B9L/FkMDJp0W9icbYXCLDeLL2XwNulIbvVP+zk6LUPVyyFCsM5XUmv2e5sPURm3mf1MnwsBw==; 5:wVYJJFBSy4MnyltqOukteMtBXryJD6OchonCDjOd+KY3zUJ0nTfyP0kcvy3MGxjaua/Zy71MRviWpxW+uS7f1fV6mLhQqBKcAW+bsrUI2DZNuBPZSteSbKQnhlxF+IWy9nmDY/avllTxouZeJgwzug==; 24:hd8gHWISkIpZ1OQYOj1TP5nOrDzWTw+ncVj/wydTUP/677kZxVu1HaFdFX82oLkd7NSOzCEUE2rvJ8eJjxDSIZhZdiJXkRKDr2HwwoV8Qhc=; 7:i747jJX+Y1rqFGJK+B+UND2kwHoJhywbxQTy+iqqH67AnQo4rgerxkUzWBogFCt89pKF1tzv+hs2rYwkG7gOGRhplGyMRQYLk4J+9u7vwJ8gB78jCrA3ofY8/95Ivfl8FATZWb/ooOF2GKqBEOmSPuO4qjC8fYwj+1zCawnglHEu6wzITfNitHonQgaai2tzGOepjueOfvlZzw9BErmdDoAJ/AfM/0PAHb6OHtinSvM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 18:51:13.0857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB307 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes The get_integer_valueof outputs the value it has read as part of the test name. This causes test names to vary from run to run, and adds some noise when diffing test results. e.g.: -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770) +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238) This patch removes that, since it's probably not very useful. gdb/testsuite/ChangeLog: * lib/gdb.exp (get_integer_valueof): Don't output read value in test name. --- gdb/testsuite/lib/gdb.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 48fec2f..9d8296a 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5634,7 +5634,7 @@ proc get_integer_valueof { exp default {test ""} } { gdb_test_multiple "print /d ${exp}" "$test" { -re "\\$\[0-9\]* = (\[-\]*\[0-9\]*).*$gdb_prompt $" { set val $expect_out(1,string) - pass "$test ($val)" + pass "$test" } timeout { fail "$test (timeout)"