From patchwork Thu Sep 21 13:20:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 23058 Received: (qmail 104428 invoked by alias); 21 Sep 2017 13:20:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 104368 invoked by uid 89); 21 Sep 2017 13:20:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 13:20:22 +0000 Received: from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 1A.51.20899.39CB3C95; Thu, 21 Sep 2017 15:20:20 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.51) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 21 Sep 2017 15:20:13 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ki.sw.ericsson.se (192.176.1.80) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 21 Sep 2017 13:20:12 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] linux-waitpid: Get rid of format string warning Date: Thu, 21 Sep 2017 15:20:05 +0200 Message-ID: <1506000005-3936-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: HE1PR0101CA0004.eurprd01.prod.exchangelabs.com (2603:10a6:3:77::14) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17423173-ea75-46a4-e0f8-08d500f37dcc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 3:I2UQMLvkTBkS/6blxNZgADHs5KTdJpMDv0zEgzhhhDA4du+/a+HLIbRB2Js9mxRHBwKVQ1scmbezT5D1Uk+bbWCgvZwzd9jCQ0UnoRMwXkhyxQAtnExV0YIa0qSD0TrWesvokIcAhbrKNZWd12qLYC+PAGB6IVPZDd7pG54mh1P0tyEiQ0lGiqo3xlhpdKm6if86EiwFYMErezgnq1twX0vaeIiwc38S5lx2YEAV0YzE1CKa6UOfLVw0CfAMyeCT; 25:H9jfO4sugMxBxoGMZHCraiv0Cc9miocHdTwrLPkCLJgbJgU6O7tvbObbY403Nq/SLwQFVB4DtcPwHH5UBKOz+B9i6DqqVNQqH4HWeX4ncQQnHSJz9enpOt3qUXPgG22EA6+D/EV8rbnAr4aR9dQZ81cd/IcPbg8lbJBIVnJ7vz1L5fsvtSZlaq3VrochQmMeeH423Jf8yEN2UpLvrx2nzEdosIs2dTL7i+uHa4gO02WEbRIGn9OBW9O2Y5wSdAxzrr/q3qQ3tsh/zZptoulby4Qt4ae54I/78c5feNFUTb8tQzi/+HNpuZxpygD5Hdn6jVZN+TTpzclk20G9VYxtpQ==; 31:Ipi355PLdfmcm8pu7gnpPlivcGsDlzYhYB9iq5EZm1NL135QeW6OqnudywM61rJpjUGmEu5J/usR7C4oDZ/5g3fpXU2m3YTcIp3lToHDiXCQkoRRAg0XLuao7jycyz4Cv7LlgylAV34Jmfmzm6kpJQ9/WCpy7vnNZiWv0FNnMO0v1zDCnbGejPcEP/5qdM7n8hD0EoAdZsuw3s4WO3e+Od6Vu33YwEpL2sx9ZKagGr4= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 20:BYN88jagLax4zM3OXJ92/J6Lg5keqovgXd2C3Wd8InSbvHeeMQmhic+IgUuBDXTz417fTnY1UUX6TtclCpu/BGBOLtKptyAeTMOjd9BzWzEWzRNqfBywq3dHNBs7OJX4d23JiOWhO6PG0eoH4gvvyPtORnvUVqYEFer9ngFcadArJPul3xoLPMJ+xVQmQnRYQj9841BwwP6Y/Kifi5UD4Do8LK1CVYOlPz/E3/zd3xn6nByGYuAGz1m9WW7TiilXgEcrX7gyoSXwc6a0rbgc6yawQ7oFzvzixxjPpobr5xRCWqkRhd0UDOrZA0GdGl/2r77r306ncGVJrd6tojTTqKdEJxyzz8ngcSegykekJFOf7aOmHBK6c8QTYD+m8C6czTX7HKilLmIiuv+3JA52LHt3nxel0XEtmhYItIY49RleNTcJJPoweErUjv3wU0Pc1WfsjIAaCd6F5GR7nuaWorNV3C6DNsLtlyE4SDYZjfFso5t2eX+EA/zwwNTfhRMs; 4:JWV+PVXnbCSoxbQ2i715q5nI+c1T1DywsFMRJQkMWWh+e45zv6MIeAWd2mXwAhfWuET5fpwvjBJCi8M/9cppBb8K0fql/jJPPbrilwtxVd15Eo4vQfpFSTl3ClXLOma2xQYerETXOjExQ+3zaezNFg/zaH7SSGLM+VC9HkZsoZBkKcoaxLiBdcrFXqwOjWtE85HH9rjkKd9lZ2rN5JSAXgRghSczwzs5MDQF8WX0bo+Y2udwljSt3AEcKW6ScMJAVaMVLUtRoKK94Kk/6sUAZ7hlmQ4iSv6HkZnY6O8bnL0= X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB312; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB312; X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(199003)(54534003)(377424004)(189002)(6506006)(305945005)(5003940100001)(7736002)(16586007)(6486002)(478600001)(48376002)(86362001)(68736007)(6916009)(5660300001)(3846002)(6116002)(189998001)(33646002)(36756003)(50986999)(25786009)(8676002)(50466002)(97736004)(6512007)(81156014)(81166006)(6666003)(50226002)(106356001)(2361001)(101416001)(66066001)(53936002)(4326008)(8936002)(2906002)(2351001)(47776003)(105586002)(316002)(16526017)(107886003)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB312; H:elxacz23q12.ki.sw.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB312; 23:ZMl2PW7JznAoVYLxibAmm5rhv7kYY4Uk5ga/bV1s40?= =?us-ascii?Q?cVBZVH49DUi/bgb06KxNExV3MIsZO5aYmcujOXPblHm/HFwuDe7iJbdF65st?= =?us-ascii?Q?KNag4pUh7TXmNWQwHkWl/OCfPcM7wYzed5+bpz5u0UHaxBIDTcrIvnUf5fLf?= =?us-ascii?Q?fmu+sISG79vaqZbw7EPimbVEfBwtz+75p6a1OpaVX2UtvHaSSN1sdmX4WJje?= =?us-ascii?Q?ppO4Cf7ujmuxI3qh44SZDMwPipupmPSsTnwGPN5prMt4R7K4VI8QZmNTIpRd?= =?us-ascii?Q?uSssPy5Fk2XcdmEJeNjuudbIhcymH5ZPfAPbwusVBkpIKUaszL3Z52quwezF?= =?us-ascii?Q?hu40PUpdVCIplsd1TCI+gWFfVDcMCBYxAfB0jsUJVh31VfmLOhwm3bGsHdLL?= =?us-ascii?Q?VY+O56+GuOSKSE7mVIgkoiLfEaem9yMcO2yMk2gTM87eMPTZDOUdUjhyNWH4?= =?us-ascii?Q?ef5OsAH24LSFp+uKnJiSeKh4iD1Dvnb+Yc8mXc72uSI/Igz7BLbbpbhxmB8z?= =?us-ascii?Q?abHrX6chc4o85YC+Dm0xE8ZDW4vkPG4Hb762QMjE5luvuPPgx7Gk42bLfGEP?= =?us-ascii?Q?bKzbilenHg2THQq12jIjWuD6NoMe2lANfkWyLkDWU+mUgPBDzlEEkkrhkw6j?= =?us-ascii?Q?BzbuAtZiXG+Qrc+e+jUYp7jR+wh0olRI2TgYyA4FfhC0av72OzqUATPgicWB?= =?us-ascii?Q?iF64MyaYEZNC88QlEo3HWnRtxgm5Or/g4u2vwPNnN25cfmlX1v6+OhcE8btf?= =?us-ascii?Q?RsneodO3XD3lDPgS6BBQDUr5UgmBe4NzNbjCGBesX3CRselHFjbvyNqgpqsX?= =?us-ascii?Q?aExAY2J9O5chZBKnEkXYviKlpfDanS1cvs/tDzgr4avPtyj5wEqd+vMe2ZEq?= =?us-ascii?Q?ZTzaXQ3mWzOYsvWFUhI8RU9387mkqPH++ZDjKBI5Q84CmSa1zv0DsZXBuK7n?= =?us-ascii?Q?OzwjfYItI8j0W8sbT8K9IVGruquF96O8gqbfkfyng5ZAPZ6VUn3FP4mXzEpG?= =?us-ascii?Q?qGvfTfumJ9UZ2nFc0BXpmulfLl5mresglys95YSxoRhFHBx/I08Pku9IUj+u?= =?us-ascii?Q?X59cv+/Px1F/kEvSV1z6wmozBzV8v6hhtXbYsBE/+5fumtpicYc7hG7HAFxA?= =?us-ascii?Q?An4gMPR5EqJPw/qk53DOKRGmSTqfzQPMz0BoLlI05gDmxk1rt4yw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB312; 6:oDbwul/iLdi9h0qm0+JgWHI5tYTF0eTLp4/I898swGX/3KOf+fGxw1I1+t40uMtERdvuP+d1Zb/cvLW0VnTq4hi8FaUo+F99DqBYaawycSw7CZnoZe2HfPzib8gMuB1rwtXEzNz55JFnwCHkiLKfef5nrWaaxHeDNeUjE6LHUyJPxeX37rny9/XT2siv1lDMcRzmEbmck7D42jlGXOusqf0RP5vUvsoFGgXjLU7TKJZJL3W6z3sWIf1zoWEwltLD06bte0OiX42cGRoFS8mAfx31MQcAwGNYMXVPror2T5MpHZplFNvg3IGjZWNkXztTTbPl9FgUBHizkAJwZCiAag==; 5:dJgoKr3O8hrqoeI0xXbrphPLe9eH0cPN0sBR5HBfbFXLd73Ov5htaVxQE0jSSoCW6dhQlI1PiAOdkZV1uXGNgsvSpEd4f6VyYrBs+Vx6ugZobD8TeZRo33bSvXRS4YY+IH5iBejLj+xGx+QEDVJGcw==; 24:cwEvmaDb5JbbLZqG6YEwm4fDvVQ8KzmQC1GSYLc7VcIxS42ue0IjcJ+BI+zoqqgHRTYcKHlVoAOuWKFP1/WH/ZESiyob9Ct1JwnOxzs6xps=; 7:jhrEEDLjnP5EBce0Yx53hVttgIJahy/3KVCI+Bu3arD/oi3D6VqWhOL5hOB6EgVUb83KATzJYnehNXK2FpOCVfbQVKJF0cOPeRiP+fudfqcZ7MCFJy+mkNBw4kEit+zmZhlVSZ0TysttXVXtsY1b9G6P5syONduDUvRoAIYAojB5DMOYJ5XIBoCn5B78IHlPJSbv9ssnKJUQHHWwg9wanHDIPRzp/R2i250xO2xR1xY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 13:20:12.8706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes Clang gives this warning: /home/emaisin/src/binutils-gdb/gdb/gdbserver/../nat/linux-waitpid.c:45:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf (stderr, format, args); ^~~~~~ Get rid of it by adding ATTRIBUTE_PRINTF. gdb/ChangeLog: * nat/linux-waitpid.c (linux_debug): Add ATTRIBUTE_PRINTF. --- gdb/ChangeLog | 4 ++++ gdb/nat/linux-waitpid.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 88e7a6e..5803abf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2017-09-21 Simon Marchi + * nat/linux-waitpid.c (linux_debug): Add ATTRIBUTE_PRINTF. + +2017-09-21 Simon Marchi + * microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF. 2017-09-21 Yao Qi diff --git a/gdb/nat/linux-waitpid.c b/gdb/nat/linux-waitpid.c index bf5e725..05d1e26 100644 --- a/gdb/nat/linux-waitpid.c +++ b/gdb/nat/linux-waitpid.c @@ -34,7 +34,7 @@ /* Print debugging output based on the format string FORMAT and its parameters. */ -static inline void +static inline void ATTRIBUTE_PRINTF (1,2) linux_debug (const char *format, ...) { #ifdef GDBSERVER