From patchwork Thu Sep 7 15:09:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 22703 Received: (qmail 3764 invoked by alias); 7 Sep 2017 15:09:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3754 invoked by uid 89); 7 Sep 2017 15:09:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=Maintenance X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Sep 2017 15:09:20 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 9F.28.20899.D1161B95; Thu, 7 Sep 2017 17:09:17 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 7 Sep 2017 17:09:17 +0200 Received: from elxacz23q12.ki.sw.ericsson.se (192.176.1.84) by DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.3; Thu, 7 Sep 2017 15:09:14 +0000 From: Simon Marchi To: CC: , , Simon Marchi Subject: [PATCH v2] Add selftests run filtering Date: Thu, 7 Sep 2017 17:09:06 +0200 Message-ID: <1504796946-22276-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1504732838-6455-1-git-send-email-simon.marchi@ericsson.com> References: <1504732838-6455-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: AM4PR07CA0011.eurprd07.prod.outlook.com (2603:10a6:205:1::24) To DB4PR07MB314.eurprd07.prod.outlook.com (2a01:111:e400:982f::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aaa43e59-4c63-4072-3e09-08d4f602673d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB4PR07MB314; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB314; 3:PekK3my2ctWXNKrN1e3jOKLSSoiU+iV9qDDGpLwHWhiBGVd2sDp3+JFyr9W/UfeGbXvQjK4Tk6nhHQyZv78RLzpV08EQP+mxf8D7oY590BqcQfMiVoabmhMXA+s/sK7NAJyDuyLNES81jBZBBtcowa5O5BIr2LKlC9WNDe6Nkkf8wkQfRppQg8Yx4Onl62u0yjBmmzPcX8hNDaT4Q9YqXKu3oDfNBjvZW69LWViFOSIvd27y10FVlMsEnLyRAS7i; 25:kprYDMp6o5b4gehr2RrbjhZR1YFhONaUI4HGjmmA7779bkXcBXwqRsztJQjTUDCYQL1o/ZalPtuyMbPNbkn5gg9PPasHJU2DMtxB6nJvpEiVK1EmaXeNPDOU3KM93baMtaNii90grilUdzdHAvjoftW1ljliGmVFRVbnBGropJxPrgqtFY7LtMpAakmgaB5lW1RS8oWGv5xWdXDg9TWlNtj232Jdtoiv5EMVy7TyXU/m9O+YHNGtW8YCdy4qCYrXk/ZSOKII4SguDzl3mb9THbfqNg/fJE+6p+GN0jepSTXzj5oU8tFwJZzVN7XxULDm1HTGz+uoC1cw0tOwq+uEPQ==; 31:cytPZ7FXa1dYBBwreM2WTWCea/uUe954suocKzkQCtP3DcqLRMZrgDu31pdnyWkqq1dP0/+nwD+74zJBr+1PEI6GUMQ+B4ta+a4Io1SCAUl09yl10ze/DYHPHk3J3i+CvJ0wrebGjBjqt1vokMoAtNFuVbBKnIe7XM941YIseNEVLpG7q+t9PIFON4a1xr0YSSvKUMiG/vEkl3cuu5SHXN2MSg/euzk2CGaDtQbQEXY= X-MS-TrafficTypeDiagnostic: DB4PR07MB314: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB314; 20:ieN/ftXevY2MuQ09BSWWb8LCw62dCZkJse3AM4QpTiK1nIjXRIeI26QOpwvbMc9eDbzXsM3YUA3bZBJaPQwizKkfBfKFn2hsgGxxU8T3iKbev1/ez3bt3bqbWLcIqcuoyzvQ6RQmNMSg7Bm+J8xyrONhH96oaMstzm03/wWc7omLWBHyDdYUYCwZdnwn1y7FBkEMg+FEbPp5ej3XyF/DIF9AOMYiu9ekqY0tTZ0NI7zFQk5uosg9SLOCTJ7c+bdxAhfMx65Kx5pY6F0iroOT29tKzp1mIHaqiol9UPguKl2ksAbx0GN38l3jc+rXURgQtKD76L7ZaCde/trlKA0wb1ibLvj8TB1akMc4CfoFgkGCdVyyaq8TV6QVP/IKeF5KPbJy+rmnoHOXCii05KHlr7eMhzN5DUTfdj48xmcg/wy5d5WC4sYmne/v3WBr/KaP6tOFialpCQ9USHpXMAjsINhneAfIwy438WVEUb3MuhSlx1aIyUBzRNKz3U6z1mJJ; 4:hzDbeA/4uMswG5ansaAjC490YIebBBo3Hny/P6l68QpSvZnuhcXElyBKzbp5/1tqjq22+uW3NBboyKlocWkkBMw+sAHcySKgje/+oKoq7/ZrN3xsI68F4fzl/24rv5TmbcFs8Qz1WHrxNNjQlcas9E1ObZRuGZrPC33G6tO1KFMxEwb9xNNy8qdRIkWBmm6pLBVIaeMP7PH404RTfaPpZGZlwdLCgUYi1xP8wY9a4DLJ2bnqe2YvkzKQ56/8Ru/G X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB4PR07MB314; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB4PR07MB314; X-Forefront-PRVS: 04238CD941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(54534003)(199003)(189002)(2361001)(50466002)(48376002)(25786009)(2950100002)(6916009)(478600001)(6666003)(6506006)(36756003)(5660300001)(7350300001)(5890100001)(50986999)(6486002)(189998001)(42186005)(4326008)(33646002)(53936002)(68736007)(81166006)(8676002)(81156014)(305945005)(50226002)(5003940100001)(7736002)(110136004)(76176999)(107886003)(3846002)(106356001)(6116002)(101416001)(2906002)(2351001)(86362001)(97736004)(6512007)(575784001)(105586002)(47776003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR07MB314; H:elxacz23q12.ki.sw.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR07MB314; 23:dAzZJFgs7iXXzg1fviY9JUCcE8FqGwZlTQXm/Javy0?= =?us-ascii?Q?KwqTn5oZfc2qI84XKiZc7AWSr/hK2eYVWZDUI5MLaBAgCiYP7s1JSpoHTlb1?= =?us-ascii?Q?nUEWf7eHEgNuybxgZjbDOFdEQimH1UlnBglwinbwSyvcEdy9s+OzewhIHHh6?= =?us-ascii?Q?jRwWe3oUwBGSiEe40CzbTFB0z06bmCsj7FtaaTk7R58Evo90j66bwDRCfV0o?= =?us-ascii?Q?BrYf2NdNBBjU9NV6bHGdHRKk/KkavrfEeQuXCQOT3OrCvwXq+crs1w98OXep?= =?us-ascii?Q?kY+fOSKvu+XpLf7v2NuTmH0H0xP7/y8RA2VWz5z14U5/2YHIdpFHl6cL6k5v?= =?us-ascii?Q?LHVgsNJ3DuCa9To7Ic1n21vy9N4ofzbL40IL9SIH5c3TbZrCQ9MOXPICjf12?= =?us-ascii?Q?ML2DbAgrr4hO9a4mDDxxXe+zGTztbj17EwAtBIcF/KcLsKinKRX+oV14I66V?= =?us-ascii?Q?5M+0aBILcCcd+n4JX/VCoFrpK/bSORlraI1yRSE/ZcZy71lI5eTIgQg3YBy9?= =?us-ascii?Q?EqSTiLgLC1KzG8JjOq/A+l6FNovYuzUNAgpQ8kdsun8VolSZB34PRWnqAXMC?= =?us-ascii?Q?zq4Jv2MNgBHlrxXh7iz+oT+ybZ1hYbdSEHnIVzT1CDNFxvrF5C8H6ZFUmpKP?= =?us-ascii?Q?/x466zQwE3qUmK3VZ8Qc0QVqKl7g9ywRLQiStz94P7fwepFw4FsMjVtqag8c?= =?us-ascii?Q?emhACnxaA1DLYpV4T6l/VC8R5OaX8vBTJMC3I3NVEW4uNt0XSif4iYF0QeGr?= =?us-ascii?Q?64t/VNw8TFPEL7NbwqGQYlq75w5aSfmwCDck0zmnYHfFCO5YKN8NjGWKuLdm?= =?us-ascii?Q?CsZV9hkH+U4FQiY5HwDisbw+p7YRjSQe8lktPFTHkNb4hl1iL+IHfuORE5Hx?= =?us-ascii?Q?B6/z5Q9ybXc6Lp8o0HZfq/OiphJyIkMvUZgBey+bC7Qrd4HmKpHRRd4ei2qg?= =?us-ascii?Q?Z9balBDYE2wphNwCIOkpOkWCv+BtkpjATKWlP9FLRSq4sIaBMJtj775RK8R9?= =?us-ascii?Q?CZ6Tt9XaSHzYvFbb6CQHYFZyk3goUanE9sj0bNYFdxkTIMW7c89WdggnWAZ7?= =?us-ascii?Q?Gv9Zh4wPyrKe5yrHO31yREh9PNOT0T5eKfOIWVVf9ZJT5t9C2zV1Lfgu/0ff?= =?us-ascii?Q?RNu14GTyVSAHTlCm4+EtPchqhR3UbBT3EU40Bd68YDz+wjmi2jg0zgHdKIQJ?= =?us-ascii?Q?+F43A5N0mQ3MgoOQL1+SxKs2bmBlRzTNWvdmS83eBRcNxktRm3866IhKZIwr?= =?us-ascii?Q?pMbkCQ/MmfNBRw2II=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB314; 6:rboTHeSjCvF7HGV3bvJZ8SrKoo8boMpGwvx5x3f7/LdJl9+5QYbEil/aGLr92Fq0JyBupurctL6BtnBRDtR9c06PTqedeztLccdsY46quoz2w8cBdrsGS3K4JPXzj80U2v22M1hmiyY5+MVqS3zIhZ5Tt1G5v80EtDzs/I2tzNb8RzK4ImqfMZ3q/drdzrA2X+WItZ4OksCN5pyu/mL24vNpqWG3v7I0IqzEji1MZImSpSaQvBA4GzzS1fhjrsyenkF2ugKjaqzqYc/Y39NqoVbxn3w9EAFJug2DPUqeBR8gLKD/N/d1t53zRvZvXfW4skomyd9ep2G1NupH9iV25w==; 5:vARTx7PjV4pInSgu8SmTsqlWFV3QU6vkdgIz0ts33QYEGBApOpFYShrdGVkmQDwtjZFjXFYuENGPJTOafrdEP1Gdu51lt5e0iajaxuyMXNwa7sGLaP3kL0zTJ6DM7sp2c27AYSn6aJcptL+EVsDHWQ==; 24:ZVnyzWhpjGII0b693pBb0xxvaL5/pgcwt3E9MkeUct8HoQ+tm0aU98QwcOFcje8b9+PlmEsPt/G+s7FcMidO/bOXp7Rmc8ROdKO0LEa19+o=; 7:ShjNYsfwjSkjSCXrIff/j/+vJ6mTYDDZDgmiqEw/nkBf94EZPAtzEDJiE303cqeVduUf4KJzVmB7KoRoVsYGLYJDpAW3N3gm3afogdMZNZXqhGzN11/H845EzLIXInF29qmD1MhOZmmLbgyTngo9URU91V3OFb5vdQ4ozPGAC169nIkRBTIPE5+DfxXrpuHLHcafNMDCrkcArIG4H0b/2FT+o9C/RqIG6bX4z1Cl5Sg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2017 15:09:14.5235 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB314 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes New in v3: I realized I had forgotten help, news and doc, this patch adds those. Actual commit log: With the growing number of selftests, I think it would be useful to be able to run only a subset of the tests. This patch associates a name to each registered selftest. It then allows doing something like: (gdb) maintenance selftest aarch64 Running self-tests. Running selftest aarch64-analyze-prologue. Running selftest aarch64-process-record. Ran 2 unit tests, 0 failed or with gdbserver: ./gdbserver --selftest=aarch64 In both cases, only the tests that contain "aarch64" in their name are ran. To help validate that the tests you want to run were actually ran, it also prints a message with the test name before running each test. Right now, all the arch-dependent tests are registered as a single test of the selftests. To be able to filter those too, I made them "first-class citizen" selftests. The selftest type is an interface, with different implementations for "simple selftests" and "arch selftests". The run_tests function simply iterates on that an invokes operator() on each test. I changed the tests data structure from a vector to a map, because - it allows iterating in a stable (alphabetical) order - it allows to easily verify if a test with a given name has been registered, to avoid duplicates There's also a new command "maintenance info selftests" that lists the registered selftests. gdb/ChangeLog: * common/selftest.h (selftest): New struct/interface. (register_test): Add name parameter, add new overload. (run_tests): Add filter parameter. (for_each_selftest_ftype): New typedef. (for_each_selftest): New declaration. * common/selftest.c (tests): Change type to map>. (simple_selftest): New struct. (register_test): New function. (register_test): Add name parameter and use it. (run_tests): Add filter parameter and use it. Add prints. Adjust to vector -> map change. * aarch64-tdep.c (_initialize_aarch64_tdep): Add names when registering selftests. * arm-tdep.c (_initialize_arm_tdep): Likewise. * disasm-selftests.c (_initialize_disasm_selftests): Likewise. * dwarf2-frame.c (_initialize_dwarf2_frame): Likewise. * dwarf2loc.c (_initialize_dwarf2loc): Likewise. * findvar.c (_initialize_findvar): Likewise. * gdbarch-selftests.c (_initialize_gdbarch_selftests): Likewise. * maint.c (maintenance_selftest): Update call to run_tests. (maintenance_info_selftests): New function. (_initialize_maint_cmds): Register "maintenance info selftests" command. Update "maintenance selftest" doc. * regcache.c (_initialize_regcache): Add names when registering selftests. * rust-exp.y (_initialize_rust_exp): Likewise. * selftest-arch.c (gdbarch_selftest): New struct. (gdbarch_tests): Remove. (register_test_foreach_arch): Add name parameter. Call register_test. (tests_with_arch): Remove, move most content to gdbarch_selftest::operator(). (_initialize_selftests_foreach_arch): Remove. * selftest-arch.h (register_test_foreach_arch): Add name parameter. (run_tests_with_arch): New declaration. * utils-selftests.c (_initialize_utils_selftests): Add names when registering selftests. * utils.c (_initialize_utils): Likewise. * unittests/array-view-selftests.c (_initialize_array_view_selftests): Likewise. * unittests/environ-selftests.c (_initialize_environ_selftests): Likewise. * unittests/function-view-selftests.c (_initialize_function_view_selftests): Likewise. * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Likewise. * unittests/optional-selftests.c (_initialize_optional_selftests): Likewise. * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Likewise. * NEWS: Document "maintenance selftest" and "maint info selftests". gdb/gdbserver/ChangeLog: * server.c (captured_main): Accept argument for --selftest. Update run_tests call. * linux-x86-tdesc-selftest.c (initialize_low_tdesc): Add names when registering selftests. gdb/doc/ChangeLog: * gdb.texinfo (Maintenance Commands): Document filter parameter of "maint selftest". Document "maint info selftests" command. --- gdb/NEWS | 6 ++ gdb/aarch64-tdep.c | 6 +- gdb/arm-tdep.c | 2 +- gdb/common/selftest.c | 67 ++++++++++++--- gdb/common/selftest.h | 26 +++++- gdb/disasm-selftests.c | 6 +- gdb/doc/gdb.texinfo | 8 ++ gdb/dwarf2-frame.c | 3 +- gdb/dwarf2loc.c | 2 +- gdb/findvar.c | 4 +- gdb/gdbarch-selftests.c | 3 +- gdb/gdbserver/linux-x86-tdesc-selftest.c | 4 +- gdb/gdbserver/server.c | 8 +- gdb/maint.c | 18 +++- gdb/regcache.c | 3 +- gdb/rust-exp.y | 2 +- gdb/selftest-arch.c | 136 +++++++++++++++---------------- gdb/selftest-arch.h | 3 +- gdb/unittests/array-view-selftests.c | 3 +- gdb/unittests/environ-selftests.c | 3 +- gdb/unittests/function-view-selftests.c | 3 +- gdb/unittests/offset-type-selftests.c | 2 +- gdb/unittests/optional-selftests.c | 2 +- gdb/unittests/scoped_restore-selftests.c | 3 +- gdb/utils-selftests.c | 2 +- gdb/utils.c | 2 +- 26 files changed, 217 insertions(+), 110 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 0280a2e..052bafd 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -53,6 +53,9 @@ QStartupWithShell * The "maintenance print c-tdesc" command now takes an optional argument which is the file name of XML target description. +* The "maintenance selftest" command now takes an optional argument to + filter the tests to be run. + * New commands set|show compile-gcc @@ -63,6 +66,9 @@ set debug separate-debug-file show debug separate-debug-file Control the display of debug output about separate debug file search. +maint info selftests + List the registered selftests. + * TUI Single-Key mode now supports two new shortcut keys: `i' for stepi and `o' for nexti. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 5a627a3..ebd3e47 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3068,8 +3068,10 @@ When on, AArch64 specific debugging is enabled."), &setdebuglist, &showdebuglist); #if GDB_SELF_TEST - selftests::register_test (selftests::aarch64_analyze_prologue_test); - selftests::register_test (selftests::aarch64_process_record_test); + selftests::register_test ("aarch64-analyze-prologue", + selftests::aarch64_analyze_prologue_test); + selftests::register_test ("aarch64-process-record", + selftests::aarch64_process_record_test); #endif } diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 0c1a0b3..751ee27 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -9727,7 +9727,7 @@ vfp - VFP co-processor."), &setdebuglist, &showdebuglist); #if GDB_SELF_TEST - selftests::register_test (selftests::arm_record_test); + selftests::register_test ("arm-record", selftests::arm_record_test); #endif } diff --git a/gdb/common/selftest.c b/gdb/common/selftest.c index 0fb8f2a..793c15f 100644 --- a/gdb/common/selftest.c +++ b/gdb/common/selftest.c @@ -20,35 +20,71 @@ #include "common-exceptions.h" #include "common-debug.h" #include "selftest.h" -#include +#include namespace selftests { +/* All the tests that have been registered. Using an std::map allows keeping + the order of tests stable and easily looking whether a test name exists. */ -/* All the tests that have been registered. */ +static std::map> tests; -static std::vector tests; +/* A selftest that calls the test function without arguments. */ + +struct simple_selftest : public selftest +{ + simple_selftest (self_test_function *function_) + : function (function_) + {} + + void operator() () const override + { + function (); + } + + self_test_function *function; +}; /* See selftest.h. */ void -register_test (self_test_function *function) +register_test (const std::string &name, selftest *test) { - tests.push_back (function); + /* Check that no test with this name already exist. */ + gdb_assert (tests.find (name) == tests.end ()); + + tests[name] = std::unique_ptr (test); } /* See selftest.h. */ void -run_tests (void) +register_test (const std::string &name, self_test_function *function) { - int failed = 0; + register_test (name, new simple_selftest (function)); +} + +/* See selftest.h. */ - for (int i = 0; i < tests.size (); ++i) +void +run_tests (const char *filter) +{ + int ran = 0, failed = 0; + + for (const auto &pair : tests) { + const std::string &name = pair.first; + const std::unique_ptr &test = pair.second; + + if (filter != NULL && *filter != '\0' + && name.find (filter) == std::string::npos) + continue; + TRY { - tests[i] (); + debug_printf (_("Running selftest %s.\n"), name.c_str ()); + ++ran; + (*test) (); } CATCH (ex, RETURN_MASK_ERROR) { @@ -60,7 +96,16 @@ run_tests (void) reset (); } - debug_printf ("Ran %lu unit tests, %d failed\n", - (long) tests.size (), failed); + debug_printf (_("Ran %d unit tests, %d failed\n"), + ran, failed); } + +/* See selftest.h. */ + +void for_each_selftest (for_each_selftest_ftype func) +{ + for (const auto &pair : tests) + func (pair.first); +} + } // namespace selftests diff --git a/gdb/common/selftest.h b/gdb/common/selftest.h index e211c34..35a344f 100644 --- a/gdb/common/selftest.h +++ b/gdb/common/selftest.h @@ -27,18 +27,38 @@ typedef void self_test_function (void); namespace selftests { +/* Interface for the various kinds of selftests. */ + +struct selftest +{ + virtual void operator() () const = 0; +}; + /* Register a new self-test. */ -extern void register_test (self_test_function *function); +extern void register_test (const std::string &name, selftest *test); + +/* Register a new self-test. */ + +extern void register_test (const std::string &name, + self_test_function *function); /* Run all the self tests. This print a message describing the number - of test and the number of failures. */ + of test and the number of failures. + + If FILTER is not NULL and not empty, only tests with names containing FILTER + will be ran. */ -extern void run_tests (void); +extern void run_tests (const char *filter); /* Reset GDB or GDBserver's internal state. */ extern void reset (); +typedef void for_each_selftest_ftype (const std::string &name); + +/* Call FUNC for each registered selftest. */ + +extern void for_each_selftest (for_each_selftest_ftype func); } /* Check that VALUE is true, and, if not, throw an exception. */ diff --git a/gdb/disasm-selftests.c b/gdb/disasm-selftests.c index 4d38ccf..b8ef381 100644 --- a/gdb/disasm-selftests.c +++ b/gdb/disasm-selftests.c @@ -214,7 +214,9 @@ void _initialize_disasm_selftests (void) { #if GDB_SELF_TEST - selftests::register_test_foreach_arch (selftests::print_one_insn_test); - selftests::register_test_foreach_arch (selftests::memory_error_test); + selftests::register_test_foreach_arch ("print_one_insn", + selftests::print_one_insn_test); + selftests::register_test_foreach_arch ("memory_error", + selftests::memory_error_test); #endif } diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 8282dae..af5fe6f 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -35067,8 +35067,16 @@ data structures, including its flags and contained types. @kindex maint selftest @cindex self tests +@item maint selftest @r{[}@var{filter}@r{]} Run any self tests that were compiled in to @value{GDBN}. This will print a message showing how many tests were run, and how many failed. +If a @var{filter} is passed, only the tests with @var{filter} in their +name will by ran. + +@kindex "maint info selftests" +@cindex self tests +@item maint info selftests +List the selftests compiled in to @value{GDBN}. @kindex maint set dwarf always-disassemble @kindex maint show dwarf always-disassemble diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c index aaf3aee..268ecda 100644 --- a/gdb/dwarf2-frame.c +++ b/gdb/dwarf2-frame.c @@ -2406,6 +2406,7 @@ _initialize_dwarf2_frame (void) dwarf2_frame_objfile_data = register_objfile_data (); #if GDB_SELF_TEST - selftests::register_test_foreach_arch (selftests::execute_cfa_program_test); + selftests::register_test_foreach_arch ("execute_cfa_program", + selftests::execute_cfa_program_test); #endif } diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index 1a1b06a..6dd962d 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -4687,6 +4687,6 @@ _initialize_dwarf2loc (void) &setdebuglist, &showdebuglist); #if GDB_SELF_TEST - selftests::register_test (selftests::copy_bitwise_tests); + selftests::register_test ("copy_bitwise", selftests::copy_bitwise_tests); #endif } diff --git a/gdb/findvar.c b/gdb/findvar.c index de6b6ed..b3fb337 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -1095,6 +1095,8 @@ void _initialize_findvar (void) { #if GDB_SELF_TEST - selftests::register_test (selftests::findvar_tests::copy_integer_to_size_test); + selftests::register_test + ("copy_integer_to_size", + selftests::findvar_tests::copy_integer_to_size_test); #endif } diff --git a/gdb/gdbarch-selftests.c b/gdb/gdbarch-selftests.c index cb15964..f0b8d5d 100644 --- a/gdb/gdbarch-selftests.c +++ b/gdb/gdbarch-selftests.c @@ -151,6 +151,7 @@ void _initialize_gdbarch_selftests (void) { #if GDB_SELF_TEST - selftests::register_test_foreach_arch (selftests::register_to_value_test); + selftests::register_test_foreach_arch ("register_to_value", + selftests::register_to_value_test); #endif } diff --git a/gdb/gdbserver/linux-x86-tdesc-selftest.c b/gdb/gdbserver/linux-x86-tdesc-selftest.c index aa5a8e9..c5ab2ab 100644 --- a/gdb/gdbserver/linux-x86-tdesc-selftest.c +++ b/gdb/gdbserver/linux-x86-tdesc-selftest.c @@ -164,7 +164,7 @@ initialize_low_tdesc () init_registers_i386_avx_avx512_linux (); init_registers_i386_avx_mpx_avx512_pku_linux (); - selftests::register_test (selftests::tdesc::i386_tdesc_test); + selftests::register_test ("i386-tdesc", selftests::tdesc::i386_tdesc_test); #ifdef __x86_64__ init_registers_x32_linux (); @@ -178,6 +178,6 @@ initialize_low_tdesc () init_registers_amd64_avx_avx512_linux (); init_registers_amd64_avx_mpx_avx512_pku_linux (); - selftests::register_test (selftests::tdesc::amd64_tdesc_test); + selftests::register_test ("amd64-tdesc", selftests::tdesc::amd64_tdesc_test); #endif } diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 56c6393..4669fb7 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -3587,6 +3587,7 @@ captured_main (int argc, char *argv[]) volatile int attach = 0; int was_running; bool selftest = false; + const char *selftest_filter = NULL; while (*next_arg != NULL && **next_arg == '-') { @@ -3707,6 +3708,11 @@ captured_main (int argc, char *argv[]) run_once = 1; else if (strcmp (*next_arg, "--selftest") == 0) selftest = true; + else if (startswith (*next_arg, "--selftest=")) + { + selftest = true; + selftest_filter = *next_arg + strlen ("--selftest="); + } else { fprintf (stderr, "Unknown argument: %s\n", *next_arg); @@ -3783,7 +3789,7 @@ captured_main (int argc, char *argv[]) if (selftest) { - selftests::run_tests (); + selftests::run_tests (selftest_filter); throw_quit ("Quit"); } diff --git a/gdb/maint.c b/gdb/maint.c index 28f7287..b152e26 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -959,7 +959,16 @@ show_per_command_cmd (char *args, int from_tty) static void maintenance_selftest (char *args, int from_tty) { - selftests::run_tests (); + selftests::run_tests (args); +} + +static void +maintenance_info_selftests (char *arg, int from_tty) +{ + printf_filtered ("Registered selftests:\n"); + selftests::for_each_selftest ([] (const std::string &name) { + printf_filtered (" - %s\n", name.c_str ()); + }); } @@ -1142,11 +1151,14 @@ If you decide you want to use it: maintenance undeprecate 'commandname'"), add_cmd ("selftest", class_maintenance, maintenance_selftest, _("\ Run gdb's unit tests.\n\ -Usage: maintenance selftest\n\ +Usage: maintenance selftest [filter]\n\ This will run any unit tests that were built in to gdb.\n\ -gdb will abort if any test fails."), +If a filter is given, only the tests with that value in their name will ran."), &maintenancelist); + add_cmd ("selftests", class_maintenance, maintenance_info_selftests, + _("List the registered selftests."), &maintenanceinfolist); + add_setshow_zinteger_cmd ("watchdog", class_maintenance, &watchdog, _("\ Set watchdog timer."), _("\ Show watchdog timer."), _("\ diff --git a/gdb/regcache.c b/gdb/regcache.c index dcbcedd..9e20b67 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -1775,7 +1775,8 @@ Print the internal register configuration including each register's\n\ remote register number and buffer offset in the g/G packets.\n\ Takes an optional file parameter."), &maintenanceprintlist); + #if GDB_SELF_TEST - selftests::register_test (selftests::current_regcache_test); + selftests::register_test ("current_regcache", selftests::current_regcache_test); #endif } diff --git a/gdb/rust-exp.y b/gdb/rust-exp.y index 4cb3aa2..34070ee 100644 --- a/gdb/rust-exp.y +++ b/gdb/rust-exp.y @@ -2781,6 +2781,6 @@ _initialize_rust_exp (void) gdb_assert (code == 0); #if GDB_SELF_TEST - selftests::register_test (rust_lex_tests); + selftests::register_test ("rust-lex", rust_lex_tests); #endif } diff --git a/gdb/selftest-arch.c b/gdb/selftest-arch.c index 9a19f76..c258da3 100644 --- a/gdb/selftest-arch.c +++ b/gdb/selftest-arch.c @@ -25,12 +25,75 @@ namespace selftests { -static std::vector gdbarch_tests; +/* A kind of selftest that calls the test function once for each gdbarch known + to GDB. */ + +struct gdbarch_selftest : public selftest +{ + gdbarch_selftest (self_test_foreach_arch_function *function_) + : function (function_) + {} + + void operator() () const override + { + const char **arches = gdbarch_printable_names (); + bool pass = true; + + for (int i = 0; arches[i] != NULL; i++) + { + if (strcmp ("fr300", arches[i]) == 0) + { + /* PR 20946 */ + continue; + } + else if (strcmp ("powerpc:EC603e", arches[i]) == 0 + || strcmp ("powerpc:e500mc", arches[i]) == 0 + || strcmp ("powerpc:e500mc64", arches[i]) == 0 + || strcmp ("powerpc:titan", arches[i]) == 0 + || strcmp ("powerpc:vle", arches[i]) == 0 + || strcmp ("powerpc:e5500", arches[i]) == 0 + || strcmp ("powerpc:e6500", arches[i]) == 0) + { + /* PR 19797 */ + continue; + } + + QUIT; + + TRY + { + struct gdbarch_info info; + + gdbarch_info_init (&info); + info.bfd_arch_info = bfd_scan_arch (arches[i]); + + struct gdbarch *gdbarch = gdbarch_find_by_info (info); + SELF_CHECK (gdbarch != NULL); + + function (gdbarch); + } + CATCH (ex, RETURN_MASK_ERROR) + { + pass = false; + exception_fprintf (gdb_stderr, ex, + _("Self test failed: arch %s: "), arches[i]); + } + END_CATCH + + reset (); + } + + SELF_CHECK (pass); + } + + self_test_foreach_arch_function *function; +}; void -register_test_foreach_arch (self_test_foreach_arch_function *function) +register_test_foreach_arch (const std::string &name, + self_test_foreach_arch_function *function) { - gdbarch_tests.push_back (function); + register_test (name, new gdbarch_selftest (function)); } void @@ -41,72 +104,5 @@ reset () reinit_frame_cache (); } -static void -tests_with_arch () -{ - int failed = 0; - - for (const auto &f : gdbarch_tests) - { - const char **arches = gdbarch_printable_names (); - - for (int i = 0; arches[i] != NULL; i++) - { - if (strcmp ("fr300", arches[i]) == 0) - { - /* PR 20946 */ - continue; - } - else if (strcmp ("powerpc:EC603e", arches[i]) == 0 - || strcmp ("powerpc:e500mc", arches[i]) == 0 - || strcmp ("powerpc:e500mc64", arches[i]) == 0 - || strcmp ("powerpc:titan", arches[i]) == 0 - || strcmp ("powerpc:vle", arches[i]) == 0 - || strcmp ("powerpc:e5500", arches[i]) == 0 - || strcmp ("powerpc:e6500", arches[i]) == 0) - { - /* PR 19797 */ - continue; - } - - QUIT; - - TRY - { - struct gdbarch_info info; - - gdbarch_info_init (&info); - info.bfd_arch_info = bfd_scan_arch (arches[i]); - - struct gdbarch *gdbarch = gdbarch_find_by_info (info); - SELF_CHECK (gdbarch != NULL); - f (gdbarch); - } - CATCH (ex, RETURN_MASK_ERROR) - { - ++failed; - exception_fprintf (gdb_stderr, ex, - _("Self test failed: arch %s: "), arches[i]); - } - END_CATCH - - reset (); - } - } - - SELF_CHECK (failed == 0); -} - } // namespace selftests #endif /* GDB_SELF_TEST */ - -/* Suppress warning from -Wmissing-prototypes. */ -extern initialize_file_ftype _initialize_selftests_foreach_arch; - -void -_initialize_selftests_foreach_arch () -{ -#if GDB_SELF_TEST - selftests::register_test (selftests::tests_with_arch); -#endif -} diff --git a/gdb/selftest-arch.h b/gdb/selftest-arch.h index dc16c4d..f1fa38e 100644 --- a/gdb/selftest-arch.h +++ b/gdb/selftest-arch.h @@ -24,7 +24,8 @@ typedef void self_test_foreach_arch_function (struct gdbarch *); namespace selftests { extern void - register_test_foreach_arch (self_test_foreach_arch_function *function); + register_test_foreach_arch (const std::string &name, + self_test_foreach_arch_function *function); } #endif /* SELFTEST_ARCH_H */ diff --git a/gdb/unittests/array-view-selftests.c b/gdb/unittests/array-view-selftests.c index e5c0043..f618c40 100644 --- a/gdb/unittests/array-view-selftests.c +++ b/gdb/unittests/array-view-selftests.c @@ -491,5 +491,6 @@ run_tests () void _initialize_array_view_selftests () { - selftests::register_test (selftests::array_view_tests::run_tests); + selftests::register_test ("array_view", + selftests::array_view_tests::run_tests); } diff --git a/gdb/unittests/environ-selftests.c b/gdb/unittests/environ-selftests.c index 81a71ee..f770901 100644 --- a/gdb/unittests/environ-selftests.c +++ b/gdb/unittests/environ-selftests.c @@ -301,5 +301,6 @@ run_tests () void _initialize_environ_selftests () { - selftests::register_test (selftests::gdb_environ_tests::run_tests); + selftests::register_test ("gdb_environ", + selftests::gdb_environ_tests::run_tests); } diff --git a/gdb/unittests/function-view-selftests.c b/gdb/unittests/function-view-selftests.c index d3018ba..a899299 100644 --- a/gdb/unittests/function-view-selftests.c +++ b/gdb/unittests/function-view-selftests.c @@ -174,5 +174,6 @@ run_tests () void _initialize_function_view_selftests () { - selftests::register_test (selftests::function_view::run_tests); + selftests::register_test ("function_view", + selftests::function_view::run_tests); } diff --git a/gdb/unittests/offset-type-selftests.c b/gdb/unittests/offset-type-selftests.c index 3e66547..5176f20 100644 --- a/gdb/unittests/offset-type-selftests.c +++ b/gdb/unittests/offset-type-selftests.c @@ -174,5 +174,5 @@ run_tests () void _initialize_offset_type_selftests () { - selftests::register_test (selftests::offset_type::run_tests); + selftests::register_test ("offset_type", selftests::offset_type::run_tests); } diff --git a/gdb/unittests/optional-selftests.c b/gdb/unittests/optional-selftests.c index 0bcf964..8ea19bb 100644 --- a/gdb/unittests/optional-selftests.c +++ b/gdb/unittests/optional-selftests.c @@ -90,5 +90,5 @@ run_tests () void _initialize_optional_selftests () { - selftests::register_test (selftests::optional::run_tests); + selftests::register_test ("optional", selftests::optional::run_tests); } diff --git a/gdb/unittests/scoped_restore-selftests.c b/gdb/unittests/scoped_restore-selftests.c index ea7492b..bc9aa2b 100644 --- a/gdb/unittests/scoped_restore-selftests.c +++ b/gdb/unittests/scoped_restore-selftests.c @@ -106,5 +106,6 @@ run_tests () void _initialize_scoped_restore_selftests () { - selftests::register_test (selftests::scoped_restore_tests::run_tests); + selftests::register_test ("scoped_restore", + selftests::scoped_restore_tests::run_tests); } diff --git a/gdb/utils-selftests.c b/gdb/utils-selftests.c index 08feac6..5a30a93 100644 --- a/gdb/utils-selftests.c +++ b/gdb/utils-selftests.c @@ -55,6 +55,6 @@ void _initialize_utils_selftests (void) { #if GDB_SELF_TEST - selftests::register_test (selftests::common_utils_tests); + selftests::register_test ("common-utils", selftests::common_utils_tests); #endif } diff --git a/gdb/utils.c b/gdb/utils.c index f2da2df..8d86b55 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -3289,6 +3289,6 @@ _initialize_utils (void) add_internal_problem_command (&demangler_warning_problem); #if GDB_SELF_TEST - selftests::register_test (gdb_realpath_tests); + selftests::register_test ("gdb_realpath", gdb_realpath_tests); #endif }