From patchwork Tue Sep 5 07:02:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 22619 Received: (qmail 97527 invoked by alias); 5 Sep 2017 07:02:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 97458 invoked by uid 89); 5 Sep 2017 07:02:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1401 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 07:02:32 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 1C.CF.21299.50C4EA95; Tue, 5 Sep 2017 09:02:29 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 5 Sep 2017 09:02:28 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.localdomain (80.216.43.226) by AM3PR07MB308.eurprd07.prod.outlook.com (10.242.108.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.3; Tue, 5 Sep 2017 07:02:27 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] expprint: Fix format string warning Date: Tue, 5 Sep 2017 09:02:09 +0200 Message-ID: <1504594929-20113-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: AM4PR07CA0002.eurprd07.prod.outlook.com (10.171.185.15) To AM3PR07MB308.eurprd07.prod.outlook.com (10.242.108.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f767a6ef-e487-402a-05b3-08d4f42c1151 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM3PR07MB308; X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 3:EgJ2cz8ghv2caBKuzcTV7hHdyypXyreV05iSi9Ri4vzTmMzuNlMnVw6Y8QJ/ERiHfuX1aoc2EiGIvap3HZdNVXJUzViuWe4ALmSVQAGB0MT8mGBkLxeIrZvKOvwGOHxe6zqRo2UuvaXeWddUQjia3E8wqzQE6ecWM61CIWcWxWIboegD4K0AcnrA0CFWskjLklBCgjeF9ybnP8umCmudeyvHjZbyqCCoEOnQrjAYYf1SD6wXNlvLAQ+FZYvs0/Y6; 25:a9VfnNsVzmbEApFJAB13J3JAcFvbVpJHm0aQVgHuO1SWMYZmGIhyfjBjStQNmhi/lhQdPEPj7/fTU1+90wx0wEi40E/ki/dW1To5v6kuTTVLbHEaXKbVFSE7+aM92TMWSMgxd8HGxJ7ZsUHM29k4wpwpBE5P89Uqo5wjeHn7GFm3ffcnJNUgMHTZyJvqYsixgZ8SJbScE9D4VgbL+pSNVGRSxxWdOYnZnJl47RR/BjeW6CB6UgyKjXUS90mbJUF2KOvAcp6sTUku4OaFFxAvTBAjcatyS1A2GEW+W/RPVx7VgpCdU6Xyg1G8y6N0nKCmG6Y8f6Bna9FQFIcbtDd9pQ==; 31:hVspvqSKcLqNzHhQb5Z5NcFrr1LPaMw/BCwcrjt97izDu3SJXlrtFc9Sid71UErlFWXb6NOK4ytO/S2d4FIfg9+xkd5vKjkTIXlLLeU2F7ICPVLEkYFK4AOBIaENqQI02pmJfzJz89DGuNvC2YviQsa7YINYZj3pwnsS6dQHLOwIZQL++zkrmebIP2NxXzIImObWiWiMPh+LlfHWQwNz6ds3qXp0cfgEDmh+7SpoQ28= X-MS-TrafficTypeDiagnostic: AM3PR07MB308: X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 20:Hn67BkN15PRUBqA5+j77O2SyVHiuQBbq+oVK6uonWhszeBA6N/chwY0CEjfNBR9TmmyFpoxIHYSNLzB70kCHk3/HunPH17C7/Ca2Vk4AH5cj45HGNy7pUCeE8hstG/VoGleyu3hefcsREugFT4TJ3Ag4I84IzctlggVqt+PRHCCn/2H3hd1sRuZ3Fgdku+D8EGag2NF2sfJ63xlfqdhtKt+Rw0JCgWy/n6MBndtOsDnXEAULj7aLNpNG3dnCOvjff6oLTJ6Z7k0nYyQWDvtz3kLuVWJ/78Lkrx+roAmwOYnuoED1sFqv9XnMJVl1HCLcTi01zipx7K9r7cUEG01gaH57fg8s+6cmxg4xeOgl3rXd/wIeE0lmH1IU4QhXLK6w2C6NPA4Dh5cNyLHNDp5W63sUraFFpEiKUg6xlrwtPuLuHt+jQ6DITZtMb5qcMoIHcU364CAaQW6UIMMTaz9LmItI1FYhSjlLZ9mzVcSonADqQwNffYnq43XN/e3OmLgk; 4:vX+ApR40bAJDtzWVnh+rPjpEafF8WprEFfwMh2TId+zEI5WiPmcOlg0HeKMhdGtifQZd6/MPwUGE3OSn09o+RPHsUgVmwfZvrIPdiqfnfK4e0wlM49RcfIPN0XWsxFAR0MYhqnLkwaA/IA7ge2Taxmf4SsBUy20IvfGUkeBklzDdmLQgvJ9ezAzGm6y42Nv3HSaJXNV4ubprxGIVLiAsV+XfySHf6ppsX6/eeiwJLiYdZv+wHvPXH1uaJMICQxplfa12uprZr8xAibWaxw2YNqyI1N9WlkeDENKt67hrEJ8= X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM3PR07MB308; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM3PR07MB308; X-Forefront-PRVS: 0421BF7135 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(199003)(377424004)(54534003)(189002)(2906002)(478600001)(7350300001)(42186005)(3846002)(5003940100001)(6116002)(97736004)(25786009)(53936002)(2361001)(6916009)(6666003)(2351001)(6512007)(105586002)(106356001)(33646002)(110136004)(107886003)(86362001)(5660300001)(101416001)(50986999)(68736007)(50466002)(48376002)(4326008)(7736002)(305945005)(50226002)(6506006)(6486002)(189998001)(47776003)(66066001)(36756003)(8676002)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR07MB308; H:elxacz23q12.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM3PR07MB308; 23:mEApcyeDmE9GKPlok+9OhXWZ4GcKR8HfvT9/rNLA6q?= =?us-ascii?Q?AV3i/M96akV/+CG1yZuvTHx+yB2OZQiWBifX2F+QZzzclEgJpMIsNymfO46r?= =?us-ascii?Q?OoLc9UUfDmN7hPYDcMjm7qOkxWjlrY204fhyHEgBZpVRyuWGGI0WbJVMWuow?= =?us-ascii?Q?Ba8+ZO+dJ6bxQohB8YUAJ8N3Q2+afSa2V2oLQdRZ4JOp2pQ7W/ND7/l/DmCP?= =?us-ascii?Q?uBdKEuqHUKRJXKW0EhH2pxk5BRY1vzQziYFtGjEK4eDVq9K1uQNz0vufa2Y2?= =?us-ascii?Q?gsmpm2GRn5dXp7F7FkIVbK0AyuDWGLIGTGHQ2CXurJQgyd50FwII2ihr9q1w?= =?us-ascii?Q?hdm9euTl6J/6IyeZ7d3r585Xu8b26S+km7nn7YlGsoeyEEmIwWnTSGo7vi5c?= =?us-ascii?Q?bOBwpnbyh0uVlxX6jQlwxFDgsh/3iAqfkrirLp0qYo4Ryf/mS4/opi8QAVa1?= =?us-ascii?Q?77592D6eaY2pSj5YhMla/ohWRQMVAdPSXoqhf9XSKPyMiWe3C5VK6F5SGA1C?= =?us-ascii?Q?jnr0pzK5gNC7rWNNN8DOZvfLZhtfe55hXEzaQB7mHrQSR8EMV3WCyquG4vjF?= =?us-ascii?Q?c/q4U6rMrQGfXLErGdutR//j3HR0R1n0K39AvlYjs5EyJeDfuu1tZZxrzTaL?= =?us-ascii?Q?Lym07nGLswaZEs28f27CMA8SxHVIIer6Thgv4qncKSEHKWO8i6KP6la8oLEc?= =?us-ascii?Q?Pfk47uR1Pcwj0DV23q5kosCjkppkRrvGnnPRuVn5a4d2wdhAuCVX9VXLWBIW?= =?us-ascii?Q?gef2pOo7twPQOPI1t7V+Yr71Fpfa7hkcr4E+Ob30pRNwdsHip2CbprEy2w2A?= =?us-ascii?Q?ACNUD4NlvXDQ7j+764CvhJc17E9D8h8JC8LS2ODaUodNgoAG/KSiaauRZCo5?= =?us-ascii?Q?zFs05PS9He4LaTV6u5+U6Di5EBDm7pqrUxpqDeVTjNgAY7Ps2yxuKsksjmep?= =?us-ascii?Q?ClUaU31N01PkL1UoxKmhZS1IITCemOUbsw6huvg1ftHmmp2BHO4fqWhu/4SG?= =?us-ascii?Q?bsxYGO8WQB6+DGNgqL4oeMD/stlImx6HPM2nAjxsuhHrMbg15Xg0E8fIMlHT?= =?us-ascii?Q?lH3doksNxLKI0j0XrOg+eHbTqilFxN56b+sAf2CvDX1OogZ/D65ZDNi/ZyUy?= =?us-ascii?Q?fPBpRZz9a1Hb0FBfr0c5av2XaJ4NrycrPVdT3jFhqriyFO8o0M/Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM3PR07MB308; 6:FtX+DzMloW1ZXggZJiNns7mpP8ymHBtNhwXtzWxjse/s6Ov9EtgaHgkb5urJJzljs0EAX8n3KnHMieSq5A6kducfbNb5oYb4u0GID0+4nKKqcdD9MZmXkq6aWjjHCDrdBcs3Undr+U52eflz/c5xCyK1QJ4SHjrBk/S3oI/yYzgZeYCd86rtZnHn44G3Sd38tDNUNox9F/YntPlwKIXP5OcgqU7oLjYroTWmAtQKz3aR9ppVLEqem4eqdTJyDOvW9mGX9/nKwNidwoAENneaBDF2nkbbk+dW/EBUJgvhPKQKcRIH6NUg61SCRCql3SwhMQGP/cnxK6FB4iqvubHIpA==; 5:TPPzqsCLvAJAl+coig92qMpzMYppzxtbM6Oe5AdnYMGR0YPU2hnohnASrqa3zNZviV5dtQUXu0OPniuXnP+BTZv7jiiptVl8jQWq5r7WSR0P8Xh4TzytkGf4AHLjVpAx+4kc4qZiWTuGrJxzDbjByQ==; 24:iqKCu2ihVxfBz+IHQB2NeF9OcIndEFPMtaZNxqCpji4KKnMQ35VCa2bIBmqEDtDYhIT/EO60VzEakoMiyzKn9YQWLklSXwsytI8sEfKcjn0=; 7:DaVbUQWqSJXq0ZD2U8QkzN0y7Iv8IcJ72AwybfF4D8iRqbrdevxvGx7+eir4iIOaDUXJ/MyORnpZbzqLgEqVKUSF3dBoNn/WFh+gYZ6yu/+69xsXcgXGiNwXcBrDlF47Jcbote3XKjemHHufNhQew4SQU1WZpScqQUEDHreQgAffLuhTWZwnUMZcKQWpZGAlVTWaL9k5+LSAAEirQUt3Mi+liDGUEDW+b7eCPOCtc4Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2017 07:02:27.0780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB308 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes My compiler (gcc 5.4.0, clang 3.8) gives this warning: /home/emaisin/src/binutils-gdb/gdb/expprint.c: In lambda function: /home/emaisin/src/binutils-gdb/gdb/expprint.c:1055:35: error: format not a string literal and no format arguments [-Werror=format-security] fprintf_filtered (stream, mod); ^ Fix it by not using the passed string as the format string. gdb/ChangeLog: * expprint.c (dump_subexp_body_standard): Use constant format string in fprintf_filtered call. --- gdb/ChangeLog | 5 +++++ gdb/expprint.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index de1945a..19882f0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-09-05 Simon Marchi + + * expprint.c (dump_subexp_body_standard): Use constant format + string in fprintf_filtered call. + 2017-09-04 John Baldwin * configure.nat: Add "x86-nat.o x86-dregs.o" for NetBSD/amd64 and diff --git a/gdb/expprint.c b/gdb/expprint.c index 2c16b49..9e04f24 100644 --- a/gdb/expprint.c +++ b/gdb/expprint.c @@ -1052,7 +1052,7 @@ dump_subexp_body_standard (struct expression *exp, if (space) fputs_filtered (" ", stream); space = true; - fprintf_filtered (stream, mod); + fprintf_filtered (stream, "%s", mod); }; if (flags & TYPE_INSTANCE_FLAG_CONST) print_one ("const");