From patchwork Mon Aug 28 21:40:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 22386 Received: (qmail 119939 invoked by alias); 28 Aug 2017 21:40:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 119914 invoked by uid 89); 28 Aug 2017 21:40:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=Really, H*r:sk:EUR01-D X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Aug 2017 21:40:38 +0000 Received: from ESESSHC002.ericsson.se (Unknown_Domain [153.88.183.24]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 65.46.21299.3DD84A95; Mon, 28 Aug 2017 23:40:35 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.24) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 28 Aug 2017 23:40:34 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.localdomain (80.216.43.226) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.2; Mon, 28 Aug 2017 21:40:33 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [pushed] gdb.base/commands.exp: Remove unused global references Date: Mon, 28 Aug 2017 23:40:26 +0200 Message-ID: <1503956426-19399-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DB6PR07CA0154.eurprd07.prod.outlook.com (2603:10a6:6:16::47) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-Office365-Filtering-Correlation-Id: 95b046f4-d300-4886-fe29-08d4ee5d69ad X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 3:TOCzi3nsG30COl2fhYlcNA6b6KwHh6ncFnitdvkLiPIqlF5UlgZfp0YmONzo15XMNGmQGdQY5k4EgyzkHgAwVWy/9iPstwYYNG+Y9C+z/ZH03DgSFxZ4KdFktSlFW1xLD/0hsBByqpGr1bKkKcg6hgbbsFV0Zf3OE7p/R49Th++WTgFhdi1bzwQ9n6ZGhew+o5FpBAlOlf6qsxByGZaf/rLiZRTkwPjNYJ0ZTGxnlb7YrHXYaRUjr/4rITEt1ZW5; 25:2GG12g4eFMUOjB3a/PHtwy+ithehDsO2gr+3WFk+nmewBQm+jlsFGSFfQW+ivmJmpVo68kdYyoui84PhLQvb6X7rb8MBLNVke/KtVNoBR+H+i4aTo0EhiJBt30SfVOPCaDwh0nd2I1qE6SEdwOuP3bP4ENbrfwE9kHRQdhkq1y0bFYccQVtNQj2+/jJL2oXqtqqoLqtFNBIm7+Dry7t9wviExxvCbcqEYC7uZUyHn4Ltx3GlXZ4wfcBQT12Jm0cQdtwPEPNz793jLLTt9eJlxPLmUdmxXGxZjknVYZWpUZuo2QVx0caWlkkLsiTlL9AztQguHdOEiSWfWiSMRZM5ww==; 31:zrOPzo1o0/9GgineJ8JNtzte99CesNkyZCUUgajwDCJRLd/cJCCY7F5UHxkcqNbQdBLHe4vbu0IeFUjxA0hlNEb07nbnaoZHfieF28HrLYk3I6AtBQsDXuKQWd0oik6l3Um+B1KUwfM2kik7ErZIIGAGH5Ndg35f+GFeLr2BYYbaEM9pVRAn108hrOCmWeTVdIwn3TkJ99oCX86ttRQXdKYYi0b4Zg2KfQCjX6numwU= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 20:57TQ43038TQ2fHDM+eTJ1RjGBO5+XqQvSTxelw3EoUQiSAWNnRYmXyocbO0TkMOIgrzqXR6k9c+hRC9rt5QCBb5ixvWbdZUOxMBncCNeHzZJBc2BFXDvcG97IbL561QnQ5WKY1r4DQVcjViqM5djJFcezlu3qrmyVjsjdCoDWEYNpcG0RA+TEJKHUGfXZAcWIQ0nvnTi21BFAlSj/IP0jitEEpDI07ubAI5y+HPWwsO1aS7OnJ8dsjnjdgwSkHfmGpW3LZh6sEI07U2w9eCEQlsz433jSa6VNEos3ArcujTtr28LiuAt2wqNGRcRxuYHa6AsIKdqlvaRF1a0fgL6ujpJQA4hkyA3TtTmzP25ygcudwrTt6KJUN06YczWPU8RwhVqN7UDSNdSPZPYEV+PDyIVo1wJ/F11MapXXzFQ3xdIUUdWmU2dn1pTnprRriDC0TiLV7PGtrLxpJH0OtZsiuP5azKiexj8J8R00boH2r0piCwyn2MbvjZVOUtVfUhZ; 4:dMhK+J0DSoDsXGg9Uy22liif09qENIHBUuYq0NRnQPj1k4tmIjpLfSDPh3MsRahPsxiE7OmT5K1yD97eGle9HVXb2HkOCdX3kYazLi8luyiFVpDcbS+CYW/5+SDsGRjcL8xce36iZzUX4pZlTzKII5IOhIvVoAoKXxlhLoR/yCQhC0B1OyBnyH1NUenSjuSMiG+8y7r35vFptRIPerZKoArYoIdOB+kpGJ7ddrXCh82cADs9QaqdRhX3OpLG1dTBhqwmOenbNqsh72h7JF756tOlkimJ2Ax/LpPO2H0AG9g= X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB320; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB320; X-Forefront-PRVS: 0413C9F1ED X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(199003)(54534003)(377424004)(189002)(36756003)(7736002)(305945005)(48376002)(50466002)(66066001)(81156014)(8676002)(47776003)(81166006)(42186005)(50226002)(68736007)(50986999)(106356001)(5003940100001)(33646002)(25786009)(6512007)(2361001)(105586002)(2351001)(478600001)(86362001)(6916009)(3846002)(101416001)(6116002)(107886003)(110136004)(53936002)(2906002)(6666003)(5660300001)(97736004)(189998001)(4326008)(6506006)(7350300001)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB320; H:elxacz23q12.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 23:GgOhEd3IsduiMkTwn1gZc97xJcpWsPfO0wSG8Py2cQ?= =?us-ascii?Q?QRPz26a3PuvUcYrf1tfHpqvJQr7X46FWSTr4dsjy4Sb0iFz1fbAJMIBeFBHD?= =?us-ascii?Q?HPLLCqvGNHpNUPinzj3fxFWSHd5pkBUOylbtFs50oorrhbqc6GXSze27JpJ5?= =?us-ascii?Q?rmRSHUuyYU4sqopGF1vbUyxSxVUpf05osr1XzY2hox+6BbroCfUb+JqSJnkq?= =?us-ascii?Q?dRetW6+8U5SSOyuUhepEMxmFEsp+PNRE3UnSaMGCNsM5by1/TclfsLHoPFDh?= =?us-ascii?Q?xUYlvZ6h8KW5ht+kxRcn+vPGvcn8u3lyWLqoYc1mVJo2PhThV4R4Z45ojvQ2?= =?us-ascii?Q?4GyaIJOpupJOyg+mkkrXbrmdwy3FXvaWmF6eFL4S/rv5g7bjxqcoJ6t7Dri3?= =?us-ascii?Q?NJuBurbhvX+DluWw+p9/a05FBbl994RbpPBwhOuDbP5gplctErt1fSPdIxLs?= =?us-ascii?Q?nu3lz/roJIUowsehKncyhNCcK2dTAKdSHLcJeV2WUNsynTDRqO1DmGaXnEk+?= =?us-ascii?Q?TdmSCgQeTk5Z94EAytZ9T7+lremKwxeBdXY2PC4vJRlbdQvp/wZoe3AZMith?= =?us-ascii?Q?P9VO3+X3mf1K/UhPsLSLaNjn4C9RWnfDZvyA6j9+Q4ulqh92kCW/KtH+86wj?= =?us-ascii?Q?gcreU5lSuCqvRIMV7oQITmAZFHe3QYDNc+imDeweizi7xz7cx+3Nq5u93An3?= =?us-ascii?Q?wljHQsHsQguJ7GgSvIawMfKu8iqFFpFVdoGCVBHizaqk6XMt0PqMo5G+smS3?= =?us-ascii?Q?NlrvEE6Ko2ZVWKIVIBigV033pRktTXBp5ERUNx0IjuBFrLOKtWOfA1buevnC?= =?us-ascii?Q?RaCK0Wb347S/KPTjF1yD0Jad2vDJN+tQE9JDhVUgRtaUCtd9VWVR5/4IfCTk?= =?us-ascii?Q?8MYrzuOt+lAyo/KJU9GghfMoUcJjfpp1afh4rsyOdSNMTW2RsR8FWJlw+F7H?= =?us-ascii?Q?JYXwOyAM2uP784Mtl0j7JOf8uvTVchwFbtGmBywHEsKzdgkTk9C0Lg+yyX24?= =?us-ascii?Q?l+lMEczUfbfNDcFFPDHQA3o3IXME90N7Zmx3JGSOz6Yj1p4VqCzRk+iZbXRU?= =?us-ascii?Q?LtviFZvl4QE3GCg89CmU/AVmbT7tu1FHKsvegO4jyKF9FUYXHaRrp1dzgLXM?= =?us-ascii?Q?Y4r1iUdMUezkSHOmcdgglc9LwFVwnUFzo+JoCxceHj93FG9Qu1tQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 6:1i41GS5zMcot8ykPcKUA/5+wCoIdnQEVdDRG0Q4sOj5LEJL53cXtAdos2CXlcfiH9Ao8KshJoAEVoWzC6DPbLLtR4pRsDbd55eEReVX8sjgKoH3coJAKPUtNaQnbGaemne1l7DGxQi90yD5UEkEMC/fO4hBcV5zxh4248nvOwt9KTIhuUITNYhkEne/K6HLUX3F9JzvEE6tQ3cAsYj+vzw6frw0jrRVhWRDTEv4FIDaq0uyBt2Dy2pQw53bFoGtLRYgZUBOBySxGgvYrTx9jo6TIB1KJRO6Ju44TDSkY8jQrgPCPPrK59UdfrtWF9seOjH1yYv7FmokspVhBwh2m9Q==; 5:HSf/ml0M9kXMho8a7PF7XJwF6zHqQ1uz6VY+0RwXfiXGdhhpgozejHSixt8jCCQwi+OfbJGZR8LL6OFa8UATcl5L/pq9KFUVXTjwzka/FPnJJg0SCB83NXD/sVYVhFQcO3YDvqNKGsADqNb/MW62YQ==; 24:crxG8ROPGQ+Wiup8Q616bIeO5McFRQcQw+ijrUCBHMwBDdloc64r/LymvuhzzUwmuY19o7tsjTjaPiLZAxyclpClQjtAe/Jp+ii+ZMtqGyM=; 7:0Ov/u8CCK9b4vOJ7HCVlx9o8CCQxkZDmMpFb7hA2V+SuILsqmFHeanODyA2PNmVNQctJUlJFixK4eSkBLHX+rOIFLOA65Rxfgeo7i0uy+9CYHQS5p/lDDM8Ra8bX9mSGCsuDVhKGiPapcOeu6doOAOdsx5BXa40emF0EgdwtUNbCJqfw/tQ4A3TlM05wQrnf1QYi93+5xhi/WFDbRFnBIkQreDQu241xv6fuMekKS4A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2017 21:40:33.6118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes There are a few unused references to the gdb_prompt global. gdb/testsuite/ChangeLog: * gdb.base/commands.exp (gdbvar_simple_if_test, gdbvar_simple_if_test, gdbvar_complex_if_while_test, progvar_simple_if_test, progvar_simple_while_test, progvar_complex_if_while_test, user_defined_command_test, user_defined_command_args_eval, user_defined_command_args_stack_test, user_defined_command_manyargs_test, bp_deleted_in_command_test, temporary_breakpoint_commands, gdb_test_no_prompt, redefine_hook_test, redefine_backtrace_test): Remove "global gdb_prompt". --- gdb/testsuite/ChangeLog | 13 +++++++++++++ gdb/testsuite/gdb.base/commands.exp | 21 --------------------- 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 83261df..aa1d6b8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,18 @@ 2017-08-28 Simon Marchi + * gdb.base/commands.exp (gdbvar_simple_if_test, + gdbvar_simple_if_test, gdbvar_complex_if_while_test, + progvar_simple_if_test, progvar_simple_while_test, + progvar_complex_if_while_test, user_defined_command_test, + user_defined_command_args_eval, + user_defined_command_args_stack_test, + user_defined_command_manyargs_test, bp_deleted_in_command_test, + temporary_breakpoint_commands, + gdb_test_no_prompt, redefine_hook_test, + redefine_backtrace_test): Remove "global gdb_prompt". + +2017-08-28 Simon Marchi + * gdb.base/commands.exp (user_defined_command_case_sensitivity): New proc, call it from toplevel. diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp index 4cd5f46..c934052 100644 --- a/gdb/testsuite/gdb.base/commands.exp +++ b/gdb/testsuite/gdb.base/commands.exp @@ -34,7 +34,6 @@ proc runto_or_return {function} { } proc_with_prefix gdbvar_simple_if_test {} { - global gdb_prompt global valnum_re gdb_test_no_output "set \$foo = 0" "set foo" @@ -62,7 +61,6 @@ proc_with_prefix gdbvar_simple_if_test {} { } proc_with_prefix gdbvar_simple_while_test {} { - global gdb_prompt global valnum_re gdb_test_no_output "set \$foo = 5" "set foo" @@ -83,7 +81,6 @@ proc_with_prefix gdbvar_simple_while_test {} { } proc_with_prefix gdbvar_complex_if_while_test {} { - global gdb_prompt global valnum_re gdb_test_no_output "set \$foo = 4" "set foo" @@ -107,7 +104,6 @@ proc_with_prefix gdbvar_complex_if_while_test {} { } proc_with_prefix progvar_simple_if_test {} { - global gdb_prompt global valnum_re runto_or_return factorial @@ -139,7 +135,6 @@ proc_with_prefix progvar_simple_if_test {} { } proc_with_prefix progvar_simple_while_test {} { - global gdb_prompt global valnum_re runto_or_return factorial @@ -164,7 +159,6 @@ proc_with_prefix progvar_simple_while_test {} { } proc_with_prefix progvar_complex_if_while_test {} { - global gdb_prompt global valnum_re runto_or_return factorial @@ -289,7 +283,6 @@ proc_with_prefix breakpoint_command_test {} { # Test a simple user defined command (with arguments) proc_with_prefix user_defined_command_test {} { - global gdb_prompt global valnum_re gdb_test_no_output "set \$foo = 4" "set foo" @@ -384,8 +377,6 @@ proc_with_prefix user_defined_command_case_sensitivity {} { # Test that "eval" in a user-defined command expands $argc/$argN. proc_with_prefix user_defined_command_args_eval {} { - global gdb_prompt - gdb_test_multiple "define command_args_eval" \ "define command_args_eval" { -re "End with" { @@ -416,8 +407,6 @@ proc_with_prefix user_defined_command_args_eval {} { # user-defined command (or in this case, recurses). proc_with_prefix user_defined_command_args_stack_test {} { - global gdb_prompt - gdb_test_multiple "define args_stack_command" \ "define args_stack_command" { -re "End with" { @@ -473,8 +462,6 @@ proc_with_prefix user_defined_command_args_stack_test {} { # used to have a hard coded limit of 10 arguments. proc_with_prefix user_defined_command_manyargs_test {} { - global gdb_prompt - set test "define command" gdb_test_multiple "define manyargs" $test { -re "End with" { @@ -707,8 +694,6 @@ proc_with_prefix bp_deleted_in_command_test {} { } proc_with_prefix temporary_breakpoint_commands {} { - global gdb_prompt - delete_breakpoints # Create a temporary breakpoint, and associate a commands list to it. @@ -824,8 +809,6 @@ end" } proc gdb_test_no_prompt { command result msg } { - global gdb_prompt - set msg "$command - $msg" set result "^[string_to_regexp $command]\r\n$result$" gdb_test_multiple $command $msg { @@ -972,8 +955,6 @@ proc_with_prefix error_clears_commands_left {} { } proc_with_prefix redefine_hook_test {} { - global gdb_prompt - gdb_test \ [multi_line_input \ "define one"\ @@ -1007,8 +988,6 @@ proc_with_prefix redefine_hook_test {} { } proc_with_prefix redefine_backtrace_test {} { - global gdb_prompt - gdb_test_multiple "define backtrace" "define backtrace" { -re "Really redefine built-in command \"backtrace\"\\? \\(y or n\\) $" { pass "define backtrace"