From patchwork Wed Jun 28 14:00:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 21315 Received: (qmail 35546 invoked by alias); 28 Jun 2017 14:00:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 35304 invoked by uid 89); 28 Jun 2017 14:00:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1328, H*r:sk:static. X-HELO: mail-it0-f42.google.com Received: from mail-it0-f42.google.com (HELO mail-it0-f42.google.com) (209.85.214.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 14:00:20 +0000 Received: by mail-it0-f42.google.com with SMTP id k192so2117406ith.1 for ; Wed, 28 Jun 2017 07:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Yy5XJpiRnhBO4sAdTtAIX84nWxOWOqHRJJnYnu/JV9I=; b=hh9K7AlRA+C8eG2K7pKnpyJbQyFlza1dmFfOqD8lUeZ+T1z9v6QSrjxRUPsf7fCd99 TdYs+GzAY3uFDaXjK+pPTjzIJQptMYoyKJ8GzUpj9ONHKumOZUrcoTGpMbLsqY6prqUa DXmmodatpDj+hQGRjzEz2OZaLFtxhoKamZqvJojqEkdxMLBCLxDmbmRQRCTpVJBbv5rT w7akKEPG/gJ/850uterz6TOPDbkQcKMvwxqfWv/NN/z60cCBtCFf0p90osy5fl2lszsA EJUQv11hy1VnWvkk6Mf5kKkTR6DcLH7VQcgvlv8NY6dSWEPklSFuu5VZnGTaNJG4gPgg oxZQ== X-Gm-Message-State: AKS2vOwdRLmXTnd7Ew1F+VBPbIJfuYTT6Q1Tr9yjLkDbrTywfzh0e4sU X/gLd/mfV0bgGBr2 X-Received: by 10.36.137.11 with SMTP id s11mr8489954itd.68.1498658416889; Wed, 28 Jun 2017 07:00:16 -0700 (PDT) Received: from E107787-LIN.cambridge.arm.com (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h136sm1169991ioe.39.2017.06.28.07.00.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Jun 2017 07:00:16 -0700 (PDT) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [OB PATCH] Use obstack_grow_str Date: Wed, 28 Jun 2017 15:00:12 +0100 Message-Id: <1498658412-32015-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes We already have macro obstack_grow_str, which is helpful to shorten the code. I'll push it in. gdb: 2017-06-28 Yao Qi * mi/mi-cmd-break.c (mi_argv_to_format): Use obstack_grow_str instead of obstack_grow. --- gdb/ChangeLog | 5 +++++ gdb/mi/mi-cmd-break.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ae79dc6..d110c34 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-06-28 Yao Qi + + * mi/mi-cmd-break.c (mi_argv_to_format): Use obstack_grow_str + instead of obstack_grow. + 2017-06-28 Doug Gilmore PR gdb/21337 diff --git a/gdb/mi/mi-cmd-break.c b/gdb/mi/mi-cmd-break.c index 9412af8..560174e 100644 --- a/gdb/mi/mi-cmd-break.c +++ b/gdb/mi/mi-cmd-break.c @@ -141,7 +141,7 @@ mi_argv_to_format (char **argv, int argc) xsnprintf (tmp, sizeof (tmp), "\\%o", (unsigned char) argv[0][i]); - obstack_grow (&obstack, tmp, strlen (tmp)); + obstack_grow_str (&obstack, tmp); } break; } @@ -152,7 +152,7 @@ mi_argv_to_format (char **argv, int argc) for (i = 1; i < argc; i++) { obstack_1grow (&obstack, ','); - obstack_grow (&obstack, argv[i], strlen (argv[i])); + obstack_grow_str (&obstack, argv[i]); } obstack_1grow (&obstack, '\0');