From patchwork Wed Jun 21 20:15:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 21186 Received: (qmail 96184 invoked by alias); 21 Jun 2017 20:15:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 95359 invoked by uid 89); 21 Jun 2017 20:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:15:42 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id C8.49.19050.ED3DA495; Wed, 21 Jun 2017 22:15:26 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 21 Jun 2017 22:15:26 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.6; Wed, 21 Jun 2017 20:15:20 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 4/4] main: Don't add int to string Date: Wed, 21 Jun 2017 22:15:08 +0200 Message-ID: <1498076108-29914-5-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: HE1PR0802CA0016.eurprd08.prod.outlook.com (2603:10a6:3:bd::26) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1275636b-899d-4624-ba64-08d4b8e23de3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 3:kEId6asfJjaEKfXl9TEnM+Pu/rZX5pe+oQM82+bsJj2LnbQR9H6Ro3VGQnxlQPwNOJObtPW1zftKzWOJ6ZTIp2AZB+M9pLQAmT0X97WsR4pykt+ZXAfqQH/VjePTPbHnjRQjHsFWgYpKlncahA+jULgjrX8vTWwpah0WgFTtvo9gc16mLg4wxm5ZYzpUq3sdpj1hqiKiYLNuofWT5DsM9KjxEFyU7pcYjRoppMd0lsRjBWtxsYGNqQdtzhPNDKBKdbjuDl4oItEI8RSvOfW8iDIQk5ZZxlCCr2eHsnN3smGp5nST6SycdQdBBSuDFWiqoy8NlOwrC0W/3DxLeBhz+g==; 25:zXZ71Nz94xDwweqQvsrTNTrFikmZl3IsegTFMIqWtGwMpnvlkcxXyvDuKyrT2fmp3jJSwmrkhDeLmwwmy3ifQa+uoq9mAEiU3L+c+Yi85r3Hz8pi5dLJlpNB1WvfDEEDFbL9ra4r4kdweYV79yMrvtMGylyABbNLU9ZS4KHWWg0sBjT0TVZuq5TDaNLQExjvSPCYflM7YcFAThjpsC7xYHzjenXATYHc6uunMaYrdCFlgNw1uE6wBQGC+DtwTm9XoMtfNGAkd2KYf945sSQDtdjFBBtqbYgYAgVVRUg0j58Ahsbv+aN4KOBNNDEHTDalFn/ymm9JsbKyLdgd9Nxzl+rqlHxfFj8337sE6yMpuAvfSdvw9UfmUf+12a5NZ8GAuQ5wJ3Lb/oVIPdn4UuCfs6mG5NCWnUk4iqAH44yFK25+j3bt9xBAvndHwam3cU6UfO1KxPxrtzDe7knpQRe7fLO5AEXzfGcFl0Lmk0RGGl4= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 31:HWgG3IZPnbec5zs81L8z/vWhdC9i9Rh3pZnfjJbagOVGL5w3oHpwPJAI27ZvSo9bjmnDpFzNpKVKge2IYpVvmVZtMacA4t27Zt4ft+j9QWNd6/wDKnxHHIu5iAQD7CAfbDadpcWBXt82NegefhMIjr7fUQgxJr8g84ydy+1ZwUnydpxhN9XcDrsZ5Ak6Kd3BWgFR3HPKDZhG53TB1M6An8JW+Z64IzCsx/Wr/SVe7r0=; 20:8HnL5U7f1TuAKNroMaMBawyFPbD2GkuQCkhKbtG1gcgH0wI6P1vTSQnfuAyPT654HJWx2gnRERB5PAMe1WB/CJ/xbl60vnF18nIwSwL/k/dI8d+Rf/z6dRjmyF/K3hMBOkjFVXzPe8+NpiHhG+5jWSCp44qLq/kSrwABNvjrE2qcJhhOi9JoQ1XXT+qlYuvh1vtcS9vkHXxR9AhC1usG4ni77LFAS42cc2oD406Eoxi6zBwwPmP3e9s31dIYHtGQWt09fN1114fVVhdtUzd9hyjP8WLoFwlyGtNWY4uGs1Eo47z3b1IfEyByaeKR1Ix5aR5ZdOAUxfmkMqpOokNLn6shmiMh+bURsitCK/7EPZT8MLjAfoOdqFZL7tRE++uQ3c5yjdU06NXtCRX9t4DMptTF5ozCny6vJZ9EX/xoM1qk0wCKFY31VZBL3/jkfBVSJcn9dEKmtXqjoWLkch4f7fgdvghHAdxLlJ3Wgx6HRhtNj9ZVATr/QPRcmrEVBvEs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(788757137089)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB320; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 4:j77BmQ/QCjzxO/gSBmWN8iXmwfZ/0qqdtCfMthUcRTp?= =?us-ascii?Q?fgRXqrBLGWbZ4ezyQ/7+TpBKbzc75zZb4Jywn74cZnY0fu/xRQgVd0i1ICv5?= =?us-ascii?Q?0hU4AYrt21Aw8sg1G7PuuzBnRzUXcXJrDm2RYiatbf68qRwWmV3aMNqFEAES?= =?us-ascii?Q?Pdr1jjTKZ9bB5y4pIFVIuC1KmRr/WgBcjNA5Lv/TW7Bp8bomhSqJHp1MlV68?= =?us-ascii?Q?PK0qD5wkoE6dfVqaXUylFo8PFcl55jIvl2IQKjeu3jgOeHffretkHlYduom8?= =?us-ascii?Q?olmZgn92XWgcrgfoJtgOEkW7imgLKy0ss5/kflIMmAgneY21NQk3hfz5dygY?= =?us-ascii?Q?8GL/Sebc9BD6Dlz7T9XOQhpva5Jnm9Xgb6d98vVM4QtakeFsIiWJw6PagNrS?= =?us-ascii?Q?lwLfNKb2CMIKmOt0TBNL/gae29cUN8daWjxlE22BrXrA3nzWCiY343IpNE01?= =?us-ascii?Q?iABDaQKeanlA6axe4OlsCPl2ZAk/e4PeFKysUndg68SInF5lmIO3m2wLWzK+?= =?us-ascii?Q?i6XlXAE3KRA5limrW0vA3s8WLGycIHn5gW8WKYsNesQrIgFpfMCAaeDNKOqJ?= =?us-ascii?Q?P77X5RsowyULE57wmKZFcILut7ktqVW3+xXoB3HtdavCh0X/Fs7TtrOpe9Jq?= =?us-ascii?Q?n0sKc10hAtIAZuAVg4ekvRarBxxfue3ObyQjVFfNbk3/iv6PGtJG0JveSVCB?= =?us-ascii?Q?MnNs2eDyDD4Xxos/8r4OBrevDTk47Pa3LdaFDXxxMCk4WDePzWmtmKPyhUWP?= =?us-ascii?Q?IjdiCOzvLP4EIm63j/FqohnOMrPst3lPMQC/7/8l7qn5IwgN7SAjxOXjcgo7?= =?us-ascii?Q?NB/dYkF6na1FieqopfJoV1y/Wcj0DXnCIBpOcS+f3O+JuuvH3hqeeSPDhBKB?= =?us-ascii?Q?lO9SCD3RpvRC+RHnNc1vJvhAUNdasSAY3OI5hiTsvbIuu2MEdeeihDPjNY0f?= =?us-ascii?Q?yf7NoNQ9PejuBapzby+kXFaFbrqWGcxBVjNHg2/w/RwLSsifsnOzeMMJc9vN?= =?us-ascii?Q?hhJPTv1JXF1GcDENwZHHZVqfPwPwaCca+BcUn2D9THMupZlZ8A77sFhzAXOQ?= =?us-ascii?Q?nSRuBVWxqFaY947TQZzUzjMnS+7u2jgbeT0YaB28pOLG4V9fejea2CMYiUJQ?= =?us-ascii?Q?ma0EOoPcWMybkYFxhMsXXSupa2F+ZURPSwfSnsCx66LzWSNAhEIm5b6OYWyC?= =?us-ascii?Q?IMM3gFN0tDx8rxzqcaiddqUiB8DEOdwCEtV0PbQ9XC/mkAI6yA4p6dHkzEnQ?= =?us-ascii?Q?5g3uNuvi0dwGWYww=3D?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39860400002)(39450400003)(39410400002)(39400400002)(39850400002)(305945005)(86362001)(5660300001)(6666003)(25786009)(3846002)(6506006)(478600001)(6916009)(2950100002)(966005)(36756003)(8676002)(81166006)(189998001)(42186005)(6486002)(38730400002)(110136004)(107886003)(50986999)(48376002)(76176999)(66066001)(2351001)(2906002)(7736002)(47776003)(50466002)(4326008)(6512007)(5003940100001)(2361001)(6306002)(33646002)(50226002)(6116002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB320; H:elxacz23q12.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 23:/rVhvsm164yKz3UcuFHj4UwmSI9Qj2x5nqkKLX+ph8?= =?us-ascii?Q?Y6Shq0mhVTJqzOLk+aCOOC8wsYo15pzh40do5uYWQ+lPtMAYteA8qCKmq4ef?= =?us-ascii?Q?AoqDy8boOflwFAHfP014ojB72ast2m+mUIQ5e9PZ4V87zGZtoIxrDEfe3l7Y?= =?us-ascii?Q?1LWYwrS1cS7+4hcH4PUrvzRIRoz0A412ku/ZIXgGzX7Trz+H7U6X+WTIdc/H?= =?us-ascii?Q?jiNYhpTSirJlHCI920l+dYjtfecXsTps7J+N+U/Kdc/qfBLfNEz1aEyH8DBk?= =?us-ascii?Q?MC+oBXfzIn4x55fS9DHO0mBRawoml4IyUTRwU2ldrpyzNjDIyYzgiUMMxQc1?= =?us-ascii?Q?5UGa68VyWhoPZWcvUmtIm0RsREs5JSKqXM78u5x6hFdS3DyDcYm7lbwRiB9C?= =?us-ascii?Q?dxxB6z3s3TywTCGEqdhRwsaf47uSGGLWBGpKUuHH8zWkOPt8Ahi5kYeThuzm?= =?us-ascii?Q?YbLPtzdcoTxFMgxeUUuxWhk07R854bzy338812367K0H9bLADZBIFVJmrAvj?= =?us-ascii?Q?8+vUMTd6v3CEGMENKkuS54lP7RZfSEs/hXk5OpRZUlwFVtDgot3/7sthMe8d?= =?us-ascii?Q?LTtp/NwLZA5NWMP50j1AZ5VuEDJsV1U7hbV2T0e4gMhCEu5PoIbGApdcDVrJ?= =?us-ascii?Q?NEl1xYe9qkmJxIM+ouZQgUpztkSaAGpyEHrB+dt8JA4muMpbtY6odbRLjWvq?= =?us-ascii?Q?UTBdIlTqbzPgKdcmYH5dK0cTZ3FtxHJg7zY44KKk8KB1CS2qw7ApmAPJmq4f?= =?us-ascii?Q?w17dkjmYDPkkROJ/gUGLONZwD90WMb+2X1Z1PXSUeNhau2H+OHUuMwXrk3rA?= =?us-ascii?Q?dqa8IBRQ3h7czllPm8L9SXoYu0CmZVcX3LGWdoRPiPxsRmEY0pnMg07E7AG2?= =?us-ascii?Q?Tn8nT5PxgS/isCUThkQS1iTIIZsTGsEfVySSQlnBAMHAcLJ8ZRPxJGdMbjsj?= =?us-ascii?Q?+rrp0VyxgbNP0Wgr3p3kLjCgrZev4waKxWqrG28wh2GlsntfjeHa02/o8c3S?= =?us-ascii?Q?8ipLeumz0/ER1NtWCPYM0cm034XV2J62q/J1ggFFZJbaKAB716MfE0SS/KY5?= =?us-ascii?Q?DGOC/uMu6p+xWlazx1vNUhDDNkmw+7bHcY1o+AObRU2bZy402Tq2+B32VQ+L?= =?us-ascii?Q?r1DubPVUk=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 6:yK+u9oZUWQ/UrSJ7fs4VUKU9y7QWuOqQ8aevFUG3vcS?= =?us-ascii?Q?xpUSHT44vv+m0VpEEQI8z2gWU6avN01rsdiUhS2hWSIe34LlJzGMwbmxu07a?= =?us-ascii?Q?HQFJCP4vVgHn61dXBRamNjqfBhRKKAqKsY4QDyCG3EDLyUvtfMy7D5H9YNBL?= =?us-ascii?Q?SQupukbG33RTlui+dwd0VdzpmOUiW9WywBYhb9xBBV0NfGO2X9MuGhQR+14Z?= =?us-ascii?Q?RPX7AdUg3XD1YAc9h2MMGL+8T/Hko/UhM562bEYZ9BztazgaaMDwUbg3ZQlq?= =?us-ascii?Q?FIHWhe8J8IeZKOJD/ORm3l5+lwPsa1uVxXMRvSOozyBi0U0VS3u3ihEuejry?= =?us-ascii?Q?WOHtgfFbQjfIUGPQnPH+FwwJAgYrB7roJmVTmCQ0pFX5kOhcm9BK6XPuKpps?= =?us-ascii?Q?xnI9zgSS1pmWFWtvpgEJkd9aikiy+hNgmT1BzwbrB0Wugc+vsi/xx/w3E1Rz?= =?us-ascii?Q?YIKg8JXSRdGjzfwcS4s06Jh8ZG9BRN1lp4laTxzbJlpTcTjzoJrQ+gpkPOqb?= =?us-ascii?Q?lhnHfbjlINBRouWTPtH6hhlTTxw+kDdvES0UniDe/Ea1xCxBEdaFdvOWqX+Z?= =?us-ascii?Q?ESkuDw0rolOrGjxzgEqlilcXB3pXyL8SVtOMRjOiW4A3CFcbaz2imMuW70l6?= =?us-ascii?Q?rkT6q4GWARCqyGeE8UzfWBuSXYYrqyRrXOGUY2mZ4U/U1BWNYM6D38aaJKij?= =?us-ascii?Q?og2WPXFWXdki7rjhZlPxrtugx/HI9S2SCiX3JRHHDAjCa/cVdd8ujE467mAC?= =?us-ascii?Q?H+ZYdoTKnCbBQxHcBAcfb6LxrZNLwiJbsE0Rwmk3A73VdEN7Abp+CMT41lRc?= =?us-ascii?Q?C60UBVCmIkMV9E7ipAqFHPup7j1RGu9Y/d5vq40YUnn3qSpipGLKL6zklzPU?= =?us-ascii?Q?kgFgbrRkDNNB1BUSxB6qCgA6/1UjiVISUNPWalsuyOqfXLf0o9jj1c+UVcl+?= =?us-ascii?Q?eZQeVCiqwNyQT0dT9LGHAHAWDyGcYLCh2q6D46DnaKz9lbfsuSICxqC0ssvE?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 5:hjtjq6a7xn+AJRqg2y3hhlkCmCvBUoSE1iJVQHD0H9FdbXb4YG0LlTZmjqqcq1y0ZS9KF3tKjteTPHmAIEkPro9WEthZ268Ud7BTBUGs1H86SbdzSYF/IaW4PqqheImwco5/SZlx+3g/OdcGaRn2RNiW9cu43JFPra7iHU9F8h6ZWOxrdEnYSm+AvGn8ubNbcTlmd5TWoPRpeCnlHYyWdxixjZUDU8D5WIsH8rv9rv6y2LXxXyFH/Vp51Nz6ozRa+Pf8ETb7T9gQwLYdtvpArpbwtFkJtvurTagXfKxa+H2DLsPwN13C1U1gajVDYFbqh19GI0n8tyRquXu7iNVudN6pQq3GRpGbNjiW78e2ajy9HemwOS7Y5XkdBOAYe3gehq6OA83HNAjS4lmHUOWfXi7pSqvfN6a2t8egPy/1F+9weiSbYPKqa633hV7mQ7WMQ/ehX0flQjrCOxDZmfU8iuu5vN09tjxtS0XPhwB4lU3pX74WVXJl5cdJrh/Y3AWy; 24:gIEo0FujycQaJV+D6KY1AKlgzXnUvEx4Fl3Z22M0AMlzyAKEdQQHL1xdPhWcFHk8em20yzdpTqzX/hm3PVbYtP+fOx4sDxGnSA4WeERv2As= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 7:Pure6vx8gOUI793bpPcuhnL/E8KpynWetz+22K7/rIkK+oToovcqA6zrY/ACTsK569tNToLsoPJ3r4MFBTPBfdURaAsTYfALx3h7RulLcfDhYMAhQfLx2GU4H1ix7qa/UdPXpXHZ4uzaFUDK6nZ/RBqCh2rLo0yUdCNAkG9569VaWtIr9NV7cf8DBYyJ+5jllEWYuOPlvWcPREpsU6eNzOfDnKNPzed2Fo+rIZzO5U1BHBOzHh5N7024G6meZc0p65ZLkw+S4XZtYCca4tZjLQVWFhaTPfNfNHDP70L60Ld4DsBDpfG+vQtc1acWi4UxznqZgAu1mjR+jbgCzFRbSdviqNcT2+YkHw7D8P+iro0L+y6ehlieSnMZR2kty9bjC5IWYaL863IJ0ndp1wdoZ4U3/HL/tg3x/t7o72dCWfdEQQUhm7AnGQAJGSkhJ3mPd6MlzUzvDnUHQG3/y3E39cVzKsFOlnIy11kJ68SA1JmdeWktfulgXDkZ+DaVjgVO9z8cww59Ze8rxYxbsrhjO6h0lBS4gjEH3v6H5xRueHn5MPAPTKh/CO2z/hoS3JG+pk2qFyk0vzDXDAf5WfpN8P+tkn39XYCArDNRYLdMHhxlkjBsrNTMFIXvM4pAvOFFgsc6q5qnRmayQR1piJDbF+9MnuFDhIj+US82kDIIi1sM6hToXZh4y4mtZ+OAyTSu5mXrpGQd5JP5Cp8OyMYOe6Me4n7dl+rj1m2Mvaj5bcTb8wXKyLGvcW0qPtKd1VrHGyiskBAyicABvlKGasazh0l/g3M3fZY0LOsc2H6orDc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 20:15:20.3880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes clang shows this warning: /home/emaisin/src/binutils-gdb/gdb/main.c:227:56: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int] char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len); ~~~~~~~~~~~~~~~^~~~~~~~~~~~~ /home/emaisin/src/binutils-gdb/gdb/main.c:227:56: note: use array indexing to silence this warning char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len); ^ & [ ] It's quite easy to get rid of it by using &foo[len] instead of foo + len. I think this warning is relevant to keep enabled, because it can be an easy mistake to do. This warning is already discussed here in GCC bugzilla: https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00729.html and a patch series for it was submitted very recently. gdb/ChangeLog: * main.c (get_init_files): Replace "SYSTEM_GDBINIT + datadir_len" with "&SYSTEM_GDBINIT[datadir_len]". --- gdb/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/main.c b/gdb/main.c index df4b111..9813041 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -224,7 +224,7 @@ get_init_files (const char **system_gdbinit, { /* Append the part of SYSTEM_GDBINIT that follows GDB_DATADIR to gdb_datadir. */ - char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len); + char *tmp_sys_gdbinit = xstrdup (&SYSTEM_GDBINIT[datadir_len]); char *p; for (p = tmp_sys_gdbinit; IS_DIR_SEPARATOR (*p); ++p)