From patchwork Wed Jun 21 20:15:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 21183 Received: (qmail 95623 invoked by alias); 21 Jun 2017 20:15:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 95012 invoked by uid 89); 21 Jun 2017 20:15:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=globally X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:15:23 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 94.E0.18097.8D3DA495; Wed, 21 Jun 2017 22:15:20 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 21 Jun 2017 22:15:19 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.6; Wed, 21 Jun 2017 20:15:18 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 1/4] environ-selftests: Ignore -Wself-move warning Date: Wed, 21 Jun 2017 22:15:05 +0200 Message-ID: <1498076108-29914-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: HE1PR0802CA0016.eurprd08.prod.outlook.com (2603:10a6:3:bd::26) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 308d218d-305b-457c-8b82-08d4b8e23cd1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 3:Xq8D4nYrLo3BaVd68ULclS0dDuMixZI7mLGpFQFJ6FuRF3UXdeG44Zvwyd7OniLBi52cBu1Yq8bukcmc9jINQyAW6of8l4F6idlW2rWpVGBkt6HETcY50pUFcqZk3I5Teaf169Fb0mkM5h9OCJ0xzzF8PjOqMFOjPXcZYnDVlfA3j7HOASjRypSHwZ1Fwo4uKn/2ZfyK1c2LIVDsB+cb2JOLMp7I1wq/YCJx9XhgB6guj/dlJnwkfdvY6tmSmTOG0+FCpLQId7J0Yfy6zImKxTEeZyrE7wQl9mDkGTxU7LO4nQsaiPmfQV+T+/1wZ684kNuTMWFgq+EXCNN+1Ak2Aw==; 25:JBGK0wF6sL28jQylnxqItQrU4hLiO+VhZQ6e1eky5BRijOADtzRp/wVCDeuF6WZ5uZIzBPqqGxapO8X65WHAj5OUuPBCdD8lvbZSWPE6jggHn2rXkCIZNVUlNeOPX71jmzyOofT57ywSTwFnnTgX1fL5QWfez/RzOQU1n4/IsqCPsQOX4vCePiAVESo+FND81gQvAwMSv5QMp3ycuI/GZmGZKE/07BYkgs8C2ez+DS0yWZVwbfU2/JSVbYwh3e9d7SH01D1qmba9nqfzyGn/e/GlvYpOfDNfbJesTpWy7HjFQVqFa/bYIGBLKQcoxypX3kWM9HqP3SkK1B6EuWpkaEgcPLkcZ4LgzD7+iSER7ED8hzXHJnW8Q2GkKxnkasUXMx8Q3bIBvt2eujk802uK9ekFnn80CQiwBaaOtGONebntehUgRAVsaZ97jqtc/mP1Fra/80MRv9/D4WMiT5Ki2orD4iUl5ZfoVbvXQYttfi0= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 31:NMLZByd74Y4EdO/wQnf5WJeMhIib5Gl/3LFAWwol7gM/88UZDZEla6RLsSTtWGb+OrCuFMbdivzCXtEJkzICmcxM4GlcQHDz8gpWWSaVsRSmIY2HQlCwF70neAMAd4VRn/a8M459hsduePJ/PhnEh2dVnxqa9Tp5PTZlffU3kvb6mLa+lhb6nQv20nVS4TG+Bc2G4fJcnI29WoGqN17NgxdWa20blag8HNr7uYimnn4=; 20:2Qg9cbpAWpoTb8RF/93kmSOII/XcFHAiagdB2FTutX0c+2OSdp48NlHlo/p4p90swPFBBmrsc3jDBRjhUS2WAXhVSORWN8NEhDjJrlw+PVDhHTfw/7lwNuncD5YVmyA2E95ZmmN0aqy1zjDUo6eQTp/MgwbLq+rERfTNx09Tvippqq6RZCAi8DkClVAC8+/O55pggS9GJv/PHdEfr3gnko8/AlW+nOQYAjIqX6gJPDcj/yEsUWzoGZgsMCin/8y4vTSDtBiC4b85ZXb44T2Gq+sdmXFPDR+kjsR0OJ2NnCkUS2FOI8UTJ37YwttinBzZhcspOBEVZ1eBXzRT6AakpvcX7RUlIMsI4RYynCGVAngBmhnRBEmjJDMNWvbrVYMLivqLysniHdTUFaGI/xeJM60sZU909KtD4lX9Vwa+SR2nF+loKBERtQF6C2y/EJrdsImqa50lX1ywLOdt4QmXVooNY+FHp1vqW1nJdKMt+nfO7ljMCFiC6dWN4Jya3wHm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DBXPR07MB320; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 4:YiUJbmeQm07Rmi0Gq9Xw5VQgSUQ0bdRwFLL9NbkO4RH?= =?us-ascii?Q?AKWp7GdU4DT/pzcIycJxGW9RIqnVkt9OMX7oYN5eayAbZUo38Y4kQ8n//FKe?= =?us-ascii?Q?Irj8CP1YUq2UnUYu8PA8TNjB4tgazODfO80k050VNuABiRIN6cyYzYC3vTxg?= =?us-ascii?Q?DJmWB8gx4OQ/zT/BaePGpGnKfjLUA3JNPboa0yyQUPLQU8OmPDIvkfqkC9/y?= =?us-ascii?Q?SEkVvqW5ZcahYKBPdxtOYiaFSMT0SFVlrRONh1hq0a1ts4/vulhiMI7OVccc?= =?us-ascii?Q?h+5QOtNRFzEbcG823UTcP1rQky3NXWnYK150YaD75+9ZQH7/s440cE0vU5wj?= =?us-ascii?Q?k1Ln/ycD6zKc3IY0+/aaHbYt/CJ7NGan4vhR8q6831Fph2goEL1d7BKPTUXk?= =?us-ascii?Q?Xh5ItVtHJki6NLm99pndD6UKZVgae7inoyXo1xt/doCOchww2wiMao+bVmoA?= =?us-ascii?Q?4i4/3/NzwPjukBi6gQvoHVTk4R/pb9FKdWLJorj5FND02v9hsgSbV2dtDoab?= =?us-ascii?Q?oXnaQOb4nGZzyyGsLN4XKbZqUV1wEbteLn0hxMWL4KlST3fUAJsarIRnDnbX?= =?us-ascii?Q?bxCa58kf1Zah7s8Zg1BQM/0wutnc7CSebWdzhVBm9/RuxAeG9eXPCTOkyml3?= =?us-ascii?Q?bLfOoI8r/iLlr541wO96fFxHjzHR+3D2POhK1KbRW/qmiR9IcgNg6amDaMMn?= =?us-ascii?Q?tNlefUlLz9k/bp0DnqidoMhIbMDT4LHYmjTZyqpamj+BrU4OVtPfaZcK8Jca?= =?us-ascii?Q?3LyGk86/pp73RCcgoLCqw+FECIhykk8TjhY254XXbQiX4FFL9qn2lKJAWJIp?= =?us-ascii?Q?WYnPyE+W2n1BStkuKZThHYcZcPrpNcgrMjiOoS4ovRBFcIuoZStogrD1GXrC?= =?us-ascii?Q?UcXf/Ar4Hnq0SfkCATLl98Lg1bpuGY2/JhYlZTTA9C1LkymF30klIktdqo5O?= =?us-ascii?Q?CgeKhJYZoh8Azws+yrXFDj8CCgt318G9JvaQyjlZfv1t6OdEsa8kLg/IcabF?= =?us-ascii?Q?Cp7+mHfYBMXmhqA/WO3ZuuZzZlLd/FBicVRAdiXOjngZYcbiG2G9JoZTEjy5?= =?us-ascii?Q?mOj9GBOPhhRwOapcmpSidpKLkJDgGwHRS1UcekQ6A6C8tfLzKz0RjVSVSF4J?= =?us-ascii?Q?TH61/zBLdJwiBoh2/Fq4y2NubOHz8ygl68207PR/BsAxWzMh6/1zbVJo7XAi?= =?us-ascii?Q?2BAe6V1iaOwtjFn5+YY4D0TfzCA5P2O65csPxYiQNQtLt5+NqlCq7pg=3D?= =?us-ascii?Q?=3D?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39860400002)(39450400003)(39410400002)(39400400002)(39850400002)(305945005)(86362001)(5660300001)(6666003)(25786009)(3846002)(6506006)(478600001)(6916009)(2950100002)(966005)(36756003)(8676002)(81166006)(189998001)(42186005)(6486002)(38730400002)(110136004)(107886003)(50986999)(48376002)(76176999)(66066001)(2351001)(2906002)(7736002)(47776003)(50466002)(4326008)(6512007)(5003940100001)(2361001)(6306002)(33646002)(50226002)(6116002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DBXPR07MB320; H:elxacz23q12.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 23:9HqetM/oRkTtt7TX5Bq/UpHDmZUQacLup+Cf/v+Lz3?= =?us-ascii?Q?Po+Y18uh41z55En247M5mjzwMugHhnH7P5oHWp4LuslefAucsVh6R1DX5TCb?= =?us-ascii?Q?6QhbBoHksCjcaWIt0LM26fyE7BGx9WePTqch2yirlvKJSst63sstULfoLfDJ?= =?us-ascii?Q?nyjbNbuICs2vcVwc5FsvaQSLLygRXcHfq87ewG1wi/swt2awx4t4RIfZKA0j?= =?us-ascii?Q?qsFV0r7qhxkrdhHxVmj3uEl0L4NoLAcvjM1MWTy07tbpYRbe5jJylS6agEQA?= =?us-ascii?Q?iFC5bpIf9HtVQGVXsNuftBH4ivzT1VvWfZh+wSsg6OKSVn9lWGO73+Ccb4I6?= =?us-ascii?Q?Ma2N+TRIKAkgC0nd3PYndsc+GrGKGwIvhnmIjMlqhtCMIR+HqAL9XFbD3bRg?= =?us-ascii?Q?2eU/6nTbgGStocCV2TaB0C83P3tmXZzuxe4AS17yIXYX0cEwu4NTWsaECMFq?= =?us-ascii?Q?SUxGCXGSXh7dhZmTnYFWp1Tu/YEHzdg+/ibhx79LsA7gR16qrt7uQWtDwiCh?= =?us-ascii?Q?EjJ9IY1cFxyELfgUwjY74ebhiNOsUvoYH+HgBOCMwGnbFOeHVgwdzhEQrzA6?= =?us-ascii?Q?KJYFhO6IhIfm1IAs9qS0EukoSZpgT0K+4/xzJeZI+8J5slEJD8fx/kEcNSqr?= =?us-ascii?Q?9tFSCIPRrTS5bS1oirb9dOzoW1EDSaeQZM6Z/mcgF5Jnnr6wpWQ32b5zyRNN?= =?us-ascii?Q?bL4uy7rX3fomEr/8jE7gvgJdMJKxOZoXmJY2av8lRFdahVr6K5+SyVY7gpdq?= =?us-ascii?Q?ziP2L0PWOCV7mEk3uZlp+HdXW4oVUbvpAv9d7BFV0xIiPXAg3OHR+axKZfUs?= =?us-ascii?Q?pky/ls2P26LnfMu89oTF2pV6+0FcYc5CbT/2uyF26SiizFZJBDi36gAEMAVl?= =?us-ascii?Q?J3GkfHMKXNjcvwM084O0u+eXIXt5Vq4Em8h5FXfoegdj+ydVXPTv9v4BregF?= =?us-ascii?Q?R4EJTf2wHyzoD6utXXgbVoABdk22rf0S/YwHmhBhfg5HGrrqM1Jgyj8piW+x?= =?us-ascii?Q?zCH9griZp/v10JoVF6Bgy7hTPsg88OLPxXDl7PDxm8V5dqmRyGKYOLyv9hQg?= =?us-ascii?Q?an8/IJ9jVOS9HzrTddBV5MlwmcA6OYRAb0Pv2edxpamKi07pPsB2e44AU8nY?= =?us-ascii?Q?1wvP/OeMM=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DBXPR07MB320; 6:Kj9+SFV/WW+7y3Z5m0X4CLaCA1kd0l3c2p3l9Zux5zP?= =?us-ascii?Q?INf1aQwkYNIKQbFMMYadj/udR/DY+1JUe999hrMht/QyTw579CPdKYEeQDYg?= =?us-ascii?Q?WhBTWxx2wvPDjk9r/7viXYxGv4BpFzPspEzJsGi2ctKrTQAwhncr+ZpagL4H?= =?us-ascii?Q?+Ayn6JqJ0pM4weTf2EHwKLour8A/shIr2Jt6k+iTa9h/YiAo3KLOKdWu1f8y?= =?us-ascii?Q?vz31l9aLiBP2I9MLT2TEIub48eCwZUEdVin5xSSTX52PdzzJnDJyqtpDZaVJ?= =?us-ascii?Q?MjhCePFHfWPEW/lnqyX3+3rq3TKc6fJ5jhqvkEUOG2GSyqAQ5bC1M6h4QBJk?= =?us-ascii?Q?xAuMTiu9PQjj0sAxNo8Ic8Yewj4jYWSHfkNSbfDU+c5r75QWr4Z6c3xKgyQe?= =?us-ascii?Q?dOt9q4DeA6QKLXVOPQD6vvAiMgw9TCveYZ78xi9o/4hzzo80Chlid/lnuWx5?= =?us-ascii?Q?gUpuku5wMwiuPUs7tcpjgsEQLswEAZ7bL3iV2+khLoysDmz7rON6SR2QHnRt?= =?us-ascii?Q?brQHwX4CsVr63h4FJ3qYpjEy3iXvpspLFjXJqUizUXlv5LqBiXhtgq9P5aOZ?= =?us-ascii?Q?Ba6QS1wc+tYrCWgi2f8CJdCjYUd0XhWtJzN9vWqstCwXWKrE9r/x7CNuMTZl?= =?us-ascii?Q?lisFUQtZdvSh4MwWS/PsdWqM60Sx0jWeZd0G8YvwaVhLtbur1oAR25uQ93WS?= =?us-ascii?Q?StZvPU1BQQDbvlmGzUNrZAFfoKAmlgT7gcD/SZbJzTE5d8ZIZYdhAXgY9tAS?= =?us-ascii?Q?mynSk6oZsQw5ZZF2zAHj10voXZ1XgM+wyNtgqZW82h2D3O72joAMzakc1v65?= =?us-ascii?Q?wNt+LUXloog0H6exr/ViaLdzfzhn++77ZYX4Iptc1ja9czCZlBiX3kmM2jFB?= =?us-ascii?Q?x2tywaVrKkAVLiJG6vGlaNstZe/dkuDfyTg3Z3xIyKA3xLEHHDRoJxHZvpk6?= =?us-ascii?Q?6YD1z2dYXewHgJoqRsEAv05WiONB7RUSWOfdx5xgu7Ja+3hXpRcgDZa/ljZ0?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 5:y+aI4xtfbBJjHcSXBRqvikaCNX18J9G2NW9AJPpqcSgUvuwjQsn/JFcJpJJJNH7BFKMFv5+PyhzzXBPfgd0yQB6lBCMR5D3Mh/FY14WrUuLroANGJH/DIvBcDIqI3l6AeKMx7eZULr9wSjGT2K7grAhil4OC72XJ2c7mtMqsAngFiwo4fCIU8RdblFYa0gMkSDWmyUEEUxJh+2rlXaGua8MJ9P1r6NmlATVati+Q6ypnzgJmJfI6WW/r7kOriPLKu/05+duTwuN7nW0oPiXjW+BxxkZH8uBoj+VosHC9hQ/rx3HyXl3WmCHxm5vpLLM8QrCq2ghlqzn6buYUf4qeVkeBCYHs+C4D1DLV+yWkejOxWU6npGGYClxezih4sMAfw/blY7qJc5htqwHILQt6x4qxkm5pcvN7DXTmKnA1mlUtVHGaS90+ZQN2gh+IiDoC0UUhMv6SCHsUPJliCnrbOEWfprEQeLrMAutLkdwh/LOGVu98um22RW0CvFMCVdnI; 24:Lehz6k3mth+MYNrYukOxO8r2NjGiqgOa2bzDNLriAm/lDz2ei290/W20cI+gsT+Mjn7XkpiFhJv/d1OBKLp5VFTY3yMAol2Ykw/B5nnGJ9U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DBXPR07MB320; 7:Fr4l10O0qRn2kJbu4tQEjf/it038oNaEIBBv4J6WIKt9LjoOt6CvSWJXnEq7vzVDSCViCXjY7EjupTbWewLVwtFclhrFlLKpHX527QUc+N+o/O+A2UyVoYa0vqx7pOVEFoRNYaaee3dRyduYO7NS1UeHEKHta4hR3iO4OR4O2DKA4SSgl7/GeY6xKwN9FBIFRmO0/14JAao2zFSbBuBj6CGdelajaDE17CZ1PBqRffLzXN1CfoXvO3wGihlGm3dRh4dvhZowJ6DgAzP9U7ujdqE0ApQ0GgaUWp3UPgW5VD81+3YD4YVwZYWyNjnnjiapjB+61rg8zJMMMi+rdkjG4H6j23F1rDh2smAeGfLZ0Lo4UIzvfcHVUiOLrGnz8LbvgQdGH29lFt8b/dI0oB6IoxY3GHfgrkvDroElwB9oUCHSvI07+cga46qjObnmvnZtqNHv+tU5qzj7e3y/IEQ08CgJ0IfiTRBEJ+GWJD13J1/Ul5fJbws2ZM2lUT5vaFRWkIbRKZi5+UDFU1sx6fLUMKVlKB0+dT+C7znZeOT8lNuVJxu9EbrSgqrIfE+Exm30tBCFsO4SYbNStMnIV1h98Q3Ca2Cu2YRQoo4h3jIB1IZQMtUrt86zQmAD3L6plyThMdaO3Tfp12musLT8/rmPiFIbb9JJzx1rB/Q9DE7JRrRokDsk91ydKScycX+dwJPcSA99DcNgocGY42z5P/AJzfXHl0UjITFNTODOHIDU4lqgWea08k3hGeYwrDFT4hWE+SZZ1DDw0HN7AkBr22rVLH4bXj8akYIatLDWSALNn3w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 20:15:18.5755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes clang gives this warning: /home/emaisin/src/binutils-gdb/gdb/unittests/environ-selftests.c:139:7: error: explicitly moving variable of type 'gdb_environ' to itself [-Werror,-Wself-move] env = std::move (env); ~~~ ^ ~~~ In this case, ignoring the warning locally is clearly the thing to do, since it warns exactly about the behavior we want to test. We also don't want to disable this globally, because we would want the compiler if we wrote that in real code. I filed a bug in GCC's bugzilla to suggest to add this warning: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81159 gdb/ChangeLog: * unittests/environ-selftests.c (run_tests): Ignore -Wself-move warning. --- gdb/unittests/environ-selftests.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/unittests/environ-selftests.c b/gdb/unittests/environ-selftests.c index ecc3955..6989c5e 100644 --- a/gdb/unittests/environ-selftests.c +++ b/gdb/unittests/environ-selftests.c @@ -136,7 +136,16 @@ run_tests () env.clear (); env.set ("A", "1"); SELF_CHECK (strcmp (env.get ("A"), "1") == 0); + +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wself-move" +#endif /* __clang__ */ env = std::move (env); +#ifdef __clang__ +#pragma clang diagnostic pop +#endif /* __clang__ */ + SELF_CHECK (strcmp (env.get ("A"), "1") == 0); SELF_CHECK (strcmp (env.envp ()[0], "A=1") == 0); SELF_CHECK (env.envp ()[1] == NULL);