From patchwork Wed May 31 14:41:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 20657 Received: (qmail 112417 invoked by alias); 31 May 2017 14:41:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 112387 invoked by uid 89); 31 May 2017 14:41:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=memories, OFFSET, transfer X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 14:41:37 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id F8.D6.22014.126DE295; Wed, 31 May 2017 16:41:38 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 31 May 2017 16:41:39 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.ki.sw.ericsson.se (192.176.1.93) by DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1143.6; Wed, 31 May 2017 14:41:36 +0000 From: Simon Marchi To: CC: Eli Zaretskii , Simon Marchi Subject: [PATCH] Change to_xfer_partial doc to use addressable memory units Date: Wed, 31 May 2017 16:41:24 +0200 Message-ID: <1496241684-15687-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 X-ClientProxiedBy: DB6PR0202CA0046.eurprd02.prod.outlook.com (2603:10a6:4:a5::32) To DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR07MB313: X-MS-Office365-Filtering-Correlation-Id: 99a87c14-ffd3-47bf-1276-08d4a83323bf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 3:hU0nGfPrcm0levBQqjjGaC4Y9fcS1bsojalmu9f5M927JkTjDL9lfGR7f1jb+gzVjlHswz2Gm+UPXV5GYiSJ+J5+sKMt5AXDxMB4qIgYmz8gU1TcTfmO9yQn3FTobOi6Uj3haY7pqnimCE3nYt27uLm4A/ju5Saamz0NCJRjjsO6kcanCKJ6xsz5HCSdRlGs0+UWzzmEJmCCk2VD6hSZikpIYiUv4NYECE3i8QMee7fO2CtwrujnIyzW9N9mA+w3Z0Saa5qGJ3UvpSMyYu1crdgEa97hpe5RNkHScZp23uMJxLFdZYpPWsHFLZnkEFVTtqdU4qNfmlACHXWUpclYdQ==; 25:NMHVWzS3uFgMd8alvD8qODu4P/ee11kF2pD7rqM4NQTL4Q7cT1gf4oryJMDrWjhKMFyRUcOdQ+6ngUzLTD6KtH+qzVZOVjH5lkI0649ugNKYtoFc8x05mXSHjGBcsfQ6OSEP3jCLRKlyLQJfnr3KlkrwmrX1cEI5uitB0YZa7rP2v6eBIRG9hV7m/Pqn5wjIlXEOnQYItg9kVlT52wfl/RUBg9cawK3y3jxQqtMH3ZW04BG6qE5+yg1nIa1R+NGPhgKW9ofoUzWc19PO3NI34ISOVbtpqHPXdZb3lT+OT+qxtnMC5ppE8Qpm8YYkt1a0sjbYCzrDhsmpCi6+vPs5X9darvUWHAjCFDzPrCYplINXCQQF/ENmW3pTRCNeQqs9vjElaqfAChme3n9Jgwpvxuob4yRJwaXkwmLjtT+x7CialRtvG+eIofykdJFhyU77jVHHTC6D8niyKG2gHPGkuOaaGbNlsJcPDL77MYaSwb4= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 31:PO79iNmD65Olg6Rc+8u7xG5SCw6qhz1aEFnIOFskCwUc9qh55nJngMhPMOeITy7ygzET6B4P554JiM0F0Tl/Ny9MjhgiLhxy1evlg8+1QxflXy2C4EQU0dT/jFrBxv1l2cyM1+KlzYauXU3OtC0c3ixq4WPJBzkEPfX0KcD68xmxzG6fWDkV0T+5wDsMY+YvFtI3E06qUEqmiTka3oN7h+67dnkIb6Bq7XRBjoXnRJw=; 20:5gqabtrphQ01LG/6Tv5RvQBXskhqox0kdpzkSPxi2Ej3VzONpJoYH2zc9xcKej333Dc0jiwVBTNZkwX5avCADwwtIccZZI4UoDjGB6C9FJpTOyzTwEAGFvsGHhhmACK76Huo3Lb4uuIpjzJd5sJtZUSnLrl7BtBCZh/4KcC5mlxqUnm7Esi1Uxy/EQUDddCnpvya7ERuZ9hYCqQTL20LB2s+IiB7fAIOKPRck9vNlgd/wD9P+Vllx+J/tNXsnKaH5uAHimrsuRfQIBNbMo5OvQYqXonb8DF0NwrPJGqXbHmgaQJSF24+c2E9auHYgdgbkTZKEmUZckq1GEKyz6jrGdWWkuYejs4wAF0k81Q7NL0nNmLcPzTyKjbnqDmIkRC7F6jJ2NLpYKKaR9JomTeVXIhm6hn3lxZu9pCgctHdCYwxMIXfgNzQeWQ5FAgv7ko35q0gN136R0PsNprXeEzWWQwXEPu7eT3uLQLTcCTy1lb0EN5tvaP/fI9SRuSohuyn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(100000703073)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123558100)(6072148)(100000704073)(100105200095)(100000705073)(100105500095); SRVR:DB4PR07MB313; BCL:0; PCL:0; RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095); SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR07MB313; 4:u7U7fV7KaIoPC1ORWAsX3Y9VzeAfbScr8k/sTzlFDrY?= =?us-ascii?Q?MUe0T/9FBGHDAk4KkIb1p40lWnXsaXM9h6cflEIVa6l5DLykHeigxACpCxMb?= =?us-ascii?Q?I810bzte8H7JqXqKLIFsKuE0+IfNgQ/lcuSB2LiAzK4lH0OKbe7oMDTjZSBT?= =?us-ascii?Q?f4iqgOxHp6H0/Gz7M9IEioeg6YHsrVg2qdqUJtRTSE6wbbZj6ltjMUbJ8D+c?= =?us-ascii?Q?dS6vKlf+TuTcNao2cwqjQ0TRabk+NH/78aPSEA4JEH3HPaCsrDOuviXLjnMn?= =?us-ascii?Q?v+lhIfD3CeDmOoVUbZ9Iin7bxXm6x3U8ISmKvkY9qXduF6EoFfyiMNr/lQ9r?= =?us-ascii?Q?ksjV4ZEoWyNEXWVC0FNyOAE3tiJoSjX0DLSEjvLervRgKqnc84nGOdauHyfe?= =?us-ascii?Q?uMWXH6S2ng7u6CIzBL6DpLqHV7H63S0CQ8A1q+btQ8yrlsg6dqGp6WbFgeeh?= =?us-ascii?Q?HMxbuNN5qJ2J4L3SyancOWl/CgKXoD+gz5eTqzr+LM+bESDv9C04UUlQCp4y?= =?us-ascii?Q?4jynjxZNMBPInIpGQSqrNNGH7CAUj8O9Ny/s++0tafoTi3pLW3twTW2lakgW?= =?us-ascii?Q?Pu9+UBCasSMcdzaStgZFXKjTT2MIZKLElqsj+ZgqaaYIj6djbOBzVFQzrkUR?= =?us-ascii?Q?SDfs+qbhZn8ODK94a4E90EgtLNrb2u6nLb8aZQa5OumnqWdj8awZlYiWso/P?= =?us-ascii?Q?xM3dnlx/BKOZiwaHcUHJ8xubXfr6GrJAbhuVBRO5xvpC1rP2A45abpCySA47?= =?us-ascii?Q?BfUuz/F4wo/1AXFQhvDtDjQPB3PyoIp/kNuRJ9NY0BZWr/++/1BRu6C6kaX0?= =?us-ascii?Q?sif8x0NhVnfZxMxGwGfPwKpQhVrIlf92XsMwXKevi2BLtCsOsIB64NJuEnnG?= =?us-ascii?Q?xVx+nhLZBhPdl2zMEBwF1PX9Uk4i5WnYXcvuYZiXwdzJECt9FhgXmFYMvYPY?= =?us-ascii?Q?wX/rgggixJGkHMs0Q9ZdUec0tr27rN10DRPQRQPnIHguf2HfAyvmbBd+wT6l?= =?us-ascii?Q?9W1EoBFVLlG9L2BwloQLrTzlzXzcAvJQ9dQ+rTOVdRpERB0PiGdRWaMDFQQP?= =?us-ascii?Q?dUSnpE4jmBPRStvVh/OD2TBCbFbIlQYdSffwMRMQQ7e3oDGv+DsrkFQvTPzA?= =?us-ascii?Q?nlvpcfJP42uGCDDf90+OPhgjWC9un?= X-Forefront-PRVS: 0324C2C0E2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39840400002)(39860400002)(39850400002)(39410400002)(39450400003)(54534003)(53936002)(25786009)(42186005)(38730400002)(86362001)(478600001)(81166006)(2351001)(2906002)(5003940100001)(110136004)(50226002)(54906002)(8676002)(6916009)(50466002)(6512007)(47776003)(107886003)(66066001)(6666003)(7736002)(50986999)(36756003)(6506006)(305945005)(6486002)(48376002)(6116002)(189998001)(33646002)(4326008)(3846002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR07MB313; H:elxacz23q12.ki.sw.ericsson.se; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR07MB313; 23:rQqIgyulMXTgzMovcUovWt0ArYl6RlcITSjXhqmepK?= =?us-ascii?Q?Zcx8JjgznenRZz+Y8qePhqncTMftzlNbgD+WEa/N/MV94uLsuF3EhU0CnpA+?= =?us-ascii?Q?kOf26atdXTW2KyRfHVRj4380EX05XBCIhu2RdXjiZXmRNYva7fE/RWwkn3bH?= =?us-ascii?Q?w6H2OkAz8NLNgDj6f2mTf/rK8Suu1ovCy4FC8+2QLH5m8G4e5uW/zjxpKOM/?= =?us-ascii?Q?4RNWD1Qzx5g1s97Tlg6j9LBUV9/A3fBGfhcWLvFfT1ETsDyiUT2mdvRKDN8k?= =?us-ascii?Q?c50DBruf+w288gqrIAlRM8x0wTs0mgmWmiPfLxuRrPAZapAD0ztRASZNk1WU?= =?us-ascii?Q?M4YRHjMl8lQIIv1KJd10xCK+2GLMryQaPuiBwFwTQOkcBlb+PLApw23sFwae?= =?us-ascii?Q?KVn1FbX+v4xdFCkO8pCIC02WTrjSw5cVvnxXPHlZN1xoHSI+Y1eyHsZtqml4?= =?us-ascii?Q?q06/nMhaZGW5YeTxFQ3tBdYIQ2kGPjQR9U/65xGPn5oekXC8wC23j1SZXVoM?= =?us-ascii?Q?X/suoblDJIJfZdFevSLOWRNGRcsBfwgPwkfR7KHUVr56DgrPQRRYEb3/bam3?= =?us-ascii?Q?MH8P774ZbSXw7U0ZIU5IZsT8OII5xbVpiLUtOLA8M4FOVppV673rfSJrmkbk?= =?us-ascii?Q?wx4j1p6zTIzA1jz3m8fiHDWjGpbiyicszKX2d61atLiley4GEjzFm2NSRa5X?= =?us-ascii?Q?M2G4Uxh9U5v2vYq409dcyjXr+fEq+bky25U6A1A/qqUlFIKs45bX8X1DlvbC?= =?us-ascii?Q?29SV1tndAI3TbwbVtOhK6ilqv58+0CXCVD/6j5caVxGp3qVVXNcpQ++73JoL?= =?us-ascii?Q?mcPa2ZJJBVS1OrUynJtDthTiP76H9jNV/MeeblU5efL8yitU/6qh13P5BsI8?= =?us-ascii?Q?wLJm6j8S3yove8uuhhTnIdvrsrXAf9ZxLwlbUfhlcXRSWqwhptAcLvmc9fOO?= =?us-ascii?Q?KjO09eoT+qKpu17juuN01Jh1j0wcxTncK48rjRqzgnOuWpU4GBOCRS1vNh0g?= =?us-ascii?Q?sUWzjzVoY8XrCV8RFaXMe1EpbhQKAK9ev6EwwAbxzZo+E3UZu3AOOZ/RpFEp?= =?us-ascii?Q?jWE85J7veZBRlgXt4bFFOpcrlJZAAwqjF0ArvjqKlKXWQOFA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 6:h43cc5/OMh5ZmUFR6NBv+DnqzMXLGAV0FWIyuY6RHb3iRLMshK2tI86iqreks4/QuNlQ6qcHTfL/0HJEuoiK3h8hdY9CZOvlenCulUu14a16P9s3tWY7cfNKJ1Iyk6/U1Yk/LJZb3wJP6o1rnOXuxqs5Om5Cyg90gai2dqHqURqw/yUGOYCKybZH1q999uYySrm4ujrOIceSd4ZUXiZgIki6zsNAXY6B4eACVQPzw/sogcVO+ajPNJ0DfaLTVwJyOGqqEQbar5ldGrUQbI3rdBrGZddF/Z+7SM/uNJKNXXlFbOnEhKyAWk9Q3kjxsKltiuSm3VC6gppCaaLDwoOtN2BwSmnF3oSDZbO2YpWCDbtzoAX/fntbbaUOwwkJjoYXxD/yJYKFaR9We7Werx+TGqEXwa9XBDFcKaWsYhrpyYjsybvUHb+RS8Is8flCsyyvbuHALxHRB8Kl0U5ue7lLEE2xlW2qc/Og/XSkkGfDmWvWs51jIFiaYOiAxIol5cQE4BPwmUzFlo99WdOfhtgVgw== X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 5:GDTIk+DZ2lZs8ZQx8TP416mYr89a5AtPIju3rdbhCGDHI44WJRgrdXvxxM+/rnbEmFyQTHwZD8sQuLfkq75nlmc7uiXpAxT6cAeBt6oD80nHwXkaiacdb1PFUVCSaJxDXfrAQc+vJ2CQ6IIz1GbgRCv9wg2fx0X1vJND9pW0oH75LN6Iehnb7JpgSe5QlJWXPz+QCOA766qviUaRPC+qtgZ5R+csnI2lu4g76HFzoYDkd+3lIVV35lFRDPpOMDmlF2GZEgMi+8fjscEcs6T5EYKSyQqckYI98mysMels1Pu1yyr8ihrtnfr4FE7/B1n+nx9NPsw9tW54r3ubEr8Y0gpCvtmMJvA9Hwmiau5K+hMiHsZvkJObinZQpSwbd/HCLsNk/S+XnOm2PRD3oz0vf7JvSXbsanpj0Pyq82uNuKpInM4dkDodDXCuRxZSTkNovtDKyjgn10ubNsxTu1HcKdjMGv0ipZ+jsj6Gez9St+JBDDyFFOJRU67B85akram/; 24:62i1Xy0buFm4GW6VbUsDCktKaJSt/0nuOcU0czgTJqj6AuRTqhqRZmgfx0fXYaerDHsjeqgqmwZl8RKNVZk3YkgJ7amsKZJBUeAhcW7F/eE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB313; 7:3MyrQgwblOGe2GwkmIasF8/0MVrMqKseIBNKKP+ICuY+//b4xEwMUHYjQmiwtPbVRpvG3y4PXP+65I7kFfv90J4/EQ6BsTSyhgMcgMe9wKLLowatQORg+AhteKgLfWt8L22Mb8qAy35WIc9HzHYOPn1JCVxm2KTXWQExt96ADnxlcf9uqZO74Zffwp+LgX+s2jKja9dZrWpOTLx/i4pLgrndlqXRincxp7OACrVhLx1YLT4AD4F7FNxdyp6uW/f2tokFxIW3X2Xj923m7ZMCIrge4rdNQiHBAhm5qUoJlgW5SAEdAttf+b06rCga3FM5UFpl2WBSaRCsXHSpUYh4Zg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 14:41:36.0261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB313 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes The commit d309493 target: consider addressable unit size when reading/writing memory introduced the possibility of reading memory of targets with non-8-bit-bytes (e.g. memories that store 16 bits at each address). The documentation of target_read and target_write was updated accordingly, but to_xfer_partial, which is very related, wasn't updated. This commit fixes that. gdb/ChangeLog: * target.h (struct target_ops) : Update doc to talk about addressable units instead of bytes. --- gdb/target.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gdb/target.h b/gdb/target.h index a971adf..d46211e 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -712,22 +712,25 @@ struct target_ops CORE_ADDR offset) TARGET_DEFAULT_NORETURN (generic_tls_error ()); - /* Request that OPS transfer up to LEN 8-bit bytes of the target's - OBJECT. The OFFSET, for a seekable object, specifies the + /* Request that OPS transfer up to LEN addressable units of the target's + OBJECT. When reading from a memory object, the size of an addressable + unit is architecture dependent and can be found using + gdbarch_addressable_memory_unit_size. Otherwise, an addressable unit is + 1 byte long. The OFFSET, for a seekable object, specifies the starting point. The ANNEX can be used to provide additional data-specific information to the target. Return the transferred status, error or OK (an - 'enum target_xfer_status' value). Save the number of bytes + 'enum target_xfer_status' value). Save the number of addressable units actually transferred in *XFERED_LEN if transfer is successful - (TARGET_XFER_OK) or the number unavailable bytes if the requested + (TARGET_XFER_OK) or the number unavailable units if the requested data is unavailable (TARGET_XFER_UNAVAILABLE). *XFERED_LEN smaller than LEN does not indicate the end of the object, only the end of the transfer; higher level code should continue transferring if desired. This is handled in target.c. The interface does not support a "retry" mechanism. Instead it - assumes that at least one byte will be transfered on each + assumes that at least one addressable unit will be transfered on each successful call. NOTE: cagney/2003-10-17: The current interface can lead to