From patchwork Fri Mar 10 20:04:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Seitz X-Patchwork-Id: 19520 Received: (qmail 20355 invoked by alias); 10 Mar 2017 20:10:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20284 invoked by uid 89); 10 Mar 2017 20:10:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Mar 2017 20:10:56 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02CD880F94 for ; Fri, 10 Mar 2017 20:04:50 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2AK4lX2029240 for ; Fri, 10 Mar 2017 15:04:49 -0500 From: Keith Seitz To: gdb-patches@sourceware.org Subject: [PATCH v6 07/11] Support DW_TAG_rvalue_reference type Date: Fri, 10 Mar 2017 12:04:42 -0800 Message-Id: <1489176286-27973-8-git-send-email-keiths@redhat.com> In-Reply-To: <1489176286-27973-1-git-send-email-keiths@redhat.com> References: <1489176286-27973-1-git-send-email-keiths@redhat.com> X-IsSubscribed: yes Make gdb DWARF reader understand the DW_TAG_rvalue_reference type tag. Handling of this tag is done in the existing read_tag_reference_type() function, to which we add a new parameter representing the kind of reference type (lvalue vs rvalue). There are no changes to this patch from v5. gdb/ChangeLog PR gdb/14441 From Artemiy Volkov * dwarf2read.c (process_die, read_type_die_1): Handle the DW_TAG_rvalue_reference_type DIE. (read_tag_reference_type): Add new parameter "refcode". --- gdb/ChangeLog | 8 ++++++++ gdb/dwarf2read.c | 15 +++++++++++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 50fd34a..b95ea9e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -2,6 +2,14 @@ PR gdb/14441 From Artemiy Volkov + * dwarf2read.c (process_die, read_type_die_1): Handle the + DW_TAG_rvalue_reference_type DIE. + (read_tag_reference_type): Add new parameter "refcode". + +2017-MM-DD Keith Seitz + + PR gdb/14441 + From Artemiy Volkov * c-typeprint.c (c_print_type, c_type_print_varspec_prefix) (c_type_print_modifier, c_type_print_varspec_suffix) (c_type_print_base): Support printing rvalue reference types. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index f3a8cc6..834dbc0 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -8388,6 +8388,7 @@ process_die (struct die_info *die, struct dwarf2_cu *cu) case DW_TAG_pointer_type: case DW_TAG_ptr_to_member_type: case DW_TAG_reference_type: + case DW_TAG_rvalue_reference_type: case DW_TAG_string_type: break; @@ -14567,16 +14568,19 @@ read_tag_ptr_to_member_type (struct die_info *die, struct dwarf2_cu *cu) return set_die_type (die, type, cu); } -/* Extract all information from a DW_TAG_reference_type DIE and add to +/* Extract all information from a DW_TAG_{rvalue_,}reference_type DIE and add to the user defined type vector. */ static struct type * -read_tag_reference_type (struct die_info *die, struct dwarf2_cu *cu) +read_tag_reference_type (struct die_info *die, struct dwarf2_cu *cu, + enum type_code refcode) { struct comp_unit_head *cu_header = &cu->header; struct type *type, *target_type; struct attribute *attr; + gdb_assert (refcode == TYPE_CODE_REF || refcode == TYPE_CODE_RVALUE_REF); + target_type = die_type (die, cu); /* The die_type call above may have already set the type for this DIE. */ @@ -14584,7 +14588,7 @@ read_tag_reference_type (struct die_info *die, struct dwarf2_cu *cu) if (type) return type; - type = lookup_lvalue_reference_type (target_type); + type = lookup_reference_type (target_type, refcode); attr = dwarf2_attr (die, DW_AT_byte_size, cu); if (attr) { @@ -19620,7 +19624,10 @@ read_type_die_1 (struct die_info *die, struct dwarf2_cu *cu) this_type = read_tag_ptr_to_member_type (die, cu); break; case DW_TAG_reference_type: - this_type = read_tag_reference_type (die, cu); + this_type = read_tag_reference_type (die, cu, TYPE_CODE_REF); + break; + case DW_TAG_rvalue_reference_type: + this_type = read_tag_reference_type (die, cu, TYPE_CODE_RVALUE_REF); break; case DW_TAG_const_type: this_type = read_tag_const_type (die, cu);