From patchwork Wed Feb 22 18:31:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 19348 Received: (qmail 103630 invoked by alias); 22 Feb 2017 18:32:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103002 invoked by uid 89); 22 Feb 2017 18:32:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pg0-f66.google.com Received: from mail-pg0-f66.google.com (HELO mail-pg0-f66.google.com) (74.125.83.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Feb 2017 18:32:25 +0000 Received: by mail-pg0-f66.google.com with SMTP id 1so1460222pgz.2 for ; Wed, 22 Feb 2017 10:32:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KHqYjSNVGine0mp2cVGSa/BIoV7doFXi5HyMyjv/6xE=; b=bPC5/9ZdGXdu6k7T5Grpg+91veYZCovuwbUODHZ+ieVNY2jh8cQkVwXXVFDdg7SxZ1 64NcMBbQ/2GHgXzGUj//Ph+dgBVL6dLFsvO5yIWAW1XWAfKE50VzNQuPx4NtMLce17eU TcRyXPu6srqZm5LKCfb/58sUsDkzQcpQX2pW4LhjWORQFGNXnJ2DFCCCJpRcB1zIrXMJ VshNjnNDNzonvHlp1zjIR/IKIQV/7lxWO7A9j79xGl3WSqmpQbqqZm08B/qU9TDrAQdx VbeMKCYRbEz9+gyQsa00emHAVuArcKWDVGGNRxQmdUFLPXGMhnyAE4hUfBjAwMWWc8tC xB0A== X-Gm-Message-State: AMke39nc+7ovRHVjRRsVCyeyepGhUIS657oIBdlQ8rCRXdHmeqGVlFywmSmb0tkYrctRCw== X-Received: by 10.84.194.1 with SMTP id g1mr16167597pld.98.1487788343836; Wed, 22 Feb 2017 10:32:23 -0800 (PST) Received: from octofox.metropolis (corp.Cadence.COM. [158.140.1.28]) by smtp.gmail.com with ESMTPSA id e13sm5028170pgf.48.2017.02.22.10.32.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Feb 2017 10:32:23 -0800 (PST) From: Max Filippov To: gdb-patches@sourceware.org Cc: Maxim Grigoriev , Woody LaRue , Marc Gauthier , Luis Machado , Max Filippov Subject: [PATCH v3 5/5] gdb: xtensa: fix test for privileged register number Date: Wed, 22 Feb 2017 10:31:33 -0800 Message-Id: <1487788293-25987-6-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1487788293-25987-1-git-send-email-jcmvbkbc@gmail.com> References: <1487788293-25987-1-git-send-email-jcmvbkbc@gmail.com> There are no a0-a15 pseudoregisters at the top of the register set in call0 registers layout. All registers above gdbarch_num_regs (gdbarch) are privileged. Treat them as such. This fixes the following gdb assertion seen when 'finish' command is invoked: regcache.c:649: internal-error: register_status regcache_raw_read(regcache*, int, gdb_byte*): Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed. gdb/ 2017-02-21 Max Filippov * xtensa-tdep.c (xtensa_pseudo_register_read): Treat all registers above gdbarch_num_regs (gdbarch) as privileged in call0 ABI. --- Changes v1->v2: - new patch. gdb/xtensa-tdep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c index 0000155..2338ac1 100644 --- a/gdb/xtensa-tdep.c +++ b/gdb/xtensa-tdep.c @@ -578,7 +578,8 @@ xtensa_pseudo_register_read (struct gdbarch *gdbarch, /* We have to find out how to deal with priveleged registers. Let's treat them as pseudo-registers, but we cannot read/write them. */ - else if (regnum < gdbarch_tdep (gdbarch)->a0_base) + else if (gdbarch_tdep (gdbarch)->call_abi == CallAbiCall0Only + || regnum < gdbarch_tdep (gdbarch)->a0_base) { buffer[0] = (gdb_byte)0; buffer[1] = (gdb_byte)0;