From patchwork Wed Feb 22 02:09:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 19329 Received: (qmail 107325 invoked by alias); 22 Feb 2017 02:09:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105264 invoked by uid 89); 22 Feb 2017 02:09:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pg0-f67.google.com Received: from mail-pg0-f67.google.com (HELO mail-pg0-f67.google.com) (74.125.83.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Feb 2017 02:09:31 +0000 Received: by mail-pg0-f67.google.com with SMTP id 5so21083964pgj.0 for ; Tue, 21 Feb 2017 18:09:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SUaK2jZw0EZ/ETiSPaiID5F3oXqeX86jCKqSaH+XXI8=; b=aAD88HPW8GgTvmai4ZSyTd0pdknuCLXfwfU8VlbRGk7E7HabUQSTpWDRLViMW6b5wu 9NZcn9R+XsTZDlIo90gcdTywR7KMZoY7SHBOXwwhR1cclPMBi4pyHxe6Jn9NrnYP+zVA 6fdKspga59Regs+iYWBaE9NVOtfnzcYqTzoOXZRZHEWv498QPy/Ksn5UfEyz9ShA57cG UJvTlXLGMP6laMOHAgsvRpESUzJPJX9Mj8lLWyQhgW2QTtHRgKgD0/UnYG4k1/UljTtj 99Dy3//IvBUZeIa8mR4SmPLL0k67KFGGGHjs+2uFO491trmW1+RQyj5uVe43VnXVraU5 t2+A== X-Gm-Message-State: AMke39n6k3hzOxn9YFtU+QvrR4IllsvHPSUNiZ91PqhnLJ1+9UFZbGiAwpzO6SiCcJo2LQ== X-Received: by 10.84.213.137 with SMTP id g9mr44556096pli.114.1487729370074; Tue, 21 Feb 2017 18:09:30 -0800 (PST) Received: from octofox.metropolis (corp.Cadence.COM. [158.140.1.28]) by smtp.gmail.com with ESMTPSA id 10sm43172676pfs.113.2017.02.21.18.09.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Feb 2017 18:09:29 -0800 (PST) From: Max Filippov To: gdb-patches@sourceware.org Cc: Maxim Grigoriev , Woody LaRue , Marc Gauthier , Max Filippov Subject: [PATCH v2 1/5] gdb: xtensa: clean up xtensa_default_isa initialization Date: Tue, 21 Feb 2017 18:09:12 -0800 Message-Id: <1487729356-10432-2-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1487729356-10432-1-git-send-email-jcmvbkbc@gmail.com> References: <1487729356-10432-1-git-send-email-jcmvbkbc@gmail.com> This fixes segfault in native gdb because isa is not initialized at the point of call to xtensa_isa_maxlength. gdb/ 2017-02-21 Max Filippov * xtensa-tdep.c (xtensa_scan_prologue, call0_analyze_prologue): Drop xtensa_default_isa initialization. (xtensa_gdbarch_init): Initialize xtensa_default_isa. --- Changes v1->v2: - clean up xtensa_default_isa initialization; - move directory name up in the commit message. gdb/xtensa-tdep.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gdb/xtensa-tdep.c b/gdb/xtensa-tdep.c index 376f4c7..efbd5ab 100644 --- a/gdb/xtensa-tdep.c +++ b/gdb/xtensa-tdep.c @@ -1151,8 +1151,6 @@ xtensa_scan_prologue (struct gdbarch *gdbarch, CORE_ADDR current_pc) if (start_addr == 0) return fp_regnum; - if (!xtensa_default_isa) - xtensa_default_isa = xtensa_isa_init (0, 0); isa = xtensa_default_isa; gdb_assert (XTENSA_ISA_BSZ >= xtensa_isa_maxlength (isa)); ins = xtensa_insnbuf_alloc (isa); @@ -2427,8 +2425,6 @@ call0_analyze_prologue (struct gdbarch *gdbarch, cache->call0 = 1; rtmp = (xtensa_c0reg_t*) alloca(nregs * sizeof(xtensa_c0reg_t)); - if (!xtensa_default_isa) - xtensa_default_isa = xtensa_isa_init (0, 0); isa = xtensa_default_isa; gdb_assert (XTENSA_ISA_BSZ >= xtensa_isa_maxlength (isa)); ins = xtensa_insnbuf_alloc (isa); @@ -3186,6 +3182,9 @@ xtensa_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) DEBUGTRACE ("gdbarch_init()\n"); + if (!xtensa_default_isa) + xtensa_default_isa = xtensa_isa_init (0, 0); + /* We have to set the byte order before we call gdbarch_alloc. */ info.byte_order = XCHAL_HAVE_BE ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE;