Fix gdb.linespec/explicit.exp

  I was chasing the cause of a few timeouts in this testcase (both on my local
machine, Ubuntu 16.04 x86-64, and on a aarch64-elf board) and managed to track
it down to this particular test:

	set tst "complete unique function name"
	send_gdb "break -function mai\t"
	gdb_test_multiple "" $tst {
	    "break -function mai\\\x07n " {
		send_gdb "\n"
		gdb_test "" ".*Breakpoint \[0-9\]+.*" $tst
		gdb_test_no_output "delete \$bpnum" "delete $tst breakpoint"
	    }
	}

FAIL: gdb.linespec/explicit.exp: complete unique function name (timeout)
FAIL: gdb.linespec/explicit.exp: complete non-unique function name (timeout)
FAIL: gdb.linespec/explicit.exp: complete non-existant function name (timeout)
FAIL: gdb.linespec/explicit.exp: complete unique file name (timeout)
FAIL: gdb.linespec/explicit.exp: complete non-unique file name (timeout)

There are 2 problems.

The first one is that i couldn't see the hex character x07 being ouput in both
of the above systems for this particular test. There is really only one
possible completion result for the main function. Maybe this character is
output in other systems?

So i started playing around with the regular expression to make x07 optional,
but no matter what pattern i used, it just didn't match.

It was then that i noticed we're missing a leading "-re" before the
gdb_test_multiple pattern to be matched, the second problem. I checked the
documentation for the command and did not find anything about the use
without "-re".

Keith, is this an oversight or did you really intend to use this construct?

In case of an oversight, i've fixed the other occurrences in
gdb.linespec/explicit.exp.

After the adjustments, i've made x07 optional like so:

"break -function mai\[\x07\]*n "

Even though the escaping is different, i checked the expect debug output to
make sure the same \u0007 character is being expected.

gdb/testsuite/ChangeLog

2017-01-27  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.linespec/explicit.exp: Fix gdb_test_multiple calls missing
	the -re switch.
	Make the x07 character optional in the unique function name completion
	test.
---
 gdb/testsuite/gdb.linespec/explicit.exp | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

Fix gdb.linespec/explicit.exp

Commit Message

Comments

Patch