From patchwork Thu Jan 5 14:48:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 18792 Received: (qmail 118947 invoked by alias); 5 Jan 2017 14:48:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118879 invoked by uid 89); 5 Jan 2017 14:48:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:74.125.83.68, H*RU:74.125.83.68, Hx-languages-length:1970, 1.9.1 X-HELO: mail-pg0-f68.google.com Received: from mail-pg0-f68.google.com (HELO mail-pg0-f68.google.com) (74.125.83.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jan 2017 14:48:23 +0000 Received: by mail-pg0-f68.google.com with SMTP id b1so40919036pgc.1 for ; Thu, 05 Jan 2017 06:48:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=8yVGat7BjSBYM+VG/iOapSfQgofYM4VL6SAo8xbofto=; b=EjlVK8DvB2GuRuOerM85vItCV2GClmD/1T1MVK7nbysOZe5WB7hENr5kHhV0yIHsjA j94FHB5iokEuWFuEqdYjy/j7N5tf5dRMGT1keMP5Q8BuW2PO/kTywCkH7Aulr+rRr4xt MthPwoQbJp/q+qrsT4nw6XtIvWdtW9narYRq6Ji5h1+pf5a9m130aEiEpGiZd0UiAkss j/pXhAkiOPCr8z5SXU8jHVY6LF34BJmxSD3cb2ZHMSyH8C0sALj9FMVqkX1Ely9RIi9c jOHQnDgFHwcNbSEpQKPS39SGlrZx7t7vEsB7iImfyHaXks/ZG6RFSCP0krOPfnqm2UDo +yWA== X-Gm-Message-State: AIkVDXLIHgot1IDY6Ueyk2Ed8vCgvjmv9AKCaT7GXHiYk4OBL8DXG9DIT8af0PNALd1F8Q== X-Received: by 10.84.208.227 with SMTP id c32mr157147648plj.144.1483627701324; Thu, 05 Jan 2017 06:48:21 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id p14sm154290037pfl.74.2017.01.05.06.48.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Jan 2017 06:48:20 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [COMMITTED] Fix ARI warning Date: Thu, 5 Jan 2017 14:48:17 +0000 Message-Id: <1483627697-24892-1-git-send-email-yao.qi@linaro.org> In-Reply-To: <20170105015729.GA44156@sourceware.org> References: <20170105015729.GA44156@sourceware.org> X-IsSubscribed: yes This patch splits the expression before the && operator instead of after it. gdb: 2017-01-05 Yao Qi * mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to new line. (mips64_fbsd_sigframe_init): Likewise. --- gdb/ChangeLog | 6 ++++++ gdb/mips-fbsd-tdep.c | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6f35a0f..df1f03a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2017-01-05 Yao Qi + + * mips-fbsd-tdep.c (mips_fbsd_sigframe_init): Move && to + new line. + (mips64_fbsd_sigframe_init): Likewise. + 2017-01-04 John Baldwin * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Use diff --git a/gdb/mips-fbsd-tdep.c b/gdb/mips-fbsd-tdep.c index ba8c07e..00fae0e 100644 --- a/gdb/mips-fbsd-tdep.c +++ b/gdb/mips-fbsd-tdep.c @@ -332,8 +332,8 @@ mips_fbsd_sigframe_init (const struct tramp_frame *self, regnum + gdbarch_num_regs (gdbarch), ucontext_addr + O32_UCONTEXT_HI); - if (target_read_memory (ucontext_addr + O32_UCONTEXT_FPUSED, buf, 4) == 0 && - extract_unsigned_integer (buf, 4, byte_order) != 0) + if (target_read_memory (ucontext_addr + O32_UCONTEXT_FPUSED, buf, 4) == 0 + && extract_unsigned_integer (buf, 4, byte_order) != 0) { for (regnum = 0, addr = ucontext_addr + O32_UCONTEXT_FPREGS; regnum < 32; regnum++, addr += O32_UCONTEXT_REG_SIZE) @@ -424,8 +424,8 @@ mips64_fbsd_sigframe_init (const struct tramp_frame *self, regnum + gdbarch_num_regs (gdbarch), ucontext_addr + N64_UCONTEXT_HI); - if (target_read_memory (ucontext_addr + N64_UCONTEXT_FPUSED, buf, 4) == 0 && - extract_unsigned_integer (buf, 4, byte_order) != 0) + if (target_read_memory (ucontext_addr + N64_UCONTEXT_FPUSED, buf, 4) == 0 + && extract_unsigned_integer (buf, 4, byte_order) != 0) { for (regnum = 0, addr = ucontext_addr + N64_UCONTEXT_FPREGS; regnum < 32; regnum++, addr += N64_UCONTEXT_REG_SIZE)