From patchwork Wed Nov 30 12:00:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 18062 Received: (qmail 96817 invoked by alias); 30 Nov 2016 12:00:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 92786 invoked by uid 89); 30 Nov 2016 12:00:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=20161130 X-HELO: mail-pg0-f67.google.com Received: from mail-pg0-f67.google.com (HELO mail-pg0-f67.google.com) (74.125.83.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 12:00:20 +0000 Received: by mail-pg0-f67.google.com with SMTP id e9so1182034pgc.1 for ; Wed, 30 Nov 2016 04:00:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=O0jIb7j1VcqCAzsBYETZbdxE2CjlxaxhD2Tr5tPJViY=; b=fNm6ocJYXBAxCsAAHRhzGRs8LWEK3oxJx1zjoZ3dEUHix344udHMEs1T74eDDeWks7 /C0/IA9GfRO4Bx0rRV3kIKuBKNqFP1lgWLeVPg8Oe+2MRJNejbHktC51fmuAgVrtfWaN 0vw5yGafTardtmXRZjR1ar5JM6gc/byfKAdGY9BMpoidqeCA8omIYNsgA+BD0fdb6/vl U545GodhOyF2kSzjVCz4drUBL7JJP0x3+2/h4TwUXLm/6T4pbsAA9jflnVJ/HlJzcck/ VspRgD5e0znXEdidDieWAM1Kmnr2TOC1NpD58SluKJDsnO0j/NASAawuaqtE3bpMtVFm g2xg== X-Gm-Message-State: AKaTC00mC/b/u9OWbPY8X0ekxDgSkM0mg+QlS60qt1hIN6ph2XARXiyO5qKIGQqUrCtpsQ== X-Received: by 10.98.196.89 with SMTP id y86mr32441282pff.172.1480507213806; Wed, 30 Nov 2016 04:00:13 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (power8-aix.osuosl.org. [140.211.9.96]) by smtp.gmail.com with ESMTPSA id 1sm75049880pgp.1.2016.11.30.04.00.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Nov 2016 04:00:13 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH] [ARM, PUSHED] Read memory as unsigned integer Date: Wed, 30 Nov 2016 12:00:06 +0000 Message-Id: <1480507206-8980-1-git-send-email-yao.qi@linaro.org> X-IsSubscribed: yes When GDB read inferior memory as an address or an instruction, it should be unsigned. Patch is pushed in. gdb: 2016-11-30 Yao Qi * arm-tdep.c (arm_scan_prologue): Read memory as unsigned integer. (arm_exidx_unwind_sniffer): Likewise. --- gdb/ChangeLog | 5 +++++ gdb/arm-tdep.c | 17 +++++++++-------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 59c39fe..03e5f0f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2016-11-30 Yao Qi + + * arm-tdep.c (arm_scan_prologue): Read memory as unsigned integer. + (arm_exidx_unwind_sniffer): Likewise. + 2016-11-28 Simon Marchi * record-full.c (record_full_open_1): Fix debug output. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 0b93df7..fd5d0de 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -1807,10 +1807,11 @@ arm_scan_prologue (struct frame_info *this_frame, the callee (or at the present moment if this is the innermost frame). The value stored there should be the address of the stmfd + 8. */ CORE_ADDR frame_loc; - LONGEST return_value; + ULONGEST return_value; frame_loc = get_frame_register_unsigned (this_frame, ARM_FP_REGNUM); - if (!safe_read_memory_integer (frame_loc, 4, byte_order, &return_value)) + if (!safe_read_memory_unsigned_integer (frame_loc, 4, byte_order, + &return_value)) return; else { @@ -2659,19 +2660,19 @@ arm_exidx_unwind_sniffer (const struct frame_unwind *self, ensure this, so that e.g. pthread cancellation works. */ if (arm_frame_is_thumb (this_frame)) { - LONGEST insn; + ULONGEST insn; - if (safe_read_memory_integer (get_frame_pc (this_frame) - 2, 2, - byte_order_for_code, &insn) + if (safe_read_memory_unsigned_integer (get_frame_pc (this_frame) - 2, + 2, byte_order_for_code, &insn) && (insn & 0xff00) == 0xdf00 /* svc */) exc_valid = 1; } else { - LONGEST insn; + ULONGEST insn; - if (safe_read_memory_integer (get_frame_pc (this_frame) - 4, 4, - byte_order_for_code, &insn) + if (safe_read_memory_unsigned_integer (get_frame_pc (this_frame) - 4, + 4, byte_order_for_code, &insn) && (insn & 0x0f000000) == 0x0f000000 /* svc */) exc_valid = 1; }