[03/20] Fix spelling mistakes in comments in makefiles

Message ID 1479654381-20698-4-git-send-email-ambrogino.modigliani@mail.com
State New, archived
Headers

Commit Message

Ambrogino Modigliani Nov. 20, 2016, 3:06 p.m. UTC
  gas/ChangeLog:

        * gas/Makefile.am: Fix spelling in comments.
        * gas/Makefile.in: Fix spelling in comments.

gdb/ChangeLog:

        * gdb/Makefile.in: Fix spelling in comments.

readline/ChangeLog:

        * readline/examples/rlfe/Makefile.in: Fix spelling in comments.

sim/mips/ChangeLog:

        * sim/mips/Makefile.in: Fix spelling in comments.
---
 gas/Makefile.am                    | 2 +-
 gas/Makefile.in                    | 2 +-
 gdb/Makefile.in                    | 6 +++---
 readline/examples/rlfe/Makefile.in | 2 +-
 sim/mips/Makefile.in               | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
  

Comments

Simon Marchi Nov. 20, 2016, 4:53 p.m. UTC | #1
On 2016-11-20 10:06, Ambrogino Modigliani wrote:
> gas/ChangeLog:
> 
>         * gas/Makefile.am: Fix spelling in comments.
>         * gas/Makefile.in: Fix spelling in comments.

This is almost nit-picking, since the end result is the same, but I'll 
say it just to be sure you know about it.  This particular "Makefile.in" 
is generated from "Makefile.am" using automake-1.11 (as seen in the 
header of Makefile.in).  Just like with the "configure" scripts, you 
should not edit "Makefile.in" directly.  You first edit "Makefile.am" 
and run automake-1.11 to generate "Makefile.in" (again, some 
distributions still package automake 1.11).  Then, your ChangeLog entry 
can look like:

gas/ChangeLog:

         * Makefile.am: Fix spelling in comments.
         * Makefile.in: Re-generate.

When there's a "Makefile.in" without a "Makefile.am", it means that this 
one is written by hand, so it's okay to edit it directly.

Another point, which I think applies to all of your patches, is that 
your ChangeLog entries should be relative to the location of the 
ChangeLog they belong in.  For example, since this entry goes in 
"gas/ChangeLog", the entry referring to "gas/Makefile.am" should not be:

         * gas/Makefile.am: Fix spelling in comments.

but:

         * Makefile.am: Fix spelling in comments.

Thanks,

Simon
  

Patch

diff --git a/gas/Makefile.am b/gas/Makefile.am
index cdaf9f5..d4b833f 100644
--- a/gas/Makefile.am
+++ b/gas/Makefile.am
@@ -52,7 +52,7 @@  TARG_ENV_H = $(srcdir)/config/te-@te_file@.h
 ATOF_TARG_C = $(srcdir)/config/atof-@atof@.c
 ATOF_TARG_O = atof-@atof@.@OBJEXT@
 
-# use @target_cpu_type@ for refering to configured target name
+# use @target_cpu_type@ for referring to configured target name
 IT_HDRS=itbl-parse.h $(srcdir)/itbl-ops.h
 IT_SRCS=itbl-parse.c itbl-lex-wrapper.c $(srcdir)/itbl-ops.c
 IT_DEPS=$(srcdir)/itbl-parse.y $(srcdir)/itbl-lex.l $(srcdir)/config/itbl-@target_cpu_type@.h
diff --git a/gas/Makefile.in b/gas/Makefile.in
index 84f746d..c9231dc 100644
--- a/gas/Makefile.in
+++ b/gas/Makefile.in
@@ -350,7 +350,7 @@  TARG_ENV_H = $(srcdir)/config/te-@te_file@.h
 ATOF_TARG_C = $(srcdir)/config/atof-@atof@.c
 ATOF_TARG_O = atof-@atof@.@OBJEXT@
 
-# use @target_cpu_type@ for refering to configured target name
+# use @target_cpu_type@ for referring to configured target name
 IT_HDRS = itbl-parse.h $(srcdir)/itbl-ops.h
 IT_SRCS = itbl-parse.c itbl-lex-wrapper.c $(srcdir)/itbl-ops.c
 IT_DEPS = $(srcdir)/itbl-parse.y $(srcdir)/itbl-lex.l $(srcdir)/config/itbl-@target_cpu_type@.h
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index b68cf58..e94d450 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1372,7 +1372,7 @@  test-cp-name-parser$(EXEEXT): test-cp-name-parser.o $(LIBIBERTY)
 # FIXME: cagney/2002-06-09: gdb/564: gdb/563: Force the order so that
 # the first call is to _initialize_gdbtypes (implemented by explicitly
 # putting that function's name first in the init.l-tmp file).  This is
-# a hack to ensure that all the architecture dependant global
+# a hack to ensure that all the architecture dependent global
 # builtin_type_* variables are initialized before anything else
 # (per-architecture code is called in the same order that it is
 # registered).  The ``correct fix'' is to have all the builtin types
@@ -1825,7 +1825,7 @@  ALLDEPFILES = \
 # errors.  It turns out that that is the least of monitor.c's
 # problems.  The function print_vsprintf appears to be using
 # va_arg(long) to extract CORE_ADDR parameters - something that
-# definitly will not work.  "monitor.c" needs to be rewritten so that
+# definitely will not work.  "monitor.c" needs to be rewritten so that
 # it doesn't use format strings and instead uses callbacks.
 monitor.o: $(srcdir)/monitor.c
 	$(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_FORMAT) \
@@ -1914,7 +1914,7 @@  clean-po:
 # rule has no dependencies and always regenerates gdb.pot.  This is
 # relatively harmless since the .po files do not directly depend on
 # it.  The .pot file is left in the build directory.  Since GDB's
-# Makefile lacks a cannonical list of sources (missing xm, tm and nm
+# Makefile lacks a canonical list of sources (missing xm, tm and nm
 # files) force this rule.
 $(PACKAGE).pot: po/$(PACKAGE).pot
 po/$(PACKAGE).pot: force
diff --git a/readline/examples/rlfe/Makefile.in b/readline/examples/rlfe/Makefile.in
index 7d6fd53..f60c504 100644
--- a/readline/examples/rlfe/Makefile.in
+++ b/readline/examples/rlfe/Makefile.in
@@ -1,7 +1,7 @@ 
 #
 # Makefile template for rlfe 
 #
-# See machine dependant config.h for more configuration options.
+# See machine dependent config.h for more configuration options.
 #
 
 srcdir = @srcdir@
diff --git a/sim/mips/Makefile.in b/sim/mips/Makefile.in
index 7f1c916..9bb272a 100644
--- a/sim/mips/Makefile.in
+++ b/sim/mips/Makefile.in
@@ -119,7 +119,7 @@  IGEN_INCLUDE=\
 	$(srcdir)/mips3264r2.igen \
 
 # NB:	Since these can be built by a number of generators, care
-#	must be taken to ensure that they are only dependant on
+#	must be taken to ensure that they are only dependent on
 #	one of those generators.
 BUILT_SRC_FROM_GEN = \
 	itable.h \