From patchwork Thu Nov 10 22:19:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 17401 Received: (qmail 64707 invoked by alias); 10 Nov 2016 22:20:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 64375 invoked by uid 89); 10 Nov 2016 22:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 10 Nov 2016 22:20:04 +0000 Received: (qmail 19040 invoked by uid 0); 10 Nov 2016 22:20:03 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy6.mail.unifiedlayer.com with SMTP; 10 Nov 2016 22:20:03 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 6NKz1u01Q2f2jeq01NL2DQ; Thu, 10 Nov 2016 15:20:02 -0700 X-Authority-Analysis: v=2.1 cv=WL/sABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=32m1L_KKf_ST6H1QTKUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:60120 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c4xhP-0002sd-NV; Thu, 10 Nov 2016 15:19:59 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 15/20] Use gdbpy_enter in python_interactive_command Date: Thu, 10 Nov 2016 15:19:42 -0700 Message-Id: <1478816387-27064-16-git-send-email-tom@tromey.com> In-Reply-To: <1478816387-27064-1-git-send-email-tom@tromey.com> References: <1478816387-27064-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1c4xhP-0002sd-NV X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya.Home) [174.16.143.211]:60120 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This changes python_interactive_command to use gdbpy_enter. Previously this function was leaving a dangling cleanup -- this is sort of ok in a command function, but IMO it's still better to clean up. 2016-11-10 Tom Tromey * python/python.c (python_interactive_command): Use gdbpy_enter. --- gdb/ChangeLog | 4 ++++ gdb/python/python.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 14ecd00..1a415fb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-11-10 Tom Tromey + * python/python.c (python_interactive_command): Use gdbpy_enter. + +2016-11-10 Tom Tromey + * python/python.c (gdbpy_before_prompt_hook): Use gdbpy_enter, gdbpy_reference. diff --git a/gdb/python/python.c b/gdb/python/python.c index 393937d..471f9e2 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -321,7 +321,7 @@ python_interactive_command (char *arg, int from_tty) arg = skip_spaces (arg); - ensure_python_env (get_current_arch (), current_language); + gdbpy_enter enter_py (get_current_arch (), current_language); if (arg && *arg) {