From patchwork Mon Nov 7 05:47:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 17249 Received: (qmail 79251 invoked by alias); 7 Nov 2016 05:48:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 76193 invoked by uid 89); 7 Nov 2016 05:48:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=H*r:4.86_1, H*Ad:U*tom, Hx-languages-length:1483 X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 07 Nov 2016 05:47:46 +0000 Received: (qmail 1604 invoked by uid 0); 7 Nov 2016 05:47:44 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy6.mail.unifiedlayer.com with SMTP; 7 Nov 2016 05:47:44 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 4tnf1u00L2f2jeq01tnihT; Sun, 06 Nov 2016 22:47:42 -0700 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=HR-Riijir8wyCBzPvAsA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:47918 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1c3cmT-0008A3-7U; Sun, 06 Nov 2016 22:47:41 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 06/14] Use gdbpy_reference in gdbpy_inferiors Date: Sun, 6 Nov 2016 22:47:28 -0700 Message-Id: <1478497656-11832-7-git-send-email-tom@tromey.com> In-Reply-To: <1478497656-11832-1-git-send-email-tom@tromey.com> References: <1478497656-11832-1-git-send-email-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1c3cmT-0008A3-7U X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya.Home) [174.16.143.211]:47918 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== This changes gdbpy_inferiors to use gdbpy_reference. 2016-11-06 Tom Tromey * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_reference. --- gdb/ChangeLog | 4 ++++ gdb/python/py-inferior.c | 18 +++++------------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8271499..164b568 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-11-06 Tom Tromey + * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_reference. + +2016-11-06 Tom Tromey + * python/py-function.c (convert_values_to_python, fnpy_init): Use gdbpy_reference. diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index 8732b87..b343c0f 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -477,22 +477,14 @@ build_inferior_list (struct inferior *inf, void *arg) PyObject * gdbpy_inferiors (PyObject *unused, PyObject *unused2) { - PyObject *list, *tuple; - - list = PyList_New (0); - if (!list) + gdbpy_reference list (PyList_New (0)); + if (list == NULL) return NULL; - if (iterate_over_inferiors (build_inferior_list, list)) - { - Py_DECREF (list); - return NULL; - } - - tuple = PyList_AsTuple (list); - Py_DECREF (list); + if (iterate_over_inferiors (build_inferior_list, list.get ())) + return NULL; - return tuple; + return PyList_AsTuple (list.get ()); } /* Membuf and memory manipulation. */